From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: [PATCH v2 8/8] net: phy: fixed_phy: transition to the faux device interface
Date: Tue, 18 Mar 2025 17:01:46 +0000 [thread overview]
Message-ID: <20250318-plat2faux_dev-v2-8-e6cc73f78478@arm.com> (raw)
In-Reply-To: <20250318-plat2faux_dev-v2-0-e6cc73f78478@arm.com>
The net fixed phy driver does not require the creation of a platform
device. Originally, this approach was chosen for simplicity when the
driver was first implemented.
With the introduction of the lightweight faux device interface, we now
have a more appropriate alternative. Migrate the device to utilize the
faux bus, given that the platform device it previously created was not
a real one anyway. This will get rid of the fake platform device.
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/net/phy/fixed_phy.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c
index aef739c20ac4d5a271465a677a85ef7c18cfce70..ee7831a9849b3728ca9c541da35d17e089985da2 100644
--- a/drivers/net/phy/fixed_phy.c
+++ b/drivers/net/phy/fixed_phy.c
@@ -10,7 +10,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/platform_device.h>
+#include <linux/device/faux.h>
#include <linux/list.h>
#include <linux/mii.h>
#include <linux/phy.h>
@@ -40,7 +40,7 @@ struct fixed_phy {
struct gpio_desc *link_gpiod;
};
-static struct platform_device *pdev;
+static struct faux_device *fdev;
static struct fixed_mdio_bus platform_fmb = {
.phys = LIST_HEAD_INIT(platform_fmb.phys),
};
@@ -337,9 +337,9 @@ static int __init fixed_mdio_bus_init(void)
struct fixed_mdio_bus *fmb = &platform_fmb;
int ret;
- pdev = platform_device_register_simple("Fixed MDIO bus", 0, NULL, 0);
- if (IS_ERR(pdev))
- return PTR_ERR(pdev);
+ fdev = faux_device_create("Fixed MDIO bus", NULL, NULL);
+ if (!fdev)
+ return -ENODEV;
fmb->mii_bus = mdiobus_alloc();
if (fmb->mii_bus == NULL) {
@@ -350,7 +350,7 @@ static int __init fixed_mdio_bus_init(void)
snprintf(fmb->mii_bus->id, MII_BUS_ID_SIZE, "fixed-0");
fmb->mii_bus->name = "Fixed MDIO Bus";
fmb->mii_bus->priv = fmb;
- fmb->mii_bus->parent = &pdev->dev;
+ fmb->mii_bus->parent = &fdev->dev;
fmb->mii_bus->read = &fixed_mdio_read;
fmb->mii_bus->write = &fixed_mdio_write;
fmb->mii_bus->phy_mask = ~0;
@@ -364,7 +364,7 @@ static int __init fixed_mdio_bus_init(void)
err_mdiobus_alloc:
mdiobus_free(fmb->mii_bus);
err_mdiobus_reg:
- platform_device_unregister(pdev);
+ faux_device_destroy(fdev);
return ret;
}
module_init(fixed_mdio_bus_init);
@@ -376,7 +376,7 @@ static void __exit fixed_mdio_bus_exit(void)
mdiobus_unregister(fmb->mii_bus);
mdiobus_free(fmb->mii_bus);
- platform_device_unregister(pdev);
+ faux_device_destroy(fdev);
list_for_each_entry_safe(fp, tmp, &fmb->phys, node) {
list_del(&fp->node);
--
2.34.1
next prev parent reply other threads:[~2025-03-18 17:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 17:01 [PATCH v2 0/8] drivers: Transition to the faux device interface Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 1/8] driver core: add helper macro for module_faux_driver() boilerplate Sudeep Holla
2025-04-15 12:21 ` Greg Kroah-Hartman
2025-04-15 12:25 ` Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 2/8] cpuidle: psci: Transition to the faux device interface Sudeep Holla
2025-04-15 12:21 ` Greg Kroah-Hartman
2025-04-15 12:35 ` Sudeep Holla
2025-05-01 13:01 ` Jon Hunter
2025-05-01 16:07 ` Sudeep Holla
2025-05-02 10:20 ` Jon Hunter
2025-03-18 17:01 ` [PATCH v2 3/8] hwrng: arm-smccc-trng - transition " Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 4/8] rtc: efi: Transition " Sudeep Holla
2025-04-08 14:45 ` (subset) " Alexandre Belloni
2025-04-08 15:01 ` Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 5/8] virt: efi_secret: " Sudeep Holla
2025-03-18 17:10 ` Ard Biesheuvel
2025-03-19 13:15 ` Sudeep Holla
2025-03-19 14:24 ` Greg Kroah-Hartman
2025-03-19 14:30 ` Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 6/8] efi: efivars: " Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 7/8] ACPI: APEI: EINJ: " Sudeep Holla
2025-04-09 18:18 ` Rafael J. Wysocki
2025-03-18 17:01 ` Sudeep Holla [this message]
2025-03-18 17:12 ` [PATCH v2 8/8] net: phy: fixed_phy: transition " Andrew Lunn
2025-03-19 11:05 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318-plat2faux_dev-v2-8-e6cc73f78478@arm.com \
--to=sudeep.holla@arm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.