All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/8] driver core: add helper macro for module_faux_driver() boilerplate
Date: Tue, 15 Apr 2025 14:21:10 +0200	[thread overview]
Message-ID: <2025041510-virtual-flagstone-8b3f@gregkh> (raw)
In-Reply-To: <20250318-plat2faux_dev-v2-1-e6cc73f78478@arm.com>

On Tue, Mar 18, 2025 at 05:01:39PM +0000, Sudeep Holla wrote:
> For simple modules that needs to create a faux device without any
> additional setup code ends up being a block of duplicated boilerplate.
> 
> Add a new macro, module_faux_driver(), which help to replaces the
> those duplicated boilerplate.
> 
> This macro use the same idea of module_platform_driver() but adds this
> initial condition to avoid creation of faux device if not necessary.

What is this "condition" for?

Every time you put "true" or "false" in the function call, someone will
have to look it up to see what is going on, that's going to be a pain.

Making apis is hard, let's not making using them even harder.

thanks,

greg k-h

  reply	other threads:[~2025-04-15 12:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18 17:01 [PATCH v2 0/8] drivers: Transition to the faux device interface Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 1/8] driver core: add helper macro for module_faux_driver() boilerplate Sudeep Holla
2025-04-15 12:21   ` Greg Kroah-Hartman [this message]
2025-04-15 12:25     ` Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 2/8] cpuidle: psci: Transition to the faux device interface Sudeep Holla
2025-04-15 12:21   ` Greg Kroah-Hartman
2025-04-15 12:35     ` Sudeep Holla
2025-05-01 13:01   ` Jon Hunter
2025-05-01 16:07     ` Sudeep Holla
2025-05-02 10:20       ` Jon Hunter
2025-03-18 17:01 ` [PATCH v2 3/8] hwrng: arm-smccc-trng - transition " Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 4/8] rtc: efi: Transition " Sudeep Holla
2025-04-08 14:45   ` (subset) " Alexandre Belloni
2025-04-08 15:01     ` Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 5/8] virt: efi_secret: " Sudeep Holla
2025-03-18 17:10   ` Ard Biesheuvel
2025-03-19 13:15     ` Sudeep Holla
2025-03-19 14:24       ` Greg Kroah-Hartman
2025-03-19 14:30         ` Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 6/8] efi: efivars: " Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 7/8] ACPI: APEI: EINJ: " Sudeep Holla
2025-04-09 18:18   ` Rafael J. Wysocki
2025-03-18 17:01 ` [PATCH v2 8/8] net: phy: fixed_phy: transition " Sudeep Holla
2025-03-18 17:12   ` Andrew Lunn
2025-03-19 11:05     ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025041510-virtual-flagstone-8b3f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.