All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Takahiro Kuwano <tkuw584924@gmail.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <mwalle@kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bacem Daassi <Bacem.Daassi@infineon.com>,
	Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
Subject: Re: [PATCH 2/3] mtd: spi-nor: use rdid-dummy-ncycles DT property
Date: Wed, 19 Mar 2025 18:30:24 -0500	[thread overview]
Message-ID: <20250319233024.GA2625856-robh@kernel.org> (raw)
In-Reply-To: <20250319-snor-rdid-dummy-ncycles-v1-2-fbf64e4c226a@infineon.com>

On Wed, Mar 19, 2025 at 06:47:44PM +0900, Takahiro Kuwano wrote:
> There are infineon flashes [1] that require 8 dummy cycles for the
> 1-1-1 Read ID command. Since the command is not covered by JESD216
> or any other standard, get the number of dummy cycles from DT and use
> them to correctly identify the flash.

If Read ID fails, then couldn't you just retry with dummy cycles? Or 
would unconditionally adding dummy cycles adversely affect other chips?

Otherwise, add a specific compatible to imply this requirement. Adding 
quirk properties doesn't scale.

Rob

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Takahiro Kuwano <tkuw584924@gmail.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <mwalle@kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bacem Daassi <Bacem.Daassi@infineon.com>,
	Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
Subject: Re: [PATCH 2/3] mtd: spi-nor: use rdid-dummy-ncycles DT property
Date: Wed, 19 Mar 2025 18:30:24 -0500	[thread overview]
Message-ID: <20250319233024.GA2625856-robh@kernel.org> (raw)
In-Reply-To: <20250319-snor-rdid-dummy-ncycles-v1-2-fbf64e4c226a@infineon.com>

On Wed, Mar 19, 2025 at 06:47:44PM +0900, Takahiro Kuwano wrote:
> There are infineon flashes [1] that require 8 dummy cycles for the
> 1-1-1 Read ID command. Since the command is not covered by JESD216
> or any other standard, get the number of dummy cycles from DT and use
> them to correctly identify the flash.

If Read ID fails, then couldn't you just retry with dummy cycles? Or 
would unconditionally adding dummy cycles adversely affect other chips?

Otherwise, add a specific compatible to imply this requirement. Adding 
quirk properties doesn't scale.

Rob

  reply	other threads:[~2025-03-19 23:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19  9:47 [PATCH 0/3] mtd: spi-nor: introduce optional rdid-dummy-ncycles DT property Takahiro Kuwano
2025-03-19  9:47 ` Takahiro Kuwano
2025-03-19  9:47 ` [PATCH 1/3] dt-bindings: mtd: jedec,spi-nor: add optional rdid-dummy-ncycles Takahiro Kuwano
2025-03-19  9:47   ` Takahiro Kuwano
2025-03-19  9:47 ` [PATCH 2/3] mtd: spi-nor: use rdid-dummy-ncycles DT property Takahiro Kuwano
2025-03-19  9:47   ` Takahiro Kuwano
2025-03-19 23:30   ` Rob Herring [this message]
2025-03-19 23:30     ` Rob Herring
2025-03-20  7:30     ` Michael Walle
2025-03-20  7:30       ` Michael Walle
2025-03-20  7:44     ` Tudor Ambarus
2025-03-20  7:44       ` Tudor Ambarus
2025-03-20 14:06       ` Rob Herring
2025-03-20 14:06         ` Rob Herring
2025-03-20 15:45         ` Tudor Ambarus
2025-03-20 15:45           ` Tudor Ambarus
2025-03-21  8:00           ` Michael Walle
2025-03-21  8:00             ` Michael Walle
2025-03-26 14:44             ` Tudor Ambarus
2025-03-26 14:44               ` Tudor Ambarus
2025-03-27 10:43               ` Takahiro Kuwano
2025-03-27 10:43                 ` Takahiro Kuwano
2025-03-21  8:55           ` Takahiro Kuwano
2025-03-21  8:55             ` Takahiro Kuwano
2025-03-19  9:47 ` [PATCH 3/3] mtd: spi-nor: spansion: add support for CYRS17B512 Takahiro Kuwano
2025-03-19  9:47   ` Takahiro Kuwano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250319233024.GA2625856-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Bacem.Daassi@infineon.com \
    --cc=Takahiro.Kuwano@infineon.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tkuw584924@gmail.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.