All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Neal Cardwell <ncardwell@google.com>,
	Kuniyuki Iwashima <kuniyu@amazon.com>,
	netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH v2 net-next 2/2] tcp/dccp: remove icsk->icsk_ack.timeout
Date: Thu, 20 Mar 2025 18:38:58 +0000	[thread overview]
Message-ID: <20250320183858.GJ892515@horms.kernel.org> (raw)
In-Reply-To: <20250318154359.778438-3-edumazet@google.com>

On Tue, Mar 18, 2025 at 03:43:59PM +0000, Eric Dumazet wrote:
> icsk->icsk_ack.timeout can be replaced by icsk->csk_delack_timer.expires
> 
> This saves 8 bytes in TCP/DCCP sockets and helps for better cache locality.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
> ---
> v2: rebase after "tcp: cache RTAX_QUICKACK metric in a hot cache line"

Hi Eric,

I hate to be a bore, but patch 2/2 does seem to apply to net-next.

  reply	other threads:[~2025-03-20 18:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18 15:43 [PATCH v2 net-next 0/2] tcp/dccp: remove 16 bytes from icsk Eric Dumazet
2025-03-18 15:43 ` [PATCH v2 net-next 1/2] tcp/dccp: remove icsk->icsk_timeout Eric Dumazet
2025-03-18 15:43 ` [PATCH v2 net-next 2/2] tcp/dccp: remove icsk->icsk_ack.timeout Eric Dumazet
2025-03-20 18:38   ` Simon Horman [this message]
2025-03-20 19:00     ` Eric Dumazet
2025-03-20 20:10       ` Simon Horman
2025-03-24 19:38   ` Jakub Kicinski
2025-03-24 19:44     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250320183858.GJ892515@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.