From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH v2 net-next 2/2] tcp/dccp: remove icsk->icsk_ack.timeout
Date: Mon, 24 Mar 2025 12:38:41 -0700 [thread overview]
Message-ID: <20250324123841.58ece0e8@kernel.org> (raw)
In-Reply-To: <20250318154359.778438-3-edumazet@google.com>
On Tue, 18 Mar 2025 15:43:59 +0000 Eric Dumazet wrote:
> diff --git a/include/net/inet_connection_sock.h b/include/net/inet_connection_sock.h
> index 018118da0ce15c5ba5e3b7fcc1b36425794ec9a1..597f2b98dcf565a8512e815d9eae2b521bac7807 100644
> --- a/include/net/inet_connection_sock.h
> +++ b/include/net/inet_connection_sock.h
> @@ -117,7 +117,6 @@ struct inet_connection_sock {
> lrcv_flowlabel:20, /* last received ipv6 flowlabel */
> dst_quick_ack:1, /* cache dst RTAX_QUICKACK */
> unused:3;
> - unsigned long timeout; /* Currently scheduled timeout */
> __u32 lrcvtime; /* timestamp of last received data packet */
> __u16 last_seg_size; /* Size of last incoming segment */
> __u16 rcv_mss; /* MSS used for delayed ACK decisions */
I get the same errors as Simon, something ate the leading spaces
in the patch.
--
pw-bot: cr
next prev parent reply other threads:[~2025-03-24 19:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 15:43 [PATCH v2 net-next 0/2] tcp/dccp: remove 16 bytes from icsk Eric Dumazet
2025-03-18 15:43 ` [PATCH v2 net-next 1/2] tcp/dccp: remove icsk->icsk_timeout Eric Dumazet
2025-03-18 15:43 ` [PATCH v2 net-next 2/2] tcp/dccp: remove icsk->icsk_ack.timeout Eric Dumazet
2025-03-20 18:38 ` Simon Horman
2025-03-20 19:00 ` Eric Dumazet
2025-03-20 20:10 ` Simon Horman
2025-03-24 19:38 ` Jakub Kicinski [this message]
2025-03-24 19:44 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324123841.58ece0e8@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuniyu@amazon.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.