[soc:soc/drivers 20/24] ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!

[soc:soc/drivers 20/24] ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!

[kernel test robot]

Hi Marek,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git soc/drivers
head:   ba8755ab541fc629948233125db870d4dbf00a75
commit: ee7f8ed72990f28657b5bf598e695fcf4633f4ed [20/24] platform: cznic: turris-omnia-mcu: Refactor requesting MCU interrupt
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250321/202503211029.DnQpqsJs-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250321/202503211029.DnQpqsJs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503211029.DnQpqsJs-lkp@intel.com/

All errors (new ones prefixed by >>, old ones prefixed by <<):

ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
ERROR: modpost: "devm_of_clk_add_hw_provider" [drivers/media/i2c/tc358746.ko] undefined!
ERROR: modpost: "devm_clk_hw_register" [drivers/media/i2c/tc358746.ko] undefined!
ERROR: modpost: "of_clk_hw_simple_get" [drivers/media/i2c/tc358746.ko] undefined!
>> ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [soc:soc/drivers 20/24] ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!

[Arnd Bergmann]

On Fri, Mar 21, 2025, at 03:41, kernel test robot wrote:
> Hi Marek,
>
> First bad commit (maybe != root cause):
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git 
> soc/drivers
> head:   ba8755ab541fc629948233125db870d4dbf00a75
> commit: ee7f8ed72990f28657b5bf598e695fcf4633f4ed [20/24] platform: 
> cznic: turris-omnia-mcu: Refactor requesting MCU interrupt
> config: sh-allmodconfig 
> (https://download.01.org/0day-ci/archive/20250321/202503211029.DnQpqsJs-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): 
> (https://download.01.org/0day-ci/archive/20250321/202503211029.DnQpqsJs-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new 
> version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: 
> https://lore.kernel.org/oe-kbuild-all/202503211029.DnQpqsJs-lkp@intel.com/
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
> ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
> ERROR: modpost: "devm_of_clk_add_hw_provider" 
> [drivers/media/i2c/tc358746.ko] undefined!
> ERROR: modpost: "devm_clk_hw_register" [drivers/media/i2c/tc358746.ko] 
> undefined!
> ERROR: modpost: "of_clk_hw_simple_get" [drivers/media/i2c/tc358746.ko] 
> undefined!
>>> ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!

This comes from __bf_shf(spec) in omnia_mcu_request_irq().

As far as I can tell, this is not your problem but in the
SH architecture missing one of the libgcc functions that are
called by gcc.

Since this is only for compile-testing sh allmodconfig, and
that is already broken because of other bugs, I'm not going
to care either.

Adding the linux-sh list to Cc, it would be nice to get a clean
build again. All four problems should be trivial to address,
and some of these have been broken for many years.

      Arnd

Re: [soc:soc/drivers 20/24] ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!

[Geert Uytterhoeven]

Hi Arnd,

On Fri, 21 Mar 2025 at 09:41, Arnd Bergmann <arnd@arndb.de> wrote:
> On Fri, Mar 21, 2025, at 03:41, kernel test robot wrote:
> > First bad commit (maybe != root cause):
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git
> > soc/drivers
> > head:   ba8755ab541fc629948233125db870d4dbf00a75
> > commit: ee7f8ed72990f28657b5bf598e695fcf4633f4ed [20/24] platform:
> > cznic: turris-omnia-mcu: Refactor requesting MCU interrupt
> > config: sh-allmodconfig
> > (https://download.01.org/0day-ci/archive/20250321/202503211029.DnQpqsJs-lkp@intel.com/config)
> > compiler: sh4-linux-gcc (GCC) 14.2.0
> > reproduce (this is a W=1 build):
> > (https://download.01.org/0day-ci/archive/20250321/202503211029.DnQpqsJs-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new
> > version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes:
> > https://lore.kernel.org/oe-kbuild-all/202503211029.DnQpqsJs-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> >
> > ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!

Bug in driver (must not use __delay() directly).

> > ERROR: modpost: "devm_of_clk_add_hw_provider"
> > [drivers/media/i2c/tc358746.ko] undefined!
> > ERROR: modpost: "devm_clk_hw_register" [drivers/media/i2c/tc358746.ko]
> > undefined!
> > ERROR: modpost: "of_clk_hw_simple_get" [drivers/media/i2c/tc358746.ko]
> > undefined!

Missing dependencies for driver.

> >>> ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!
>
> This comes from __bf_shf(spec) in omnia_mcu_request_irq().
>
> As far as I can tell, this is not your problem but in the
> SH architecture missing one of the libgcc functions that are
> called by gcc.
>
> Since this is only for compile-testing sh allmodconfig, and
> that is already broken because of other bugs, I'm not going
> to care either.
>
> Adding the linux-sh list to Cc, it would be nice to get a clean
> build again. All four problems should be trivial to address,
> and some of these have been broken for many years.

So one SH-specific issue to fix...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [soc:soc/drivers 20/24] ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!

[Arnd Bergmann]

On Fri, Mar 21, 2025, at 10:36, Geert Uytterhoeven wrote:
>> >
>> > ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
>
> Bug in driver (must not use __delay() directly).
>
>> > ERROR: modpost: "devm_of_clk_add_hw_provider"
>> > [drivers/media/i2c/tc358746.ko] undefined!
>> > ERROR: modpost: "devm_clk_hw_register" [drivers/media/i2c/tc358746.ko]
>> > undefined!
>> > ERROR: modpost: "of_clk_hw_simple_get" [drivers/media/i2c/tc358746.ko]
>> > undefined!
>
> Missing dependencies for driver.

Agreed, but both of these only break the build on sh because
the architecture code is different from the others. It's obviously
best to fix these in the drivers, I just wouldn't expect the
driver maintainers to care unless someone sends them a patch/

>> >>> ERROR: modpost: "__ffsdi2" [drivers/platform/cznic/turris-omnia-mcu.ko] undefined!
>>
>> This comes from __bf_shf(spec) in omnia_mcu_request_irq().
>>
>> As far as I can tell, this is not your problem but in the
>> SH architecture missing one of the libgcc functions that are
>> called by gcc.
>>
>> Since this is only for compile-testing sh allmodconfig, and
>> that is already broken because of other bugs, I'm not going
>> to care either.
>>
>> Adding the linux-sh list to Cc, it would be nice to get a clean
>> build again. All four problems should be trivial to address,
>> and some of these have been broken for many years.
>
> So one SH-specific issue to fix...

There is also the missing clone3 syscall that has been
causing a warning for many years.

      Arnd