* [paulmckrcu:dev 42/42] include/linux/ratelimit.h:44:33: error: incompatible type for argument 1 of '_raw_spin_lock_irqsave'
@ 2025-03-21 5:37 kernel test robot
2025-03-21 17:35 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2025-03-21 5:37 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: oe-kbuild-all
tree: https://github.com/paulmckrcu/linux dev
head: eb8edf55ec5fb6db81f970bb09e9aefa17fc49f4
commit: eb8edf55ec5fb6db81f970bb09e9aefa17fc49f4 [42/42] squash! drm/amd/pm: Avoid open-coded use of ratelimit_state structure's ->missed field
config: arc-randconfig-002-20250321 (https://download.01.org/0day-ci/archive/20250321/202503211321.hs5OjZIa-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250321/202503211321.hs5OjZIa-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503211321.hs5OjZIa-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/sched.h:2186,
from arch/arc/kernel/asm-offsets.c:6:
include/linux/ratelimit.h: In function 'ratelimit_state_reset_interval':
>> include/linux/ratelimit.h:44:33: error: incompatible type for argument 1 of '_raw_spin_lock_irqsave'
44 | raw_spin_lock_irqsave(rs->lock, flags);
| ~~^~~~~~
| |
| raw_spinlock_t {aka struct raw_spinlock}
include/linux/spinlock.h:244:48: note: in definition of macro 'raw_spin_lock_irqsave'
244 | flags = _raw_spin_lock_irqsave(lock); \
| ^~~~
In file included from include/linux/spinlock.h:312,
from include/linux/sched.h:2186,
from arch/arc/kernel/asm-offsets.c:6:
include/linux/spinlock_api_smp.h:32:65: note: expected 'raw_spinlock_t *' {aka 'struct raw_spinlock *'} but argument is of type 'raw_spinlock_t' {aka 'struct raw_spinlock'}
32 | unsigned long __lockfunc _raw_spin_lock_irqsave(raw_spinlock_t *lock)
| ~~~~~~~~~~~~~~~~^~~~
make[3]: *** [scripts/Makefile.build:102: arch/arc/kernel/asm-offsets.s] Error 1 shuffle=16458656
make[3]: Target 'prepare' not remade because of errors.
make[2]: *** [Makefile:1264: prepare0] Error 2 shuffle=16458656
make[2]: Target 'prepare' not remade because of errors.
make[1]: *** [Makefile:251: __sub-make] Error 2 shuffle=16458656
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:251: __sub-make] Error 2 shuffle=16458656
make: Target 'prepare' not remade because of errors.
vim +/_raw_spin_lock_irqsave +44 include/linux/ratelimit.h
39
40 static inline void ratelimit_state_reset_interval(struct ratelimit_state *rs, int interval_init)
41 {
42 unsigned long flags;
43
> 44 raw_spin_lock_irqsave(rs->lock, flags);
45 rs->interval = interval_init;
46 rs->begin = 0;
47 rs->printed = 0;
48 ratelimit_state_reset_miss(rs);
49 raw_spin_unlock_irqrestore(&rs->lock, flags);
50 }
51
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [paulmckrcu:dev 42/42] include/linux/ratelimit.h:44:33: error: incompatible type for argument 1 of '_raw_spin_lock_irqsave'
2025-03-21 5:37 [paulmckrcu:dev 42/42] include/linux/ratelimit.h:44:33: error: incompatible type for argument 1 of '_raw_spin_lock_irqsave' kernel test robot
@ 2025-03-21 17:35 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2025-03-21 17:35 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all
On Fri, Mar 21, 2025 at 01:37:40PM +0800, kernel test robot wrote:
> tree: https://github.com/paulmckrcu/linux dev
> head: eb8edf55ec5fb6db81f970bb09e9aefa17fc49f4
> commit: eb8edf55ec5fb6db81f970bb09e9aefa17fc49f4 [42/42] squash! drm/amd/pm: Avoid open-coded use of ratelimit_state structure's ->missed field
> config: arc-randconfig-002-20250321 (https://download.01.org/0day-ci/archive/20250321/202503211321.hs5OjZIa-lkp@intel.com/config)
> compiler: arc-linux-gcc (GCC) 11.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250321/202503211321.hs5OjZIa-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202503211321.hs5OjZIa-lkp@intel.com/
Good catch, fixing with attribution, and thank you for your testing efforts!
Thanx, Paul
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/sched.h:2186,
> from arch/arc/kernel/asm-offsets.c:6:
> include/linux/ratelimit.h: In function 'ratelimit_state_reset_interval':
> >> include/linux/ratelimit.h:44:33: error: incompatible type for argument 1 of '_raw_spin_lock_irqsave'
> 44 | raw_spin_lock_irqsave(rs->lock, flags);
> | ~~^~~~~~
> | |
> | raw_spinlock_t {aka struct raw_spinlock}
> include/linux/spinlock.h:244:48: note: in definition of macro 'raw_spin_lock_irqsave'
> 244 | flags = _raw_spin_lock_irqsave(lock); \
> | ^~~~
> In file included from include/linux/spinlock.h:312,
> from include/linux/sched.h:2186,
> from arch/arc/kernel/asm-offsets.c:6:
> include/linux/spinlock_api_smp.h:32:65: note: expected 'raw_spinlock_t *' {aka 'struct raw_spinlock *'} but argument is of type 'raw_spinlock_t' {aka 'struct raw_spinlock'}
> 32 | unsigned long __lockfunc _raw_spin_lock_irqsave(raw_spinlock_t *lock)
> | ~~~~~~~~~~~~~~~~^~~~
> make[3]: *** [scripts/Makefile.build:102: arch/arc/kernel/asm-offsets.s] Error 1 shuffle=16458656
> make[3]: Target 'prepare' not remade because of errors.
> make[2]: *** [Makefile:1264: prepare0] Error 2 shuffle=16458656
> make[2]: Target 'prepare' not remade because of errors.
> make[1]: *** [Makefile:251: __sub-make] Error 2 shuffle=16458656
> make[1]: Target 'prepare' not remade because of errors.
> make: *** [Makefile:251: __sub-make] Error 2 shuffle=16458656
> make: Target 'prepare' not remade because of errors.
>
>
> vim +/_raw_spin_lock_irqsave +44 include/linux/ratelimit.h
>
> 39
> 40 static inline void ratelimit_state_reset_interval(struct ratelimit_state *rs, int interval_init)
> 41 {
> 42 unsigned long flags;
> 43
> > 44 raw_spin_lock_irqsave(rs->lock, flags);
> 45 rs->interval = interval_init;
> 46 rs->begin = 0;
> 47 rs->printed = 0;
> 48 ratelimit_state_reset_miss(rs);
> 49 raw_spin_unlock_irqrestore(&rs->lock, flags);
> 50 }
> 51
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-21 17:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-21 5:37 [paulmckrcu:dev 42/42] include/linux/ratelimit.h:44:33: error: incompatible type for argument 1 of '_raw_spin_lock_irqsave' kernel test robot
2025-03-21 17:35 ` Paul E. McKenney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.