* [PATCH] net/mlx5: DR, remove redundant object_range assignment
@ 2025-03-24 19:41 Qasim Ijaz
2025-03-24 20:19 ` Yevgeny Kliteynik
2025-03-26 6:13 ` Tariq Toukan
0 siblings, 2 replies; 3+ messages in thread
From: Qasim Ijaz @ 2025-03-24 19:41 UTC (permalink / raw)
To: saeedm, leon, tariqt, andrew+netdev, davem, edumazet, kuba,
pabeni, kliteyn
Cc: netdev, linux-rdma, linux-kernel
The initial assignment of object_range from
pool->dmn->info.caps.log_header_modify_argument_granularity is
redundant because it is immediately overwritten by the max_t() call.
Remove the unnecessary assignment.
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
---
drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
index 01ed6442095d..c2218dc556c7 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
@@ -39,9 +39,6 @@ static int dr_arg_pool_alloc_objs(struct dr_arg_pool *pool)
INIT_LIST_HEAD(&cur_list);
- object_range =
- pool->dmn->info.caps.log_header_modify_argument_granularity;
-
object_range =
max_t(u32, pool->dmn->info.caps.log_header_modify_argument_granularity,
DR_ICM_MODIFY_HDR_GRANULARITY_4K);
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: DR, remove redundant object_range assignment
2025-03-24 19:41 [PATCH] net/mlx5: DR, remove redundant object_range assignment Qasim Ijaz
@ 2025-03-24 20:19 ` Yevgeny Kliteynik
2025-03-26 6:13 ` Tariq Toukan
1 sibling, 0 replies; 3+ messages in thread
From: Yevgeny Kliteynik @ 2025-03-24 20:19 UTC (permalink / raw)
To: Qasim Ijaz, saeedm, leon, tariqt, andrew+netdev, davem, edumazet,
kuba, pabeni
Cc: netdev, linux-rdma, linux-kernel
On 24-Mar-25 21:41, Qasim Ijaz wrote:
> The initial assignment of object_range from
> pool->dmn->info.caps.log_header_modify_argument_granularity is
> redundant because it is immediately overwritten by the max_t() call.
>
> Remove the unnecessary assignment.
>
> Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> index 01ed6442095d..c2218dc556c7 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> @@ -39,9 +39,6 @@ static int dr_arg_pool_alloc_objs(struct dr_arg_pool *pool)
>
> INIT_LIST_HEAD(&cur_list);
>
> - object_range =
> - pool->dmn->info.caps.log_header_modify_argument_granularity;
> -
> object_range =
> max_t(u32, pool->dmn->info.caps.log_header_modify_argument_granularity,
> DR_ICM_MODIFY_HDR_GRANULARITY_4K);
Reviewed-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: DR, remove redundant object_range assignment
2025-03-24 19:41 [PATCH] net/mlx5: DR, remove redundant object_range assignment Qasim Ijaz
2025-03-24 20:19 ` Yevgeny Kliteynik
@ 2025-03-26 6:13 ` Tariq Toukan
1 sibling, 0 replies; 3+ messages in thread
From: Tariq Toukan @ 2025-03-26 6:13 UTC (permalink / raw)
To: Qasim Ijaz, saeedm, leon, tariqt, andrew+netdev, davem, edumazet,
kuba, pabeni, kliteyn
Cc: netdev, linux-rdma, linux-kernel
On 24/03/2025 21:41, Qasim Ijaz wrote:
> The initial assignment of object_range from
> pool->dmn->info.caps.log_header_modify_argument_granularity is
> redundant because it is immediately overwritten by the max_t() call.
>
> Remove the unnecessary assignment.
>
> Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> index 01ed6442095d..c2218dc556c7 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> @@ -39,9 +39,6 @@ static int dr_arg_pool_alloc_objs(struct dr_arg_pool *pool)
>
> INIT_LIST_HEAD(&cur_list);
>
> - object_range =
> - pool->dmn->info.caps.log_header_modify_argument_granularity;
> -
> object_range =
> max_t(u32, pool->dmn->info.caps.log_header_modify_argument_granularity,
> DR_ICM_MODIFY_HDR_GRANULARITY_4K);
Acked-by: Tariq Toukan <tariqt@nvidia.com>
Thanks for your patch.
This is net-next material. Please specify target branch in future
submissions.
Regards,
Tariq
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-26 6:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-24 19:41 [PATCH] net/mlx5: DR, remove redundant object_range assignment Qasim Ijaz
2025-03-24 20:19 ` Yevgeny Kliteynik
2025-03-26 6:13 ` Tariq Toukan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.