From: Marc Zyngier <maz@kernel.org>
To: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
asahi@lists.linux.dev
Cc: "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Janne Grunau" <j@jannau.net>, "Hector Martin" <marcan@marcan.st>,
"Sven Peter" <sven@svenpeter.dev>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
stable@vger.kernel.org
Subject: [PATCH v2 08/13] PCI: apple: Set only available ports up
Date: Tue, 25 Mar 2025 10:26:05 +0000 [thread overview]
Message-ID: <20250325102610.2073863-9-maz@kernel.org> (raw)
In-Reply-To: <20250325102610.2073863-1-maz@kernel.org>
From: Janne Grunau <j@jannau.net>
Iterating over disabled ports results in of_irq_parse_raw() parsing
the wrong "interrupt-map" entries, as it takes the status of the node
into account.
Switching from for_each_child_of_node() to for_each_available_child_of_node()
solves this issue.
This became apparent after disabling unused PCIe ports in the Apple
Silicon device trees instead of deleting them.
Link: https://lore.kernel.org/asahi/20230214-apple_dts_pcie_disable_unused-v1-0-5ea0d3ddcde3@jannau.net/
Link: https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab08ce@linaro.org/
Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up")
Cc: stable@vger.kernel.org
Signed-off-by: Janne Grunau <j@jannau.net>
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
drivers/pci/controller/pcie-apple.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
index 6271533f1b042..23d9f62bd2ad4 100644
--- a/drivers/pci/controller/pcie-apple.c
+++ b/drivers/pci/controller/pcie-apple.c
@@ -747,7 +747,7 @@ static int apple_pcie_init(struct pci_config_window *cfg)
struct device_node *of_port;
int ret;
- for_each_child_of_node(dev->of_node, of_port) {
+ for_each_available_child_of_node(dev->of_node, of_port) {
ret = apple_pcie_setup_port(pcie, of_port);
if (ret) {
dev_err(dev, "Port %pOF setup fail: %d\n", of_port, ret);
--
2.39.2
next prev parent reply other threads:[~2025-03-25 10:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 10:25 [PATCH v2 00/13] PCI: apple: Add support for t6020 Marc Zyngier
2025-03-25 10:25 ` [PATCH v2 01/13] dt-bindings: pci: apple,pcie: Add t6020 compatible string Marc Zyngier
2025-03-25 10:50 ` Mark Kettenis
2025-03-25 11:02 ` Marc Zyngier
2025-03-25 15:41 ` Mark Kettenis
2025-03-25 16:48 ` Marc Zyngier
2025-03-26 19:51 ` Rob Herring
2025-03-25 10:25 ` [PATCH v2 02/13] PCI: host-generic: Extract an ecam bridge creation helper from pci_host_common_probe() Marc Zyngier
2025-03-25 10:26 ` [PATCH v2 03/13] PCI: ecam: Allow cfg->priv to be pre-populated from the root port device Marc Zyngier
2025-03-25 10:26 ` [PATCH v2 04/13] PCI: apple: Move over to standalone probing Marc Zyngier
2025-03-25 10:26 ` [PATCH v2 05/13] PCI: apple: Dynamically allocate RID-to_SID bitmap Marc Zyngier
2025-03-25 10:26 ` [PATCH v2 06/13] PCI: apple: Move away from INTMSK{SET,CLR} for INTx and private interrupts Marc Zyngier
2025-03-25 10:26 ` [PATCH v2 07/13] PCI: apple: Fix missing OF node reference in apple_pcie_setup_port Marc Zyngier
2025-03-25 10:26 ` Marc Zyngier [this message]
2025-03-25 13:25 ` [PATCH v2 08/13] PCI: apple: Set only available ports up Rob Herring
2025-03-25 10:26 ` [PATCH v2 09/13] PCI: apple: Move port PHY registers to their own reg items Marc Zyngier
2025-03-25 10:26 ` [PATCH v2 10/13] PCI: apple: Drop poll for CORE_RC_PHYIF_STAT_REFCLK Marc Zyngier
2025-03-25 10:26 ` [PATCH v2 11/13] PCI: apple: Use gpiod_set_value_cansleep in probe flow Marc Zyngier
2025-03-25 10:26 ` [PATCH v2 12/13] PCI: apple: Abstract register offsets via a SoC-specific structure Marc Zyngier
2025-03-25 10:26 ` [PATCH v2 13/13] PCI: apple: Add T602x PCIe support Marc Zyngier
2025-03-25 13:31 ` [PATCH v2 00/13] PCI: apple: Add support for t6020 Rob Herring
2025-03-25 14:50 ` Alyssa Rosenzweig
2025-03-31 11:28 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325102610.2073863-9-maz@kernel.org \
--to=maz@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marcan@marcan.st \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.