* [PATCH v2] staging: rtl8723bs: Rename variables v2
@ 2025-03-25 11:45 Erick Karanja
0 siblings, 0 replies; 3+ messages in thread
From: Erick Karanja @ 2025-03-25 11:45 UTC (permalink / raw)
To: gregkh, outreachy
Cc: philipp.g.hortmann, davidzalman.101, vivek6429.ts, viro,
linux-staging, linux-kernel, Erick Karanja
Rename the variable `supportRateNum` to `support_rate_num` and variable
`supportRate` to `support_rate` to adhere to Linux kernel coding
standards by using snake_case instead of CamelCase.
Fixes checkpatch.pl warning:
CHECK: Avoid CamelCase: <supportRateNum>
v2:
Fixes checkpatch.pl warning:
CHECK: Avoid CamelCase: <supportRate>
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 50022bb5911e..d46a04b9a05e 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -370,7 +370,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
void update_bmc_sta(struct adapter *padapter)
{
unsigned char network_type;
- int supportRateNum = 0;
+ int support_rate_num = 0;
unsigned int tx_ra_bitmap = 0;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
@@ -396,9 +396,9 @@ void update_bmc_sta(struct adapter *padapter)
/* psta->dot118021XPrivacy = _NO_PRIVACY_;//!!! remove it, because it has been set before this. */
/* prepare for add_RATid */
- supportRateNum = rtw_get_rateset_len((u8 *)&pcur_network->supported_rates);
+ support_rate_num = rtw_get_rateset_len((u8 *)&pcur_network->supported_rates);
network_type = rtw_check_network_type((u8 *)&pcur_network->supported_rates,
- supportRateNum,
+ support_rate_num,
pcur_network->configuration.ds_config
);
if (is_supported_tx_cck(network_type)) {
@@ -817,8 +817,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
u16 cap, ht_cap = false;
uint ie_len = 0;
int group_cipher, pairwise_cipher;
- u8 channel, network_type, supportRate[NDIS_802_11_LENGTH_RATES_EX];
- int supportRateNum = 0;
+ u8 channel, network_type, support_rate[NDIS_802_11_LENGTH_RATES_EX];
+ int support_rate_num = 0;
u8 OUI1[] = {0x00, 0x50, 0xf2, 0x01};
u8 WMM_PARA_IE[] = {0x00, 0x50, 0xf2, 0x02, 0x01, 0x01};
struct registry_priv *pregistrypriv = &padapter->registrypriv;
@@ -883,7 +883,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
pbss_network->configuration.ds_config = channel;
- memset(supportRate, 0, NDIS_802_11_LENGTH_RATES_EX);
+ memset(support_rate, 0, NDIS_802_11_LENGTH_RATES_EX);
/* get supported rates */
p = rtw_get_ie(
ie + _BEACON_IE_OFFSET_,
@@ -892,8 +892,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
(pbss_network->ie_length - _BEACON_IE_OFFSET_)
);
if (p) {
- memcpy(supportRate, p + 2, ie_len);
- supportRateNum = ie_len;
+ memcpy(support_rate, p + 2, ie_len);
+ support_rate_num = ie_len;
}
/* get ext_supported rates */
@@ -904,11 +904,12 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
pbss_network->ie_length - _BEACON_IE_OFFSET_
);
if (p) {
- memcpy(supportRate + supportRateNum, p + 2, ie_len);
- supportRateNum += ie_len;
+ memcpy(support_rate + support_rate_num, p + 2, ie_len);
+ support_rate_num += ie_len;
}
- network_type = rtw_check_network_type(supportRate, supportRateNum, channel);
+ network_type = rtw_check_network_type(support_rate, support_rate_num,
+ channel);
rtw_set_supported_rate(pbss_network->supported_rates, network_type);
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] staging: rtl8723bs: Rename variables v2
@ 2025-03-26 6:46 Erick Karanja
2025-03-26 7:06 ` Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Erick Karanja @ 2025-03-26 6:46 UTC (permalink / raw)
To: gregkh, outreachy
Cc: karanja99erick, philipp.g.hortmann, linux-staging, linux-kernel
Rename the variable `mediaStatus` to `media_status` and variable
`lpsVal` to `lps_val` to adhere to Linux kernel coding
standards by using snake_case instead of CamelCase.
changes in v2:
reverted double blank line changes committed earier ensuring
my patch contains uniform changes.
Fixes checkpatch.pl warning:
CHECK: Avoid CamelCase: <mediaStatus>
CHECK: Avoid CamelCase: <lpsVal>
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_btcoex.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
index d54095f50113..f4b19ef7b341 100644
--- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
+++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
@@ -8,14 +8,14 @@
#include <rtw_btcoex.h>
#include <hal_btcoex.h>
-void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 mediaStatus)
+void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
{
- if ((mediaStatus == RT_MEDIA_CONNECT)
+ if ((media_status == RT_MEDIA_CONNECT)
&& (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
}
- hal_btcoex_MediaStatusNotify(padapter, mediaStatus);
+ hal_btcoex_MediaStatusNotify(padapter, media_status);
}
void rtw_btcoex_HaltNotify(struct adapter *padapter)
@@ -52,14 +52,14 @@ void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable)
void rtw_btcoex_LPS_Enter(struct adapter *padapter)
{
struct pwrctrl_priv *pwrpriv;
- u8 lpsVal;
+ u8 lps_val;
pwrpriv = adapter_to_pwrctl(padapter);
pwrpriv->bpower_saving = true;
- lpsVal = hal_btcoex_LpsVal(padapter);
- rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, lpsVal, "BTCOEX");
+ lps_val = hal_btcoex_LpsVal(padapter);
+ rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, lps_val, "BTCOEX");
}
void rtw_btcoex_LPS_Leave(struct adapter *padapter)
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: Rename variables v2
2025-03-26 6:46 [PATCH v2] staging: rtl8723bs: Rename variables v2 Erick Karanja
@ 2025-03-26 7:06 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2025-03-26 7:06 UTC (permalink / raw)
To: Erick Karanja
Cc: gregkh, outreachy, philipp.g.hortmann, linux-staging,
linux-kernel
On Wed, 26 Mar 2025, Erick Karanja wrote:
> Rename the variable `mediaStatus` to `media_status` and variable
> `lpsVal` to `lps_val` to adhere to Linux kernel coding
> standards by using snake_case instead of CamelCase.
>
> changes in v2:
> reverted double blank line changes committed earier ensuring
> my patch contains uniform changes.
This v2 information belongsbelow the ---. It's not meaningful to people
who look at the gi log in the future, because they don't see the previous
version of the patch. The part below the --- isdiscarded when the patch
is applied.
julia
>
> Fixes checkpatch.pl warning:
> CHECK: Avoid CamelCase: <mediaStatus>
> CHECK: Avoid CamelCase: <lpsVal>
>
> Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_btcoex.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> index d54095f50113..f4b19ef7b341 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> @@ -8,14 +8,14 @@
> #include <rtw_btcoex.h>
> #include <hal_btcoex.h>
>
> -void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 mediaStatus)
> +void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
> {
> - if ((mediaStatus == RT_MEDIA_CONNECT)
> + if ((media_status == RT_MEDIA_CONNECT)
> && (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
> rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
> }
>
> - hal_btcoex_MediaStatusNotify(padapter, mediaStatus);
> + hal_btcoex_MediaStatusNotify(padapter, media_status);
> }
>
> void rtw_btcoex_HaltNotify(struct adapter *padapter)
> @@ -52,14 +52,14 @@ void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable)
> void rtw_btcoex_LPS_Enter(struct adapter *padapter)
> {
> struct pwrctrl_priv *pwrpriv;
> - u8 lpsVal;
> + u8 lps_val;
>
>
> pwrpriv = adapter_to_pwrctl(padapter);
>
> pwrpriv->bpower_saving = true;
> - lpsVal = hal_btcoex_LpsVal(padapter);
> - rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, lpsVal, "BTCOEX");
> + lps_val = hal_btcoex_LpsVal(padapter);
> + rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, lps_val, "BTCOEX");
> }
>
> void rtw_btcoex_LPS_Leave(struct adapter *padapter)
> --
> 2.43.0
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-26 7:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-26 6:46 [PATCH v2] staging: rtl8723bs: Rename variables v2 Erick Karanja
2025-03-26 7:06 ` Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2025-03-25 11:45 Erick Karanja
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.