From: Anup Patel <apatel@ventanamicro.com>
To: Will Deacon <will@kernel.org>,
julien.thierry.kdev@gmail.com, maz@kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Atish Patra <atishp@atishpatra.org>,
Andrew Jones <ajones@ventanamicro.com>,
Anup Patel <anup@brainfault.org>,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
Anup Patel <apatel@ventanamicro.com>
Subject: [kvmtool PATCH 10/10] riscv: Allow including extensions in the min CPU type using command-line
Date: Wed, 26 Mar 2025 12:26:44 +0530 [thread overview]
Message-ID: <20250326065644.73765-11-apatel@ventanamicro.com> (raw)
In-Reply-To: <20250326065644.73765-1-apatel@ventanamicro.com>
It is useful to allow including extensions in the min CPU type on need
basis via command-line. To achieve this, parse extension names as comma
separated values appended to the "min" CPU type using command-line.
For example, to include Sstc and Ssaia in the min CPU type use
"--cpu-type min,sstc,ssaia" command-line option.
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
riscv/fdt.c | 41 +++++++++++++++++++++++++++++++++++++++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/riscv/fdt.c b/riscv/fdt.c
index 4c018c8..9cefd2f 100644
--- a/riscv/fdt.c
+++ b/riscv/fdt.c
@@ -108,6 +108,20 @@ static bool __isa_ext_warn_disable_failure(struct kvm *kvm, struct isa_ext_info
return true;
}
+static void __min_cpu_include(const char *ext, size_t ext_len)
+{
+ struct isa_ext_info *info;
+ unsigned long i;
+
+ for (i = 0; i < ARRAY_SIZE(isa_info_arr); i++) {
+ info = &isa_info_arr[i];
+ if (strlen(info->name) != ext_len)
+ continue;
+ if (!strncmp(ext, info->name, ext_len))
+ info->min_cpu_included = true;
+ }
+}
+
bool riscv__isa_extension_disabled(struct kvm *kvm, unsigned long isa_ext_id)
{
struct isa_ext_info *info = NULL;
@@ -128,16 +142,39 @@ bool riscv__isa_extension_disabled(struct kvm *kvm, unsigned long isa_ext_id)
int riscv__cpu_type_parser(const struct option *opt, const char *arg, int unset)
{
struct kvm *kvm = opt->ptr;
+ const char *str, *nstr;
+ int len;
- if ((strncmp(arg, "min", 3) && strncmp(arg, "max", 3)) || strlen(arg) != 3)
+ if ((strncmp(arg, "min", 3) || strlen(arg) < 3) &&
+ (strncmp(arg, "max", 3) || strlen(arg) != 3))
die("Invalid CPU type %s\n", arg);
if (!strncmp(arg, "max", 3))
kvm->cfg.arch.cpu_type = "max";
- if (!strncmp(arg, "min", 3))
+ if (!strncmp(arg, "min", 3)) {
kvm->cfg.arch.cpu_type = "min";
+ str = arg;
+ str += 3;
+ while (*str) {
+ if (*str == ',') {
+ str++;
+ continue;
+ }
+
+ nstr = strchr(str, ',');
+ if (!nstr)
+ nstr = str + strlen(str);
+
+ len = nstr - str;
+ if (len) {
+ __min_cpu_include(str, len);
+ str += len;
+ }
+ }
+ }
+
return 0;
}
--
2.43.0
--
kvm-riscv mailing list
kvm-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Anup Patel <apatel@ventanamicro.com>
To: Will Deacon <will@kernel.org>,
julien.thierry.kdev@gmail.com, maz@kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Atish Patra <atishp@atishpatra.org>,
Andrew Jones <ajones@ventanamicro.com>,
Anup Patel <anup@brainfault.org>,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
Anup Patel <apatel@ventanamicro.com>
Subject: [kvmtool PATCH 10/10] riscv: Allow including extensions in the min CPU type using command-line
Date: Wed, 26 Mar 2025 12:26:44 +0530 [thread overview]
Message-ID: <20250326065644.73765-11-apatel@ventanamicro.com> (raw)
In-Reply-To: <20250326065644.73765-1-apatel@ventanamicro.com>
It is useful to allow including extensions in the min CPU type on need
basis via command-line. To achieve this, parse extension names as comma
separated values appended to the "min" CPU type using command-line.
For example, to include Sstc and Ssaia in the min CPU type use
"--cpu-type min,sstc,ssaia" command-line option.
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
riscv/fdt.c | 41 +++++++++++++++++++++++++++++++++++++++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/riscv/fdt.c b/riscv/fdt.c
index 4c018c8..9cefd2f 100644
--- a/riscv/fdt.c
+++ b/riscv/fdt.c
@@ -108,6 +108,20 @@ static bool __isa_ext_warn_disable_failure(struct kvm *kvm, struct isa_ext_info
return true;
}
+static void __min_cpu_include(const char *ext, size_t ext_len)
+{
+ struct isa_ext_info *info;
+ unsigned long i;
+
+ for (i = 0; i < ARRAY_SIZE(isa_info_arr); i++) {
+ info = &isa_info_arr[i];
+ if (strlen(info->name) != ext_len)
+ continue;
+ if (!strncmp(ext, info->name, ext_len))
+ info->min_cpu_included = true;
+ }
+}
+
bool riscv__isa_extension_disabled(struct kvm *kvm, unsigned long isa_ext_id)
{
struct isa_ext_info *info = NULL;
@@ -128,16 +142,39 @@ bool riscv__isa_extension_disabled(struct kvm *kvm, unsigned long isa_ext_id)
int riscv__cpu_type_parser(const struct option *opt, const char *arg, int unset)
{
struct kvm *kvm = opt->ptr;
+ const char *str, *nstr;
+ int len;
- if ((strncmp(arg, "min", 3) && strncmp(arg, "max", 3)) || strlen(arg) != 3)
+ if ((strncmp(arg, "min", 3) || strlen(arg) < 3) &&
+ (strncmp(arg, "max", 3) || strlen(arg) != 3))
die("Invalid CPU type %s\n", arg);
if (!strncmp(arg, "max", 3))
kvm->cfg.arch.cpu_type = "max";
- if (!strncmp(arg, "min", 3))
+ if (!strncmp(arg, "min", 3)) {
kvm->cfg.arch.cpu_type = "min";
+ str = arg;
+ str += 3;
+ while (*str) {
+ if (*str == ',') {
+ str++;
+ continue;
+ }
+
+ nstr = strchr(str, ',');
+ if (!nstr)
+ nstr = str + strlen(str);
+
+ len = nstr - str;
+ if (len) {
+ __min_cpu_include(str, len);
+ str += len;
+ }
+ }
+ }
+
return 0;
}
--
2.43.0
next prev parent reply other threads:[~2025-03-26 6:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 6:56 [kvmtool PATCH 00/10] Add SBI system suspend and cpu-type option Anup Patel
2025-03-26 6:56 ` Anup Patel
2025-03-26 6:56 ` [kvmtool PATCH 01/10] Sync-up headers with Linux-6.14 kernel Anup Patel
2025-03-26 6:56 ` Anup Patel
2025-03-26 6:56 ` [kvmtool PATCH 02/10] riscv: Add Svvptc extension support Anup Patel
2025-03-26 6:56 ` Anup Patel
2025-04-12 13:46 ` Andrew Jones
2025-04-12 13:46 ` Andrew Jones
2025-03-26 6:56 ` [kvmtool PATCH 03/10] riscv: Add Zabha " Anup Patel
2025-03-26 6:56 ` Anup Patel
2025-04-12 13:46 ` Andrew Jones
2025-04-12 13:46 ` Andrew Jones
2025-03-26 6:56 ` [kvmtool PATCH 04/10] riscv: Add Ziccrse " Anup Patel
2025-03-26 6:56 ` Anup Patel
2025-04-12 13:46 ` Andrew Jones
2025-04-12 13:46 ` Andrew Jones
2025-03-26 6:56 ` [kvmtool PATCH 05/10] riscv: Add SBI system suspend support Anup Patel
2025-03-26 6:56 ` Anup Patel
2025-03-26 6:56 ` [kvmtool PATCH 06/10] riscv: Make system suspend time configurable Anup Patel
2025-03-26 6:56 ` Anup Patel
2025-03-26 6:56 ` [kvmtool PATCH 07/10] riscv: Fix no params with nodefault segfault Anup Patel
2025-03-26 6:56 ` Anup Patel
2025-03-26 6:56 ` [kvmtool PATCH 08/10] riscv: Include single-letter extensions in isa_info_arr[] Anup Patel
2025-03-26 6:56 ` Anup Patel
2025-04-12 12:36 ` Andrew Jones
2025-04-12 12:36 ` Andrew Jones
2025-04-24 5:59 ` Anup Patel
2025-04-24 5:59 ` Anup Patel
2025-03-26 6:56 ` [kvmtool PATCH 09/10] riscv: Add cpu-type command-line option Anup Patel
2025-03-26 6:56 ` Anup Patel
2025-04-12 13:15 ` Andrew Jones
2025-04-12 13:15 ` Andrew Jones
2025-04-24 12:57 ` Anup Patel
2025-04-24 12:57 ` Anup Patel
2025-04-24 13:29 ` Andrew Jones
2025-04-24 13:29 ` Andrew Jones
2025-04-24 13:46 ` Anup Patel
2025-04-24 13:46 ` Anup Patel
2025-03-26 6:56 ` Anup Patel [this message]
2025-03-26 6:56 ` [kvmtool PATCH 10/10] riscv: Allow including extensions in the min CPU type using command-line Anup Patel
2025-04-12 13:45 ` Andrew Jones
2025-04-12 13:45 ` Andrew Jones
2025-04-24 13:32 ` Anup Patel
2025-04-24 13:32 ` Anup Patel
2025-04-24 14:07 ` Andrew Jones
2025-04-24 14:07 ` Andrew Jones
2025-04-24 15:17 ` Anup Patel
2025-04-24 15:17 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250326065644.73765-11-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=ajones@ventanamicro.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.