From: Nathan Chancellor <nathan@kernel.org>
To: Andy Shevchenko <andy@kernel.org>
Cc: Kees Cook <kees@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
llvm@lists.linux.dev, linux-efi@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] wcslen() prototype in string.h
Date: Wed, 26 Mar 2025 08:37:56 -0700 [thread overview]
Message-ID: <20250326153756.GB1105284@ax162> (raw)
In-Reply-To: <Z-PCCCAPS4uvL3jZ@smile.fi.intel.com>
On Wed, Mar 26, 2025 at 10:59:52AM +0200, Andy Shevchenko wrote:
> On Tue, Mar 25, 2025 at 05:33:03PM -0700, Nathan Chancellor wrote:
> > #define _LINUX_NLS_H
> >
> > #include <linux/init.h>
>
> As I just replied to your previous mail, consider fixing this list as well
> by adding module.h and types.h.
>
> ...
>
> Overall, can you browse the Ingo's series [1] for the stuff related to this,
> if any?
>
> I would avoid doing double efforts or different approaches if we already have
> something ready.
In Ingo's last fast-headers tree [1], nls.h only has export.h and init.h
included, so it does not look like anything around this was changed from
what I can tell.
types.h is going to be included via the new nls_types.h and while it
does definitely look like module.h should be included, I do not really
have the time and build capacity at the moment to incorporate testing
that change into this series. I will stick with these two changes for
now then I, you, or someone else can revisit cleaning up nls.h later.
[1]: https://web.git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git/tree/include/linux/nls.h?h=sched/headers
Cheers,
Nathan
next prev parent reply other threads:[~2025-03-26 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 15:45 [PATCH 0/2] string.c: Add wcslen() Nathan Chancellor
2025-03-25 15:45 ` [PATCH 1/2] lib/string.c: " Nathan Chancellor
2025-03-25 15:45 ` [PATCH RFC 2/2] wcslen() prototype in string.h Nathan Chancellor
2025-03-25 16:17 ` Andy Shevchenko
2025-03-25 16:58 ` Nathan Chancellor
2025-03-25 17:05 ` Andy Shevchenko
2025-03-25 21:45 ` Nathan Chancellor
2025-03-26 0:33 ` Nathan Chancellor
2025-03-26 8:59 ` Andy Shevchenko
2025-03-26 15:37 ` Nathan Chancellor [this message]
2025-03-26 15:43 ` Andy Shevchenko
2025-03-26 8:52 ` Andy Shevchenko
2025-03-25 23:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250326153756.GB1105284@ax162 \
--to=nathan@kernel.org \
--cc=andy@kernel.org \
--cc=ardb@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nick.desaulniers+lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.