Re: [v2 2/3] i3c: master: Add Qualcomm I3C controller driver

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
	linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [v2 2/3] i3c: master: Add Qualcomm I3C controller driver
Date: Sat, 29 Mar 2025 11:48:12 +0100	[thread overview]
Message-ID: <20250329104812225f9ee5@mail.local> (raw)
In-Reply-To: <a96511dc-5ba1-4302-acb0-f3b49bf8990c@quicinc.com>

On 29/03/2025 14:38:14+0530, Mukesh Kumar Savaliya wrote:
> Hi Markus,
> 
> On 3/29/2025 12:34 AM, Markus Elfring wrote:
> > > > Under which circumstances would you become interested to apply a statement
> > > > like “guard(spinlock_irqsave)(&gi3c->irq_lock);”?
> > > Didn't get, hence a question.  Do you suggest to use DEFINE_LOCK_GUARD_1 instead of existing method ?
> > I propose to pick further opportunities up for benefits from scope-based resource management.
> > 
> Sorry, still not clear to me what should i add/change ? please share me some
> example.

Don't change anything, Markus is wasting your time.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com