All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com>,
	linux@roeck-us.net, Thomas Fossati <thomas.fossati@linaro.org>,
	linux-watchdog@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>,
	wim@linux-watchdog.org, S32@nxp.com,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer
Date: Sat, 29 Mar 2025 12:12:15 -0500	[thread overview]
Message-ID: <20250329171215.GA2298924-robh@kernel.org> (raw)
In-Reply-To: <174321222207.2172829.15350189767926637719.robh@kernel.org>

On Fri, Mar 28, 2025 at 08:37:03PM -0500, Rob Herring (Arm) wrote:
> 
> On Fri, 28 Mar 2025 16:15:13 +0100, Daniel Lezcano wrote:
> > Describe the Software Watchdog Timer available on the S32G platforms.
> > 
> > Cc: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com>
> > Cc: Thomas Fossati <thomas.fossati@linaro.org>
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> > ---
> >  .../bindings/watchdog/nxp,s32g-wdt.yaml       | 46 +++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/watchdog/nxp,s32g-wdt.yaml
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/watchdog/nxp,s32g-wdt.example.dts:18.29-23.11: Warning (unit_address_format): /example-0/watchdog@0x40100000: unit name should not have leading "0x"
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/watchdog/nxp,s32g-wdt.example.dtb: watchdog@0x40100000: 'timeout-sec' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/watchdog/nxp,s32g-wdt.yaml#

You need unevaluatedProperties instead of additionalProperties.

Rob

  reply	other threads:[~2025-03-29 17:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 15:15 [PATCH 1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer Daniel Lezcano
2025-03-28 15:15 ` [PATCH 2/2] watchdog: Add the Software Watchdog Timer for the NXP S32 platform Daniel Lezcano
2025-03-28 18:10   ` Guenter Roeck
2025-03-28 19:42     ` Daniel Lezcano
2025-03-28 19:56       ` Guenter Roeck
2025-03-28 20:58         ` Daniel Lezcano
2025-03-29  4:55   ` Krzysztof Kozlowski
2025-03-31  8:28     ` Daniel Lezcano
2025-03-29  1:37 ` [PATCH 1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer Rob Herring (Arm)
2025-03-29 17:12   ` Rob Herring [this message]
2025-03-31  8:18     ` Daniel Lezcano
2025-03-29  5:04 ` Krzysztof Kozlowski
2025-03-31  7:57   ` Daniel Lezcano
2025-03-31 11:42     ` Krzysztof Kozlowski
2025-04-01  8:46       ` Daniel Lezcano
2025-04-01 15:16         ` Krzysztof Kozlowski
2025-03-31 10:55 ` Ghennadi Procopciuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250329171215.GA2298924-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=S32@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ghennadi.procopciuc@nxp.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=thomas.fossati@linaro.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.