From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, wim@linux-watchdog.org
Cc: linux@roeck-us.net, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org, S32@nxp.com,
Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com>,
Thomas Fossati <thomas.fossati@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer
Date: Sat, 29 Mar 2025 06:04:59 +0100 [thread overview]
Message-ID: <c433c28d-c88d-4647-b472-7bc81b332d8c@kernel.org> (raw)
In-Reply-To: <20250328151516.2219971-1-daniel.lezcano@linaro.org>
On 28/03/2025 16:15, Daniel Lezcano wrote:
> +description:
> + The System Timer Module supports commonly required system and
> + application software timing functions. STM includes a 32-bit
> + count-up timer and four 32-bit compare channels with a separate
> + interrupt source for each channel. The timer is driven by the STM
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - nxp,s32g-wdt
This wasn't tested, so limited review - this also has wrong compatible,
There is no such soc as s32g in the kernel. If that's a new soc, come
with proper top-level bindings and some explanation, because I am sure
previously we talked with NXP that this is not s32g but something else.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-29 5:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 15:15 [PATCH 1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer Daniel Lezcano
2025-03-28 15:15 ` [PATCH 2/2] watchdog: Add the Software Watchdog Timer for the NXP S32 platform Daniel Lezcano
2025-03-28 18:10 ` Guenter Roeck
2025-03-28 19:42 ` Daniel Lezcano
2025-03-28 19:56 ` Guenter Roeck
2025-03-28 20:58 ` Daniel Lezcano
2025-03-29 4:55 ` Krzysztof Kozlowski
2025-03-31 8:28 ` Daniel Lezcano
2025-03-29 1:37 ` [PATCH 1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer Rob Herring (Arm)
2025-03-29 17:12 ` Rob Herring
2025-03-31 8:18 ` Daniel Lezcano
2025-03-29 5:04 ` Krzysztof Kozlowski [this message]
2025-03-31 7:57 ` Daniel Lezcano
2025-03-31 11:42 ` Krzysztof Kozlowski
2025-04-01 8:46 ` Daniel Lezcano
2025-04-01 15:16 ` Krzysztof Kozlowski
2025-03-31 10:55 ` Ghennadi Procopciuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c433c28d-c88d-4647-b472-7bc81b332d8c@kernel.org \
--to=krzk@kernel.org \
--cc=S32@nxp.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ghennadi.procopciuc@nxp.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=thomas.fossati@linaro.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.