All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryo Takakura <ryotkkr98@gmail.com>
To: alex@ghiti.fr, aou@eecs.berkeley.edu, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, john.ogness@linutronix.de,
	palmer@dabbelt.com, paul.walmsley@sifive.com, pmladek@suse.com,
	samuel.holland@sifive.com, bigeasy@linutronix.de,
	conor.dooley@microchip.com, u.kleine-koenig@baylibre.com
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-serial@vger.kernel.org, Ryo Takakura <ryotkkr98@gmail.com>
Subject: [PATCH v2 0/2] serial: sifive: Convert sifive console to nbcon
Date: Sun, 30 Mar 2025 09:30:58 +0900	[thread overview]
Message-ID: <20250330003058.386447-1-ryotkkr98@gmail.com> (raw)

Hi!

This series convert sifive console to nbcon.

The first patch fixes the issue which was pointed out by John [0] 
that the driver has been accessing SIFIVE_SERIAL_IE_OFFS register 
on its ->startup() and ->shutdown() without port lock synchronization 
against ->write().

The fix on the first patch still applies to the second patch which 
converts the console to nbcon as ->write_thread() holds port lock
and ->write_atomic() checks for the console ownership.

Sincerely,
Ryo Takakura

[0] https://lore.kernel.org/lkml/84sen2fo4b.fsf@jogness.linutronix.de/

---

Changes since v1:
[1] https://lore.kernel.org/lkml/20250323060603.388621-1-ryotkkr98@gmail.com/

- Thank you John for the feedback!
- Add a patch for synchronizing startup()/shutdown() vs write(). 
- Add <Reviewed-by> by John.

---

Ryo Takakura (2):
  serial: sifive: lock port in startup()/shutdown() callbacks
  serial: sifive: Switch to nbcon console

 drivers/tty/serial/sifive.c | 93 +++++++++++++++++++++++++++++++------
 1 file changed, 80 insertions(+), 13 deletions(-)

-- 
2.34.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Ryo Takakura <ryotkkr98@gmail.com>
To: alex@ghiti.fr, aou@eecs.berkeley.edu, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, john.ogness@linutronix.de,
	palmer@dabbelt.com, paul.walmsley@sifive.com, pmladek@suse.com,
	samuel.holland@sifive.com, bigeasy@linutronix.de,
	conor.dooley@microchip.com, u.kleine-koenig@baylibre.com
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-serial@vger.kernel.org, Ryo Takakura <ryotkkr98@gmail.com>
Subject: [PATCH v2 0/2] serial: sifive: Convert sifive console to nbcon
Date: Sun, 30 Mar 2025 09:30:58 +0900	[thread overview]
Message-ID: <20250330003058.386447-1-ryotkkr98@gmail.com> (raw)

Hi!

This series convert sifive console to nbcon.

The first patch fixes the issue which was pointed out by John [0] 
that the driver has been accessing SIFIVE_SERIAL_IE_OFFS register 
on its ->startup() and ->shutdown() without port lock synchronization 
against ->write().

The fix on the first patch still applies to the second patch which 
converts the console to nbcon as ->write_thread() holds port lock
and ->write_atomic() checks for the console ownership.

Sincerely,
Ryo Takakura

[0] https://lore.kernel.org/lkml/84sen2fo4b.fsf@jogness.linutronix.de/

---

Changes since v1:
[1] https://lore.kernel.org/lkml/20250323060603.388621-1-ryotkkr98@gmail.com/

- Thank you John for the feedback!
- Add a patch for synchronizing startup()/shutdown() vs write(). 
- Add <Reviewed-by> by John.

---

Ryo Takakura (2):
  serial: sifive: lock port in startup()/shutdown() callbacks
  serial: sifive: Switch to nbcon console

 drivers/tty/serial/sifive.c | 93 +++++++++++++++++++++++++++++++------
 1 file changed, 80 insertions(+), 13 deletions(-)

-- 
2.34.1


             reply	other threads:[~2025-03-30  0:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-30  0:30 Ryo Takakura [this message]
2025-03-30  0:30 ` [PATCH v2 0/2] serial: sifive: Convert sifive console to nbcon Ryo Takakura
2025-03-30  0:35 ` [PATCH v2 1/2] serial: sifive: lock port in startup()/shutdown() callbacks Ryo Takakura
2025-03-30  0:35   ` Ryo Takakura
2025-03-30  0:38   ` kernel test robot
2025-03-30  1:16     ` Ryo Takakura
2025-03-30  1:16       ` Ryo Takakura
2025-03-30  7:30       ` Greg KH
2025-03-30  7:30         ` Greg KH
2025-03-30 10:51         ` Ryo Takakura
2025-03-30 10:51           ` Ryo Takakura
2025-03-30  0:40 ` [PATCH v2 2/2] serial: sifive: Switch to nbcon console Ryo Takakura
2025-03-30  0:40   ` Ryo Takakura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250330003058.386447-1-ryotkkr98@gmail.com \
    --to=ryotkkr98@gmail.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bigeasy@linutronix.de \
    --cc=conor.dooley@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=pmladek@suse.com \
    --cc=samuel.holland@sifive.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.