* [litex-hub:litex-rebase 6/15] drivers/gpio/gpio-litex.c:228 litex_gpio_irq_set_type() warn: inconsistent returns '&gpio_s->gpio_lock'.
@ 2025-03-30 5:41 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2025-03-30 5:41 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Robert Winkler <rwinkler@internships.antmicro.com>
CC: Gabriel Somlo <gsomlo@gmail.com>
CC: Marek Czerski <m.czerski@ap-tech.pl>
CC: Stafford Horne <shorne@gmail.com>
CC: Geert Uytterhoeven <geert@linux-m68k.org>
tree: https://github.com/litex-hub/linux litex-rebase
head: 896969d069ea7223671dd1aac991c551baa91bac
commit: 3eb679a2997bf7eb6be1760544632505440a563f [6/15] LiteX: driver for LiteGPIO interface
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: s390-randconfig-r072-20250330 (https://download.01.org/0day-ci/archive/20250330/202503301335.C7M94pcE-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202503301335.C7M94pcE-lkp@intel.com/
smatch warnings:
drivers/gpio/gpio-litex.c:228 litex_gpio_irq_set_type() warn: inconsistent returns '&gpio_s->gpio_lock'.
vim +228 drivers/gpio/gpio-litex.c
3eb679a2997bf7 Robert Winkler 2020-12-22 187
3eb679a2997bf7 Robert Winkler 2020-12-22 188 static int litex_gpio_irq_set_type(struct irq_data *idata, unsigned int type)
3eb679a2997bf7 Robert Winkler 2020-12-22 189 {
3eb679a2997bf7 Robert Winkler 2020-12-22 190 struct gpio_chip *chip = irq_data_get_irq_chip_data(idata);
3eb679a2997bf7 Robert Winkler 2020-12-22 191 struct litex_gpio *gpio_s = gpiochip_get_data(chip);
3eb679a2997bf7 Robert Winkler 2020-12-22 192 int offset = irqd_to_hwirq(idata) % GPIO_PINS_MAX;
3eb679a2997bf7 Robert Winkler 2020-12-22 193 unsigned long flags;
3eb679a2997bf7 Robert Winkler 2020-12-22 194 u32 bit = BIT(offset);
3eb679a2997bf7 Robert Winkler 2020-12-22 195 u32 mode, edge;
3eb679a2997bf7 Robert Winkler 2020-12-22 196
3eb679a2997bf7 Robert Winkler 2020-12-22 197 spin_lock_irqsave(&gpio_s->gpio_lock, flags);
3eb679a2997bf7 Robert Winkler 2020-12-22 198
3eb679a2997bf7 Robert Winkler 2020-12-22 199 mode = litex_gpio_get_reg(gpio_s, LITEX_GPIO_MODE_OFFSET);
3eb679a2997bf7 Robert Winkler 2020-12-22 200 edge = litex_gpio_get_reg(gpio_s, LITEX_GPIO_EDGE_OFFSET);
3eb679a2997bf7 Robert Winkler 2020-12-22 201
3eb679a2997bf7 Robert Winkler 2020-12-22 202 switch (type & IRQ_TYPE_SENSE_MASK) {
3eb679a2997bf7 Robert Winkler 2020-12-22 203 case IRQ_TYPE_NONE:
3eb679a2997bf7 Robert Winkler 2020-12-22 204 break;
3eb679a2997bf7 Robert Winkler 2020-12-22 205
3eb679a2997bf7 Robert Winkler 2020-12-22 206 case IRQ_TYPE_EDGE_RISING:
3eb679a2997bf7 Robert Winkler 2020-12-22 207 mode &= ~bit;
3eb679a2997bf7 Robert Winkler 2020-12-22 208 edge &= ~bit;
3eb679a2997bf7 Robert Winkler 2020-12-22 209 break;
3eb679a2997bf7 Robert Winkler 2020-12-22 210
3eb679a2997bf7 Robert Winkler 2020-12-22 211 case IRQ_TYPE_EDGE_FALLING:
3eb679a2997bf7 Robert Winkler 2020-12-22 212 mode &= ~bit;
3eb679a2997bf7 Robert Winkler 2020-12-22 213 edge |= bit;
3eb679a2997bf7 Robert Winkler 2020-12-22 214 break;
3eb679a2997bf7 Robert Winkler 2020-12-22 215
3eb679a2997bf7 Robert Winkler 2020-12-22 216 case IRQ_TYPE_EDGE_BOTH:
3eb679a2997bf7 Robert Winkler 2020-12-22 217 mode |= bit;
3eb679a2997bf7 Robert Winkler 2020-12-22 218 break;
3eb679a2997bf7 Robert Winkler 2020-12-22 219
3eb679a2997bf7 Robert Winkler 2020-12-22 220 default:
3eb679a2997bf7 Robert Winkler 2020-12-22 221 return -EINVAL;
3eb679a2997bf7 Robert Winkler 2020-12-22 222 }
3eb679a2997bf7 Robert Winkler 2020-12-22 223 litex_gpio_set_reg(gpio_s, LITEX_GPIO_MODE_OFFSET, mode);
3eb679a2997bf7 Robert Winkler 2020-12-22 224 litex_gpio_set_reg(gpio_s, LITEX_GPIO_EDGE_OFFSET, edge);
3eb679a2997bf7 Robert Winkler 2020-12-22 225
3eb679a2997bf7 Robert Winkler 2020-12-22 226 spin_unlock_irqrestore(&gpio_s->gpio_lock, flags);
3eb679a2997bf7 Robert Winkler 2020-12-22 227
3eb679a2997bf7 Robert Winkler 2020-12-22 @228 return 0;
3eb679a2997bf7 Robert Winkler 2020-12-22 229 }
3eb679a2997bf7 Robert Winkler 2020-12-22 230
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* [litex-hub:litex-rebase 6/15] drivers/gpio/gpio-litex.c:228 litex_gpio_irq_set_type() warn: inconsistent returns '&gpio_s->gpio_lock'.
@ 2025-03-31 9:38 Dan Carpenter
2025-04-01 9:48 ` Gabriel L. Somlo
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2025-03-31 9:38 UTC (permalink / raw)
To: oe-kbuild, Robert Winkler
Cc: lkp, oe-kbuild-all, Gabriel Somlo, Marek Czerski, Stafford Horne,
Geert Uytterhoeven
tree: https://github.com/litex-hub/linux litex-rebase
head: 896969d069ea7223671dd1aac991c551baa91bac
commit: 3eb679a2997bf7eb6be1760544632505440a563f [6/15] LiteX: driver for LiteGPIO interface
config: s390-randconfig-r072-20250330 (https://download.01.org/0day-ci/archive/20250330/202503301335.C7M94pcE-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202503301335.C7M94pcE-lkp@intel.com/
smatch warnings:
drivers/gpio/gpio-litex.c:228 litex_gpio_irq_set_type() warn: inconsistent returns '&gpio_s->gpio_lock'.
vim +228 drivers/gpio/gpio-litex.c
3eb679a2997bf7 Robert Winkler 2020-12-22 188 static int litex_gpio_irq_set_type(struct irq_data *idata, unsigned int type)
3eb679a2997bf7 Robert Winkler 2020-12-22 189 {
3eb679a2997bf7 Robert Winkler 2020-12-22 190 struct gpio_chip *chip = irq_data_get_irq_chip_data(idata);
3eb679a2997bf7 Robert Winkler 2020-12-22 191 struct litex_gpio *gpio_s = gpiochip_get_data(chip);
3eb679a2997bf7 Robert Winkler 2020-12-22 192 int offset = irqd_to_hwirq(idata) % GPIO_PINS_MAX;
3eb679a2997bf7 Robert Winkler 2020-12-22 193 unsigned long flags;
3eb679a2997bf7 Robert Winkler 2020-12-22 194 u32 bit = BIT(offset);
3eb679a2997bf7 Robert Winkler 2020-12-22 195 u32 mode, edge;
3eb679a2997bf7 Robert Winkler 2020-12-22 196
3eb679a2997bf7 Robert Winkler 2020-12-22 197 spin_lock_irqsave(&gpio_s->gpio_lock, flags);
3eb679a2997bf7 Robert Winkler 2020-12-22 198
3eb679a2997bf7 Robert Winkler 2020-12-22 199 mode = litex_gpio_get_reg(gpio_s, LITEX_GPIO_MODE_OFFSET);
3eb679a2997bf7 Robert Winkler 2020-12-22 200 edge = litex_gpio_get_reg(gpio_s, LITEX_GPIO_EDGE_OFFSET);
3eb679a2997bf7 Robert Winkler 2020-12-22 201
3eb679a2997bf7 Robert Winkler 2020-12-22 202 switch (type & IRQ_TYPE_SENSE_MASK) {
3eb679a2997bf7 Robert Winkler 2020-12-22 203 case IRQ_TYPE_NONE:
3eb679a2997bf7 Robert Winkler 2020-12-22 204 break;
3eb679a2997bf7 Robert Winkler 2020-12-22 205
3eb679a2997bf7 Robert Winkler 2020-12-22 206 case IRQ_TYPE_EDGE_RISING:
3eb679a2997bf7 Robert Winkler 2020-12-22 207 mode &= ~bit;
3eb679a2997bf7 Robert Winkler 2020-12-22 208 edge &= ~bit;
3eb679a2997bf7 Robert Winkler 2020-12-22 209 break;
3eb679a2997bf7 Robert Winkler 2020-12-22 210
3eb679a2997bf7 Robert Winkler 2020-12-22 211 case IRQ_TYPE_EDGE_FALLING:
3eb679a2997bf7 Robert Winkler 2020-12-22 212 mode &= ~bit;
3eb679a2997bf7 Robert Winkler 2020-12-22 213 edge |= bit;
3eb679a2997bf7 Robert Winkler 2020-12-22 214 break;
3eb679a2997bf7 Robert Winkler 2020-12-22 215
3eb679a2997bf7 Robert Winkler 2020-12-22 216 case IRQ_TYPE_EDGE_BOTH:
3eb679a2997bf7 Robert Winkler 2020-12-22 217 mode |= bit;
3eb679a2997bf7 Robert Winkler 2020-12-22 218 break;
3eb679a2997bf7 Robert Winkler 2020-12-22 219
3eb679a2997bf7 Robert Winkler 2020-12-22 220 default:
3eb679a2997bf7 Robert Winkler 2020-12-22 221 return -EINVAL;
unlock before returning.
3eb679a2997bf7 Robert Winkler 2020-12-22 222 }
3eb679a2997bf7 Robert Winkler 2020-12-22 223 litex_gpio_set_reg(gpio_s, LITEX_GPIO_MODE_OFFSET, mode);
3eb679a2997bf7 Robert Winkler 2020-12-22 224 litex_gpio_set_reg(gpio_s, LITEX_GPIO_EDGE_OFFSET, edge);
3eb679a2997bf7 Robert Winkler 2020-12-22 225
3eb679a2997bf7 Robert Winkler 2020-12-22 226 spin_unlock_irqrestore(&gpio_s->gpio_lock, flags);
3eb679a2997bf7 Robert Winkler 2020-12-22 227
3eb679a2997bf7 Robert Winkler 2020-12-22 @228 return 0;
3eb679a2997bf7 Robert Winkler 2020-12-22 229 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [litex-hub:litex-rebase 6/15] drivers/gpio/gpio-litex.c:228 litex_gpio_irq_set_type() warn: inconsistent returns '&gpio_s->gpio_lock'.
2025-03-31 9:38 Dan Carpenter
@ 2025-04-01 9:48 ` Gabriel L. Somlo
2025-04-01 9:55 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Gabriel L. Somlo @ 2025-04-01 9:48 UTC (permalink / raw)
To: Dan Carpenter
Cc: oe-kbuild, Robert Winkler, lkp, oe-kbuild-all, Marek Czerski,
Stafford Horne, Geert Uytterhoeven
Thanks for the report!
I've added a fix as `28882b03f381` in the current (for now) litex-rebase
against current (for now) master `08733088b566`.
I will eventually squash it on top of the original commit, unless
anyone (Geert?) notices anything still amiss... :)
Thanks much,
--Gabriel
On Mon, Mar 31, 2025 at 12:38:43PM +0300, Dan Carpenter wrote:
> tree: https://github.com/litex-hub/linux litex-rebase
> head: 896969d069ea7223671dd1aac991c551baa91bac
> commit: 3eb679a2997bf7eb6be1760544632505440a563f [6/15] LiteX: driver for LiteGPIO interface
> config: s390-randconfig-r072-20250330 (https://download.01.org/0day-ci/archive/20250330/202503301335.C7M94pcE-lkp@intel.com/config)
> compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes: https://lore.kernel.org/r/202503301335.C7M94pcE-lkp@intel.com/
>
> smatch warnings:
> drivers/gpio/gpio-litex.c:228 litex_gpio_irq_set_type() warn: inconsistent returns '&gpio_s->gpio_lock'.
>
> vim +228 drivers/gpio/gpio-litex.c
>
> 3eb679a2997bf7 Robert Winkler 2020-12-22 188 static int litex_gpio_irq_set_type(struct irq_data *idata, unsigned int type)
> 3eb679a2997bf7 Robert Winkler 2020-12-22 189 {
> 3eb679a2997bf7 Robert Winkler 2020-12-22 190 struct gpio_chip *chip = irq_data_get_irq_chip_data(idata);
> 3eb679a2997bf7 Robert Winkler 2020-12-22 191 struct litex_gpio *gpio_s = gpiochip_get_data(chip);
> 3eb679a2997bf7 Robert Winkler 2020-12-22 192 int offset = irqd_to_hwirq(idata) % GPIO_PINS_MAX;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 193 unsigned long flags;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 194 u32 bit = BIT(offset);
> 3eb679a2997bf7 Robert Winkler 2020-12-22 195 u32 mode, edge;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 196
> 3eb679a2997bf7 Robert Winkler 2020-12-22 197 spin_lock_irqsave(&gpio_s->gpio_lock, flags);
> 3eb679a2997bf7 Robert Winkler 2020-12-22 198
> 3eb679a2997bf7 Robert Winkler 2020-12-22 199 mode = litex_gpio_get_reg(gpio_s, LITEX_GPIO_MODE_OFFSET);
> 3eb679a2997bf7 Robert Winkler 2020-12-22 200 edge = litex_gpio_get_reg(gpio_s, LITEX_GPIO_EDGE_OFFSET);
> 3eb679a2997bf7 Robert Winkler 2020-12-22 201
> 3eb679a2997bf7 Robert Winkler 2020-12-22 202 switch (type & IRQ_TYPE_SENSE_MASK) {
> 3eb679a2997bf7 Robert Winkler 2020-12-22 203 case IRQ_TYPE_NONE:
> 3eb679a2997bf7 Robert Winkler 2020-12-22 204 break;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 205
> 3eb679a2997bf7 Robert Winkler 2020-12-22 206 case IRQ_TYPE_EDGE_RISING:
> 3eb679a2997bf7 Robert Winkler 2020-12-22 207 mode &= ~bit;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 208 edge &= ~bit;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 209 break;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 210
> 3eb679a2997bf7 Robert Winkler 2020-12-22 211 case IRQ_TYPE_EDGE_FALLING:
> 3eb679a2997bf7 Robert Winkler 2020-12-22 212 mode &= ~bit;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 213 edge |= bit;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 214 break;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 215
> 3eb679a2997bf7 Robert Winkler 2020-12-22 216 case IRQ_TYPE_EDGE_BOTH:
> 3eb679a2997bf7 Robert Winkler 2020-12-22 217 mode |= bit;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 218 break;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 219
> 3eb679a2997bf7 Robert Winkler 2020-12-22 220 default:
> 3eb679a2997bf7 Robert Winkler 2020-12-22 221 return -EINVAL;
>
> unlock before returning.
>
> 3eb679a2997bf7 Robert Winkler 2020-12-22 222 }
> 3eb679a2997bf7 Robert Winkler 2020-12-22 223 litex_gpio_set_reg(gpio_s, LITEX_GPIO_MODE_OFFSET, mode);
> 3eb679a2997bf7 Robert Winkler 2020-12-22 224 litex_gpio_set_reg(gpio_s, LITEX_GPIO_EDGE_OFFSET, edge);
> 3eb679a2997bf7 Robert Winkler 2020-12-22 225
> 3eb679a2997bf7 Robert Winkler 2020-12-22 226 spin_unlock_irqrestore(&gpio_s->gpio_lock, flags);
> 3eb679a2997bf7 Robert Winkler 2020-12-22 227
> 3eb679a2997bf7 Robert Winkler 2020-12-22 @228 return 0;
> 3eb679a2997bf7 Robert Winkler 2020-12-22 229 }
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [litex-hub:litex-rebase 6/15] drivers/gpio/gpio-litex.c:228 litex_gpio_irq_set_type() warn: inconsistent returns '&gpio_s->gpio_lock'.
2025-04-01 9:48 ` Gabriel L. Somlo
@ 2025-04-01 9:55 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2025-04-01 9:55 UTC (permalink / raw)
To: Gabriel L. Somlo
Cc: Dan Carpenter, oe-kbuild, Robert Winkler, lkp, oe-kbuild-all,
Marek Czerski, Stafford Horne
Hi Gabriel,
On Tue, 1 Apr 2025 at 11:48, Gabriel L. Somlo <gsomlo@gmail.com> wrote:
> I've added a fix as `28882b03f381` in the current (for now) litex-rebase
> against current (for now) master `08733088b566`.
>
> I will eventually squash it on top of the original commit, unless
> anyone (Geert?) notices anything still amiss... :)
LGTM.
Alternatively, you could have used the new
scoped_guard(spinlock_irqsave, &gpio_s->gpio_lock), but I like your
current solution that avoids writing to LITEX_GPIO_MODE_OFFSET unless
really needed.
> On Mon, Mar 31, 2025 at 12:38:43PM +0300, Dan Carpenter wrote:
> > tree: https://github.com/litex-hub/linux litex-rebase
> > head: 896969d069ea7223671dd1aac991c551baa91bac
> > commit: 3eb679a2997bf7eb6be1760544632505440a563f [6/15] LiteX: driver for LiteGPIO interface
> > config: s390-randconfig-r072-20250330 (https://download.01.org/0day-ci/archive/20250330/202503301335.C7M94pcE-lkp@intel.com/config)
> > compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > | Closes: https://lore.kernel.org/r/202503301335.C7M94pcE-lkp@intel.com/
> >
> > smatch warnings:
> > drivers/gpio/gpio-litex.c:228 litex_gpio_irq_set_type() warn: inconsistent returns '&gpio_s->gpio_lock'.
> >
> > vim +228 drivers/gpio/gpio-litex.c
> >
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 188 static int litex_gpio_irq_set_type(struct irq_data *idata, unsigned int type)
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 189 {
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 190 struct gpio_chip *chip = irq_data_get_irq_chip_data(idata);
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 191 struct litex_gpio *gpio_s = gpiochip_get_data(chip);
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 192 int offset = irqd_to_hwirq(idata) % GPIO_PINS_MAX;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 193 unsigned long flags;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 194 u32 bit = BIT(offset);
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 195 u32 mode, edge;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 196
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 197 spin_lock_irqsave(&gpio_s->gpio_lock, flags);
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 198
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 199 mode = litex_gpio_get_reg(gpio_s, LITEX_GPIO_MODE_OFFSET);
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 200 edge = litex_gpio_get_reg(gpio_s, LITEX_GPIO_EDGE_OFFSET);
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 201
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 202 switch (type & IRQ_TYPE_SENSE_MASK) {
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 203 case IRQ_TYPE_NONE:
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 204 break;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 205
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 206 case IRQ_TYPE_EDGE_RISING:
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 207 mode &= ~bit;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 208 edge &= ~bit;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 209 break;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 210
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 211 case IRQ_TYPE_EDGE_FALLING:
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 212 mode &= ~bit;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 213 edge |= bit;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 214 break;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 215
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 216 case IRQ_TYPE_EDGE_BOTH:
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 217 mode |= bit;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 218 break;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 219
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 220 default:
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 221 return -EINVAL;
> >
> > unlock before returning.
> >
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 222 }
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 223 litex_gpio_set_reg(gpio_s, LITEX_GPIO_MODE_OFFSET, mode);
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 224 litex_gpio_set_reg(gpio_s, LITEX_GPIO_EDGE_OFFSET, edge);
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 225
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 226 spin_unlock_irqrestore(&gpio_s->gpio_lock, flags);
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 227
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 @228 return 0;
> > 3eb679a2997bf7 Robert Winkler 2020-12-22 229 }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-01 9:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-30 5:41 [litex-hub:litex-rebase 6/15] drivers/gpio/gpio-litex.c:228 litex_gpio_irq_set_type() warn: inconsistent returns '&gpio_s->gpio_lock' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-03-31 9:38 Dan Carpenter
2025-04-01 9:48 ` Gabriel L. Somlo
2025-04-01 9:55 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.