[jarkko-tpmdd:keys-graveyard 16/16] security/keys/proc.c:118:45: error: 'irqflags' undeclared; did you mean 'ifr_flags'?

[jarkko-tpmdd:keys-graveyard 16/16] security/keys/proc.c:118:45: error: 'irqflags' undeclared; did you mean 'ifr_flags'?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git keys-graveyard
head:   13c6debc9b86b8bec9747d10085092d3149dce3b
commit: 13c6debc9b86b8bec9747d10085092d3149dce3b [16/16] KEYS: Add a list for unreferenced keys
config: csky-randconfig-002-20250402 (https://download.01.org/0day-ci/archive/20250402/202504020822.hqShwarn-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250402/202504020822.hqShwarn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504020822.hqShwarn-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/bitops.h:7,
                    from include/linux/thread_info.h:27,
                    from include/asm-generic/current.h:6,
                    from ./arch/csky/include/generated/asm/current.h:1,
                    from include/linux/sched.h:12,
                    from security/keys/proc.c:9:
   security/keys/proc.c: In function 'proc_keys_start':
>> security/keys/proc.c:118:45: error: 'irqflags' undeclared (first use in this function); did you mean 'ifr_flags'?
     118 |         spin_lock_irqsave(&key_serial_lock, irqflags);
         |                                             ^~~~~~~~
   include/linux/typecheck.h:11:16: note: in definition of macro 'typecheck'
      11 |         typeof(x) __dummy2; \
         |                ^
   include/linux/spinlock.h:381:9: note: in expansion of macro 'raw_spin_lock_irqsave'
     381 |         raw_spin_lock_irqsave(spinlock_check(lock), flags);     \
         |         ^~~~~~~~~~~~~~~~~~~~~
   security/keys/proc.c:118:9: note: in expansion of macro 'spin_lock_irqsave'
     118 |         spin_lock_irqsave(&key_serial_lock, irqflags);
         |         ^~~~~~~~~~~~~~~~~
   security/keys/proc.c:118:45: note: each undeclared identifier is reported only once for each function it appears in
     118 |         spin_lock_irqsave(&key_serial_lock, irqflags);
         |                                             ^~~~~~~~
   include/linux/typecheck.h:11:16: note: in definition of macro 'typecheck'
      11 |         typeof(x) __dummy2; \
         |                ^
   include/linux/spinlock.h:381:9: note: in expansion of macro 'raw_spin_lock_irqsave'
     381 |         raw_spin_lock_irqsave(spinlock_check(lock), flags);     \
         |         ^~~~~~~~~~~~~~~~~~~~~
   security/keys/proc.c:118:9: note: in expansion of macro 'spin_lock_irqsave'
     118 |         spin_lock_irqsave(&key_serial_lock, irqflags);
         |         ^~~~~~~~~~~~~~~~~
   include/linux/typecheck.h:12:25: warning: comparison of distinct pointer types lacks a cast
      12 |         (void)(&__dummy == &__dummy2); \
         |                         ^~
   include/linux/spinlock.h:243:17: note: in expansion of macro 'typecheck'
     243 |                 typecheck(unsigned long, flags);        \
         |                 ^~~~~~~~~
   include/linux/spinlock.h:381:9: note: in expansion of macro 'raw_spin_lock_irqsave'
     381 |         raw_spin_lock_irqsave(spinlock_check(lock), flags);     \
         |         ^~~~~~~~~~~~~~~~~~~~~
   security/keys/proc.c:118:9: note: in expansion of macro 'spin_lock_irqsave'
     118 |         spin_lock_irqsave(&key_serial_lock, irqflags);
         |         ^~~~~~~~~~~~~~~~~
   security/keys/proc.c: In function 'proc_keys_stop':
   security/keys/proc.c:150:50: error: 'irqflags' undeclared (first use in this function); did you mean 'ifr_flags'?
     150 |         spin_unlock_irqrestore(&key_serial_lock, irqflags);
         |                                                  ^~~~~~~~
         |                                                  ifr_flags


vim +118 security/keys/proc.c

   111	
   112	static void *proc_keys_start(struct seq_file *p, loff_t *_pos)
   113		__acquires(key_serial_lock)
   114	{
   115		key_serial_t pos = *_pos;
   116		struct key *key;
   117	
 > 118		spin_lock_irqsave(&key_serial_lock, irqflags);
   119	
   120		if (*_pos > INT_MAX)
   121			return NULL;
   122		key = find_ge_key(p, pos);
   123		if (!key)
   124			return NULL;
   125		*_pos = key->serial;
   126		return &key->serial_node;
   127	}
   128	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki