Re: [PATCH v4 2/4] net/macb: add new poll mode driver

[Stephen Hemminger <stephen@networkplumber.org>]

On Wed,  2 Apr 2025 06:58:56 +0000
liwencheng <liwencheng@phytium.com.cn> wrote:

> add Phytium NIC MACB ethdev PMD driver.
> 
> v4:
> * Changed functions that always return 0 and whose return value
> is unused to void type, improving code simplicity and readability.
> * Fixed the implicit conversion issues in the
> macb_usxgmii_pcs_check_for_link and
> macb_usxgmii_pcs_check_for_link functions.
> * Added the missing SPDX license tags.
> * Fix tab errors in meson.build file.
> * Use RTE_LOG_LINE instead of rte_log.
> * Replace %l with %PRI*64.
> * Replace rte_smp_[r/w]mb with rte_[r/w]mb.
> * Do not use variadic arguments in macros.
> * Do not use variable-length array pkts[nb_bufs].
> * Use __rte_cache_aligned only for struct or union types alignment.
> * Support hardware Rx/Tx checksum offload.
> * Fixed some code style issues.
> 
> Signed-off-by: liwencheng <liwencheng@phytium.com.cn>
> ---
>  drivers/net/macb/base/generic_phy.c |  271 +++++
>  drivers/net/macb/base/generic_phy.h |  202 ++++
>  drivers/net/macb/base/macb_common.c |  670 +++++++++++++
>  drivers/net/macb/base/macb_common.h |  254 +++++
>  drivers/net/macb/base/macb_errno.h  |   58 ++
>  drivers/net/macb/base/macb_hw.h     | 1138 +++++++++++++++++++++
>  drivers/net/macb/base/macb_type.h   |   23 +
>  drivers/net/macb/base/macb_uio.c    |  351 +++++++
>  drivers/net/macb/base/macb_uio.h    |   50 +
>  drivers/net/macb/base/meson.build   |   26 +
>  drivers/net/macb/base/motorcomm.c   |  645 ++++++++++++
>  drivers/net/macb/base/motorcomm.h   |   85 ++
>  drivers/net/macb/macb_ethdev.c      | 1866 +++++++++++++++++++++++++++++++++++
>  drivers/net/macb/macb_ethdev.h      |   96 ++
>  drivers/net/macb/macb_log.h         |   19 +
>  drivers/net/macb/macb_rxtx.c        | 1391 ++++++++++++++++++++++++++
>  drivers/net/macb/macb_rxtx.h        |  325 ++++++
>  drivers/net/macb/meson.build        |   18 +
>  drivers/net/meson.build             |    1 +
>  19 files changed, 7489 insertions(+)
>  create mode 100644 drivers/net/macb/base/generic_phy.c
>  create mode 100644 drivers/net/macb/base/generic_phy.h
>  create mode 100644 drivers/net/macb/base/macb_common.c
>  create mode 100644 drivers/net/macb/base/macb_common.h
>  create mode 100644 drivers/net/macb/base/macb_errno.h
>  create mode 100644 drivers/net/macb/base/macb_hw.h
>  create mode 100644 drivers/net/macb/base/macb_type.h
>  create mode 100644 drivers/net/macb/base/macb_uio.c
>  create mode 100644 drivers/net/macb/base/macb_uio.h
>  create mode 100644 drivers/net/macb/base/meson.build
>  create mode 100644 drivers/net/macb/base/motorcomm.c
>  create mode 100644 drivers/net/macb/base/motorcomm.h

File missing requires SPDX tag.
$ ./devtools/check-spdx-tag.sh 
drivers/net/macb/base/motorcomm.h
total: 1 missing SPDX, 0 license errors, 0 warnings