From: Stephen Hemminger <stephen@networkplumber.org>
To: Wencheng Li <liwencheng@phytium.com.cn>
Cc: dev@dpdk.org
Subject: Re: [PATCH v10 1/3] net/macb: add new poll mode driver
Date: Fri, 24 Oct 2025 09:25:14 -0700 [thread overview]
Message-ID: <20251024092514.3a62ff89@phoenix> (raw)
In-Reply-To: <1755664389-9412-1-git-send-email-liwencheng@phytium.com.cn>
On Wed, 20 Aug 2025 04:33:09 +0000
Wencheng Li <liwencheng@phytium.com.cn> wrote:
> +int __rte_cold macb_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
> + uint16_t nb_desc, unsigned int socket_id,
> + const struct rte_eth_rxconf *rx_conf,
> + struct rte_mempool *mp)
> +{
Please take off __rte_cold except where necessary; in later followups.
It is meant for special cases (like rte_log) where code that calls that
function should be less favored and does not need speed optimization.
In a driver like this it just is clutter.
next prev parent reply other threads:[~2025-10-24 16:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 6:58 [PATCH v4 2/4] net/macb: add new poll mode driver liwencheng
2025-04-03 1:43 ` Stephen Hemminger
2025-04-03 1:45 ` Stephen Hemminger
2025-04-07 6:38 ` [PATCH v5 " liwencheng
2025-04-08 6:20 ` [PATCH v6 1/3] " liwencheng
2025-04-16 16:38 ` Stephen Hemminger
2025-04-18 3:25 ` [PATCH v7 " Wencheng Li
2025-06-04 6:59 ` [PATCH v8 " Wencheng Li
2025-06-04 20:52 ` Stephen Hemminger
2025-06-06 9:06 ` [PATCH v9 " Wencheng Li
2025-06-06 15:38 ` Stephen Hemminger
2025-08-20 4:33 ` [PATCH v10 " Wencheng Li
2025-08-20 9:33 ` Ivan Malov
2025-10-24 16:25 ` Stephen Hemminger [this message]
2025-10-28 8:31 ` [PATCH v11 " Wencheng Li
2025-04-16 16:34 ` [PATCH v4 2/4] " Stephen Hemminger
2025-04-16 16:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024092514.3a62ff89@phoenix \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=liwencheng@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.