Re: [RFC net-next PATCH 03/13] net: pcs: Add subsystem

[kernel test robot <lkp@intel.com>]

Hi Sean,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/dt-bindings-net-Add-binding-for-Xilinx-PCS/20250404-023209
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250403181907.1947517-4-sean.anderson%40linux.dev
patch subject: [RFC net-next PATCH 03/13] net: pcs: Add subsystem
config: loongarch-randconfig-001-20250404 (https://download.01.org/0day-ci/archive/20250404/202504042242.11oJSS49-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250404/202504042242.11oJSS49-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504042242.11oJSS49-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/pcs/core.c: In function 'pcs_unregister':
>> drivers/net/pcs/core.c:373:29: warning: variable 'wrapped' set but not used [-Wunused-but-set-variable]
     373 |         struct phylink_pcs *wrapped;
         |                             ^~~~~~~


vim +/wrapped +373 drivers/net/pcs/core.c

   365	
   366	/**
   367	 * pcs_unregister() - unregister a PCS
   368	 * @pcs: a PCS previously registered with pcs_register()
   369	 */
   370	void pcs_unregister(struct phylink_pcs *pcs)
   371	{
   372		struct pcs_wrapper *wrapper;
 > 373		struct phylink_pcs *wrapped;
   374	
   375		mutex_lock(&pcs_mutex);
   376		list_for_each_entry(wrapper, &pcs_wrappers, list) {
   377			if (wrapper->wrapped == pcs)
   378				goto found;
   379		}
   380	
   381		mutex_unlock(&pcs_mutex);
   382		WARN(1, "trying to unregister an already-unregistered PCS\n");
   383		return;
   384	
   385	found:
   386		list_del(&wrapper->list);
   387		wrapped = rcu_replace_pointer(wrapper->wrapped, NULL, true);
   388		mutex_unlock(&pcs_mutex);
   389		synchronize_srcu(&wrapper->ssp);
   390	
   391		if (!wrapper->pcs.poll)
   392			phylink_pcs_change(&wrapper->pcs, false);
   393		if (refcount_dec_and_test(&wrapper->refcnt))
   394			pcs_destroy(wrapper);
   395	}
   396	EXPORT_SYMBOL_GPL(pcs_unregister);
   397	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki