+ kunit-slub-add-module-description.patch added to mm-nonmm-unstable branch

+ kunit-slub-add-module-description.patch added to mm-nonmm-unstable branch

[Andrew Morton]

The patch titled
     Subject: kunit: slub: add module description
has been added to the -mm mm-nonmm-unstable branch.  Its filename is
     kunit-slub-add-module-description.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/kunit-slub-add-module-description.patch

This patch will later appear in the mm-nonmm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Arnd Bergmann <arnd@arndb.de>
Subject: kunit: slub: add module description
Date: Mon, 24 Mar 2025 18:32:35 +0100

Modules without a description now cause a warning:

WARNING: modpost: missing MODULE_DESCRIPTION() in lib/tests/slub_kunit.o

Link: https://lkml.kernel.org/r/20250324173242.1501003-10-arnd@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Guenetr Roeck <linux@roeck-us.net>
Cc: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Pei Xiao <xiaopei01@kylinos.cn>
Cc: Rae Moar <rmoar@google.com>
Cc: Stehen Rothwell <sfr@canb.auug.org.au>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 lib/tests/slub_kunit.c |    1 +
 1 file changed, 1 insertion(+)

--- a/lib/tests/slub_kunit.c~kunit-slub-add-module-description
+++ a/lib/tests/slub_kunit.c
@@ -325,4 +325,5 @@ static struct kunit_suite test_suite = {
 };
 kunit_test_suite(test_suite);
 
+MODULE_DESCRIPTION("Kunit tests for slub allocator");
 MODULE_LICENSE("GPL");
_

Patches currently in -mm which might be from arnd@arndb.de are

exportfs-add-module-description.patch
asn1-add-module-description.patch
samples-livepatch-add-module-descriptions.patch
fpga-tests-add-module-descriptions.patch
xenbus-add-module-description.patch
zlib-add-module-description.patch
ucs2_string-add-module-description.patch
mm-kasan-add-module-decription.patch
kunit-slub-add-module-description.patch

Re: + kunit-slub-add-module-description.patch added to mm-nonmm-unstable branch

[Vlastimil Babka]

On 4/7/25 03:48, Andrew Morton wrote:
> The patch titled
>      Subject: kunit: slub: add module description
> has been added to the -mm mm-nonmm-unstable branch.  Its filename is
>      kunit-slub-add-module-description.patch
> 
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/kunit-slub-add-module-description.patch
> 
> This patch will later appear in the mm-nonmm-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Hi,

since there's a new warning (initially even error) in rc1, could this and
other -add-module-descriptions.patch be moved to hotfixes?

Thanks,
Vlastimil

> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
> 
> ------------------------------------------------------
> From: Arnd Bergmann <arnd@arndb.de>
> Subject: kunit: slub: add module description
> Date: Mon, 24 Mar 2025 18:32:35 +0100
> 
> Modules without a description now cause a warning:
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/tests/slub_kunit.o
> 
> Link: https://lkml.kernel.org/r/20250324173242.1501003-10-arnd@kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Guenetr Roeck <linux@roeck-us.net>
> Cc: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Pei Xiao <xiaopei01@kylinos.cn>
> Cc: Rae Moar <rmoar@google.com>
> Cc: Stehen Rothwell <sfr@canb.auug.org.au>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  lib/tests/slub_kunit.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/lib/tests/slub_kunit.c~kunit-slub-add-module-description
> +++ a/lib/tests/slub_kunit.c
> @@ -325,4 +325,5 @@ static struct kunit_suite test_suite = {
>  };
>  kunit_test_suite(test_suite);
>  
> +MODULE_DESCRIPTION("Kunit tests for slub allocator");
>  MODULE_LICENSE("GPL");
> _
> 
> Patches currently in -mm which might be from arnd@arndb.de are
> 
> exportfs-add-module-description.patch
> asn1-add-module-description.patch
> samples-livepatch-add-module-descriptions.patch
> fpga-tests-add-module-descriptions.patch
> xenbus-add-module-description.patch
> zlib-add-module-description.patch
> ucs2_string-add-module-description.patch
> mm-kasan-add-module-decription.patch
> kunit-slub-add-module-description.patch
> 

Re: + kunit-slub-add-module-description.patch added to mm-nonmm-unstable branch

[Andrew Morton]

On Mon, 7 Apr 2025 10:23:00 +0200 Vlastimil Babka <vbabka@suse.cz> wrote:

> On 4/7/25 03:48, Andrew Morton wrote:
> > The patch titled
> >      Subject: kunit: slub: add module description
> > has been added to the -mm mm-nonmm-unstable branch.  Its filename is
> >      kunit-slub-add-module-description.patch
> > 
> > This patch will shortly appear at
> >      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/kunit-slub-add-module-description.patch
> > 
> > This patch will later appear in the mm-nonmm-unstable branch at
> >     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> 
> Hi,
> 
> since there's a new warning (initially even error) in rc1, could this and
> other -add-module-descriptions.patch be moved to hotfixes?

Ok, but all we have is "Modules without a description now cause a
warning".

Specifically which commit caused these warnings to start coming out?

Re: + kunit-slub-add-module-description.patch added to mm-nonmm-unstable branch

[Vlastimil Babka]

On 4/7/25 10:37, Andrew Morton wrote:
> On Mon, 7 Apr 2025 10:23:00 +0200 Vlastimil Babka <vbabka@suse.cz> wrote:
> 
>> On 4/7/25 03:48, Andrew Morton wrote:
>> > The patch titled
>> >      Subject: kunit: slub: add module description
>> > has been added to the -mm mm-nonmm-unstable branch.  Its filename is
>> >      kunit-slub-add-module-description.patch
>> > 
>> > This patch will shortly appear at
>> >      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/kunit-slub-add-module-description.patch
>> > 
>> > This patch will later appear in the mm-nonmm-unstable branch at
>> >     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>> 
>> Hi,
>> 
>> since there's a new warning (initially even error) in rc1, could this and
>> other -add-module-descriptions.patch be moved to hotfixes?
> 
> Ok, but all we have is "Modules without a description now cause a
> warning".
> 
> Specifically which commit caused these warnings to start coming out?

I think 6c6c1fc09de3 ("modpost: require a MODULE_DESCRIPTION()")
made it an error (previously W=1 warning)

6f110a5e4f99 ("Disable SLUB_TINY for build testing")
reduced it to warning (but not back to W=1)