From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Subject: [PATCH v2 1/6] i2c: core: Drop duplicate check before calling OF APIs
Date: Mon, 7 Apr 2025 12:55:12 +0300 [thread overview]
Message-ID: <20250407095852.215809-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20250407095852.215809-1-andriy.shevchenko@linux.intel.com>
OF APIs are usually NULL-aware and returns an error in case when
device node is not present or supported. We already have a check
for the returned value, no need to check for the parameter.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/i2c/i2c-core-base.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 7ad1ad5c8c3f..c14ffd6190d3 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -1209,11 +1209,9 @@ struct i2c_client *i2c_new_ancillary_device(struct i2c_client *client,
u32 addr = default_addr;
int i;
- if (np) {
- i = of_property_match_string(np, "reg-names", name);
- if (i >= 0)
- of_property_read_u32_index(np, "reg", i, &addr);
- }
+ i = of_property_match_string(np, "reg-names", name);
+ if (i >= 0)
+ of_property_read_u32_index(np, "reg", i, &addr);
dev_dbg(&client->adapter->dev, "Address for %s : 0x%x\n", name, addr);
return i2c_new_dummy_device(client->adapter, addr);
@@ -1651,12 +1649,10 @@ int i2c_add_adapter(struct i2c_adapter *adapter)
struct device *dev = &adapter->dev;
int id;
- if (dev->of_node) {
- id = of_alias_get_id(dev->of_node, "i2c");
- if (id >= 0) {
- adapter->nr = id;
- return __i2c_add_numbered_adapter(adapter);
- }
+ id = of_alias_get_id(dev->of_node, "i2c");
+ if (id >= 0) {
+ adapter->nr = id;
+ return __i2c_add_numbered_adapter(adapter);
}
mutex_lock(&core_lock);
--
2.47.2
next prev parent reply other threads:[~2025-04-07 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 9:55 [PATCH v2 0/6] i2c: core: Move client towards fwnode Andy Shevchenko
2025-04-07 9:55 ` Andy Shevchenko [this message]
2025-04-07 9:55 ` [PATCH v2 2/6] i2c: core: Unify the firmware node type check Andy Shevchenko
2025-04-07 12:45 ` kernel test robot
2025-04-07 13:48 ` Andy Shevchenko
2025-04-07 13:47 ` kernel test robot
2025-04-07 9:55 ` [PATCH v2 3/6] i2c: core: Switch to fwnode APIs to get IRQ Andy Shevchenko
2025-04-07 13:47 ` kernel test robot
2025-04-07 9:55 ` [PATCH v2 4/6] i2c: core: Reuse fwnode variable where it makes sense Andy Shevchenko
2025-04-07 9:55 ` [PATCH v2 5/6] i2c: core: Do not dereference fwnode in struct device Andy Shevchenko
2025-04-07 9:55 ` [PATCH v2 6/6] i2c: core: Deprecate of_node in struct i2c_board_info Andy Shevchenko
2025-04-07 11:34 ` [PATCH v2 0/6] i2c: core: Move client towards fwnode Tomi Valkeinen
2025-04-07 12:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407095852.215809-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.