Re: [LTP] [RFC][PATCH 2/2] runtest: Move ipc into syscalls

[Petr Vorel <pvorel@suse.cz>]

Hi,

> On Thu, Apr 3, 2025 at 6:19 PM Petr Vorel <pvorel@suse.cz> wrote:

> > It's not worth to keep separate runtest file for 8 very quick tests.
> > syscalls-ipc would be obvious runtest to move, but it contains tests for
> > message queues, semaphores etc. Other IPC tests are in syscalls runtest,
> > therefore move tests there.

> > Remove test description (can be visible from help and the test output,
> > it was also below the test not above).

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>

> ---
> >  runtest/ipc      | 28 ----------------------------
> >  runtest/syscalls |  9 +++++++++
> >  2 files changed, 9 insertions(+), 28 deletions(-)
> >  delete mode 100644 runtest/ipc

> > diff --git a/runtest/ipc b/runtest/ipc
> > deleted file mode 100644
> > index f5cdea1974..0000000000
> > --- a/runtest/ipc
> > +++ /dev/null
> > @@ -1,28 +0,0 @@



> > -#DESCRIPTION:Interprocess communication stress
> > -# These tests use tests/pipeio to put pipes (named or unnamed) through a
> > workout



> > -#
> > -pipeio_1 pipeio -T pipeio_1 -c 5 -s 4090 -i 100 -b -f x80
> > -# spawns 5 children to write 100 chunks of 4090 bytes to a named pipe
> > -# using blocking I/O
> > -pipeio_2 pipeio -T pipeio_2 -c 5 -s 4090 -i 100 -f x80
> > -# spawns 5 children to write 100 chunks of 4090 bytes to a named pipe
> > -# using non-blocking I/O
> > -pipeio_3 pipeio -T pipeio_3 -c 5 -s 4090 -i 100 -u -b -f x80
> > -# spawns 5 children to write 100 chunks of 4090 bytes to an unnamed pipe
> > -# using blocking I/O
> > -pipeio_4 pipeio -T pipeio_4 -c 5 -s 4090 -i 100 -u -f x80
> > -# spawns 5 children to write 100 chunks of 4090 bytes to an unnamed pipe
> > -# using non-blocking I/O
> > -pipeio_5 pipeio -T pipeio_5 -c 5 -s 5000 -i 10 -b -f x80
> > -# spawns 5 children to write 10 chunks of 5000 bytes to a named pipe
> > -# using blocking I/O
> > -pipeio_6 pipeio -T pipeio_6 -c 5 -s 5000 -i 10 -b -u -f x80
> > -# spawns 5 children to write 10 chunks of 5000 bytes to an unnamed pipe
> > -# using blocking I/O
> > -pipeio_7 pipeio -T pipeio_7 -c 5 -s 5000 -i 10 -f x80
> > -# spawns 5 children to write 10 chunks of 5000 bytes to a named pipe
> > -# using non-blocking I/O
> > -pipeio_8 pipeio -T pipeio_8 -c 5 -s 5000 -i 10 -u -f x80
> > -# spawns 5 children to write 10 chunks of 5000 bytes to an unnamed pipe
> > -# using non-blocking I/O
> > -
> > diff --git a/runtest/syscalls b/runtest/syscalls
> > index 05b3e0d376..b911aba7b6 100644
> > --- a/runtest/syscalls
> > +++ b/runtest/syscalls
> > @@ -1047,6 +1047,15 @@ pipe2_01 pipe2_01
> >  pipe2_02 pipe2_02
> >  pipe2_04 pipe2_04


> Maybe we can add one-line comments here to explain that these are
> Interprocess communication stress test?

> Since syscalls is a large file (containing so many tests), it makes sense
> to comment on something there to explain the subtest blocks.

Hi Li,

sure, I can add "# Interprocess communication stress tests" before merge.
Because change is trivial, instead of resending v2 I just post a diff below.

Kind regards,
Petr

> > +pipeio_1 pipeio -T pipeio_1 -c 5 -s 4090 -i 100 -b -f x80
> > +pipeio_2 pipeio -T pipeio_2 -c 5 -s 4090 -i 100 -f x80
> > +pipeio_3 pipeio -T pipeio_3 -c 5 -s 4090 -i 100 -u -b -f x80
> > +pipeio_4 pipeio -T pipeio_4 -c 5 -s 4090 -i 100 -u -f x80
> > +pipeio_5 pipeio -T pipeio_5 -c 5 -s 5000 -i 10 -b -f x80
> > +pipeio_6 pipeio -T pipeio_6 -c 5 -s 5000 -i 10 -b -u -f x80
> > +pipeio_7 pipeio -T pipeio_7 -c 5 -s 5000 -i 10 -f x80
> > +pipeio_8 pipeio -T pipeio_8 -c 5 -s 5000 -i 10 -u -f x80



> Reviewed-by: Li Wang <liwang@redhat.com>

diff --git runtest/syscalls runtest/syscalls
index a5ee1aa06c..7719cb2075 100644
--- runtest/syscalls
+++ runtest/syscalls
@@ -1049,6 +1049,7 @@ pipe2_01 pipe2_01
 pipe2_02 pipe2_02
 pipe2_04 pipe2_04
 
+# Interprocess communication stress tests
 pipeio_1 pipeio -T pipeio_1 -c 5 -s 4090 -i 100 -b -f x80
 pipeio_2 pipeio -T pipeio_2 -c 5 -s 4090 -i 100 -f x80
 pipeio_3 pipeio -T pipeio_3 -c 5 -s 4090 -i 100 -u -b -f x80

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp