[PATCH 0/2] RB1 fixes

[PATCH 0/2] RB1 fixes

[Sumit Garg]

The eMMC on RB1 boards supports HS200 mode but currently the msm_shdci
driver in U-Boot is missing DLL configuration required for HS200 mode to
work. Hence disable HS200 for now until proper support is in place.

Apart from that, add DT override for USB to work in host mode as otg
mode isn't supported. Along with that disable sdhci_2 which doesn't work
as of now.

There is another patch related to clk_stub posted here [1] which allows
the MMC clocks to be probed properly.

[1] https://patchwork.ozlabs.org/project/uboot/patch/20250407120536.236003-4-jorge.ramirez@oss.qualcomm.com/

Sumit Garg (2):
  arm: dts: Add override for RB1
  qcom_defconfig: Disable MMC HS200 mode support

 arch/arm/dts/qrb2210-rb1-u-boot.dtsi | 11 +++++++++++
 configs/qcom_defconfig               |  1 -
 2 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/qrb2210-rb1-u-boot.dtsi

-- 
2.43.0

[PATCH 1/2] arm: dts: Add override for RB1

[Sumit Garg]

Add U-Boot override for RB1 to for USB in host mode as OTG mode isn't
supported. Also, disable sdhc_2 as it's currently not supported, sdhc_1
works fine though.

Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
---
 arch/arm/dts/qrb2210-rb1-u-boot.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 arch/arm/dts/qrb2210-rb1-u-boot.dtsi

diff --git a/arch/arm/dts/qrb2210-rb1-u-boot.dtsi b/arch/arm/dts/qrb2210-rb1-u-boot.dtsi
new file mode 100644
index 00000000000..1e136ee405a
--- /dev/null
+++ b/arch/arm/dts/qrb2210-rb1-u-boot.dtsi
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/* This is usually OTG but U-Boot doesn't support that properly */
+&usb_dwc3 {
+	dr_mode = "host";
+};
+
+/* SDHC_2 isn't supported in U-Boot as of now */
+&sdhc_2 {
+	status = "disabled";
+};
-- 
2.43.0

[PATCH 2/2] qcom_defconfig: Disable MMC HS200 mode support

[Sumit Garg]

Currently the msm_sdhci doesn't yet support DLL configurations which are
required to enable bus speeds greater that 100MHz. So disable HS200 mode
support as of now as it requires bus speeds of 200MHz.

This should fix eMMC issues reported on RB1.

Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
---
 configs/qcom_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
index a2b54b95f19..537806450dc 100644
--- a/configs/qcom_defconfig
+++ b/configs/qcom_defconfig
@@ -81,7 +81,6 @@ CONFIG_QCOM_HYP_SMMU=y
 CONFIG_MISC=y
 CONFIG_NVMEM=y
 CONFIG_I2C_EEPROM=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ADMA=y
 CONFIG_MMC_SDHCI_MSM=y
-- 
2.43.0

[PATCH 0/2] RB1 fixes

[Sumit Garg]

From: Sumit Garg <sumit.garg@oss.qualcomm.com>

The eMMC on RB1 boards supports HS200 mode but currently the msm_shdci
driver in U-Boot is missing DLL configuration required for HS200 mode to
work. Hence disable HS200 for now until proper support is in place.

Apart from that, add DT override for USB to work in host mode as otg
mode isn't supported. Along with that disable sdhci_2 which doesn't work
as of now.

There is another patch related to clk_stub posted here [1] which allows
the MMC clocks to be probed properly.

[1] https://patchwork.ozlabs.org/project/uboot/patch/20250407120536.236003-4-jorge.ramirez@oss.qualcomm.com/

Sumit Garg (2):
  arm: dts: Add override for RB1
  qcom_defconfig: Disable MMC HS200 mode support

 arch/arm/dts/qrb2210-rb1-u-boot.dtsi | 11 +++++++++++
 configs/qcom_defconfig               |  1 -
 2 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/qrb2210-rb1-u-boot.dtsi

-- 
2.43.0

[PATCH 2/2] qcom_defconfig: Disable MMC HS200 mode support

[Sumit Garg]

From: Sumit Garg <sumit.garg@oss.qualcomm.com>

Currently the msm_sdhci doesn't yet support DLL configurations which are
required to enable bus speeds greater that 100MHz. So disable HS200 mode
support as of now as it requires bus speeds of 200MHz.

This should fix eMMC issues reported on RB1.

Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
---
 configs/qcom_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
index a2b54b95f19..537806450dc 100644
--- a/configs/qcom_defconfig
+++ b/configs/qcom_defconfig
@@ -81,7 +81,6 @@ CONFIG_QCOM_HYP_SMMU=y
 CONFIG_MISC=y
 CONFIG_NVMEM=y
 CONFIG_I2C_EEPROM=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ADMA=y
 CONFIG_MMC_SDHCI_MSM=y
-- 
2.43.0

Re: [PATCH 2/2] qcom_defconfig: Disable MMC HS200 mode support

[Caleb Connolly]

On 4/7/25 15:28, Sumit Garg wrote:
> From: Sumit Garg <sumit.garg@oss.qualcomm.com>
> 
> Currently the msm_sdhci doesn't yet support DLL configurations which are
> required to enable bus speeds greater that 100MHz. So disable HS200 mode
> support as of now as it requires bus speeds of 200MHz.
> 
> This should fix eMMC issues reported on RB1.

This fixes the write corruption issues? Nice find!!

Is this a problem on ALL Qualcomm platforms? the sdcard seems to work 
fine on other boards, would this reduce their performance?

> 
> Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
> ---
>   configs/qcom_defconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
> index a2b54b95f19..537806450dc 100644
> --- a/configs/qcom_defconfig
> +++ b/configs/qcom_defconfig
> @@ -81,7 +81,6 @@ CONFIG_QCOM_HYP_SMMU=y
>   CONFIG_MISC=y
>   CONFIG_NVMEM=y
>   CONFIG_I2C_EEPROM=y
> -CONFIG_MMC_HS200_SUPPORT=y
>   CONFIG_MMC_SDHCI=y
>   CONFIG_MMC_SDHCI_ADMA=y
>   CONFIG_MMC_SDHCI_MSM=y

-- 
Caleb (they/them)

Re: [PATCH 2/2] qcom_defconfig: Disable MMC HS200 mode support

[Sumit Garg]

On Mon, Apr 07, 2025 at 04:30:44PM +0200, Caleb Connolly wrote:
> 
> 
> On 4/7/25 15:28, Sumit Garg wrote:
> > From: Sumit Garg <sumit.garg@oss.qualcomm.com>
> > 
> > Currently the msm_sdhci doesn't yet support DLL configurations which are
> > required to enable bus speeds greater that 100MHz. So disable HS200 mode
> > support as of now as it requires bus speeds of 200MHz.
> > 
> > This should fix eMMC issues reported on RB1.
> 
> This fixes the write corruption issues? Nice find!!

Yeah, thanks.

> 
> Is this a problem on ALL Qualcomm platforms? the sdcard seems to work fine
> on other boards, would this reduce their performance?

Yes this problem should affect all Qualcomm platforms but it hasn't been
seen there as mostly SD cards available don't support HS200 mode. The SD
cards usually works in high speed mode whose performance remains
unaffected by this change. It only affects RB1/RB2 as eMMC flash on
these support HS200 mode but the U-Boot driver currently is incapable of
supporting that.

-Sumit

> 
> > 
> > Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
> > ---
> >   configs/qcom_defconfig | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
> > index a2b54b95f19..537806450dc 100644
> > --- a/configs/qcom_defconfig
> > +++ b/configs/qcom_defconfig
> > @@ -81,7 +81,6 @@ CONFIG_QCOM_HYP_SMMU=y
> >   CONFIG_MISC=y
> >   CONFIG_NVMEM=y
> >   CONFIG_I2C_EEPROM=y
> > -CONFIG_MMC_HS200_SUPPORT=y
> >   CONFIG_MMC_SDHCI=y
> >   CONFIG_MMC_SDHCI_ADMA=y
> >   CONFIG_MMC_SDHCI_MSM=y
> 
> -- 
> Caleb (they/them)
> 

Re: [PATCH 2/2] qcom_defconfig: Disable MMC HS200 mode support

[Caleb Connolly]

On 4/8/25 06:29, Sumit Garg wrote:
> On Mon, Apr 07, 2025 at 04:30:44PM +0200, Caleb Connolly wrote:
>>
>>
>> On 4/7/25 15:28, Sumit Garg wrote:
>>> From: Sumit Garg <sumit.garg@oss.qualcomm.com>
>>>
>>> Currently the msm_sdhci doesn't yet support DLL configurations which are
>>> required to enable bus speeds greater that 100MHz. So disable HS200 mode
>>> support as of now as it requires bus speeds of 200MHz.
>>>
>>> This should fix eMMC issues reported on RB1.
>>
>> This fixes the write corruption issues? Nice find!!
> 
> Yeah, thanks.
> 
>>
>> Is this a problem on ALL Qualcomm platforms? the sdcard seems to work fine
>> on other boards, would this reduce their performance?
> 
> Yes this problem should affect all Qualcomm platforms but it hasn't been
> seen there as mostly SD cards available don't support HS200 mode. The SD
> cards usually works in high speed mode whose performance remains
> unaffected by this change. It only affects RB1/RB2 as eMMC flash on
> these support HS200 mode but the U-Boot driver currently is incapable of
> supporting that.

Ok awesome. Could you include this info in the commit message? Then

Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>

Kind regards,>
> -Sumit
> 
>>
>>>
>>> Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
>>> ---
>>>    configs/qcom_defconfig | 1 -
>>>    1 file changed, 1 deletion(-)
>>>
>>> diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
>>> index a2b54b95f19..537806450dc 100644
>>> --- a/configs/qcom_defconfig
>>> +++ b/configs/qcom_defconfig
>>> @@ -81,7 +81,6 @@ CONFIG_QCOM_HYP_SMMU=y
>>>    CONFIG_MISC=y
>>>    CONFIG_NVMEM=y
>>>    CONFIG_I2C_EEPROM=y
>>> -CONFIG_MMC_HS200_SUPPORT=y
>>>    CONFIG_MMC_SDHCI=y
>>>    CONFIG_MMC_SDHCI_ADMA=y
>>>    CONFIG_MMC_SDHCI_MSM=y
>>
>> -- 
>> Caleb (they/them)
>>

-- 
Caleb (they/them)

Re: [PATCH 2/2] qcom_defconfig: Disable MMC HS200 mode support

[Sumit Garg]

On Tue, Apr 08, 2025 at 02:13:55PM +0200, Caleb Connolly wrote:
> 
> 
> On 4/8/25 06:29, Sumit Garg wrote:
> > On Mon, Apr 07, 2025 at 04:30:44PM +0200, Caleb Connolly wrote:
> > > 
> > > 
> > > On 4/7/25 15:28, Sumit Garg wrote:
> > > > From: Sumit Garg <sumit.garg@oss.qualcomm.com>
> > > > 
> > > > Currently the msm_sdhci doesn't yet support DLL configurations which are
> > > > required to enable bus speeds greater that 100MHz. So disable HS200 mode
> > > > support as of now as it requires bus speeds of 200MHz.
> > > > 
> > > > This should fix eMMC issues reported on RB1.
> > > 
> > > This fixes the write corruption issues? Nice find!!
> > 
> > Yeah, thanks.
> > 
> > > 
> > > Is this a problem on ALL Qualcomm platforms? the sdcard seems to work fine
> > > on other boards, would this reduce their performance?
> > 
> > Yes this problem should affect all Qualcomm platforms but it hasn't been
> > seen there as mostly SD cards available don't support HS200 mode. The SD
> > cards usually works in high speed mode whose performance remains
> > unaffected by this change. It only affects RB1/RB2 as eMMC flash on
> > these support HS200 mode but the U-Boot driver currently is incapable of
> > supporting that.
> 
> Ok awesome. Could you include this info in the commit message? Then

Sure, I can expand the commit message.

> 
> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
>

Thanks.

-Sumit