All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ia64: Reset grub_errno on failure to allocate
@ 2025-04-07 19:05 Vladimir Serbinenko
  2025-04-10 14:55 ` Daniel Kiper
  0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Serbinenko @ 2025-04-07 19:05 UTC (permalink / raw)
  To: grub-devel; +Cc: Vladimir Serbinenko

The code goes on to allocate memory in another region on failure, hence
it should discard the error.

Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
---
 grub-core/loader/ia64/efi/linux.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/grub-core/loader/ia64/efi/linux.c b/grub-core/loader/ia64/efi/linux.c
index 3dd2e8236..99cb244d8 100644
--- a/grub-core/loader/ia64/efi/linux.c
+++ b/grub-core/loader/ia64/efi/linux.c
@@ -383,6 +383,7 @@ grub_load_elf64 (grub_file_t file, void *buffer, const char *filename)
     {
       kernel_mem = grub_efi_allocate_fixed (low_addr, kernel_pages);
       reloc_offset = 0;
+      grub_errno = GRUB_ERR_NONE;
     }
   /* Try to relocate.  */
   if (! kernel_mem && (!relocate || grub_strcmp (relocate, "off") != 0))
-- 
2.49.0


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ia64: Reset grub_errno on failure to allocate
  2025-04-07 19:05 [PATCH] ia64: Reset grub_errno on failure to allocate Vladimir Serbinenko
@ 2025-04-10 14:55 ` Daniel Kiper
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kiper @ 2025-04-10 14:55 UTC (permalink / raw)
  To: The development of GNU GRUB; +Cc: Vladimir Serbinenko

On Mon, Apr 07, 2025 at 10:05:40PM +0300, Vladimir Serbinenko wrote:
> The code goes on to allocate memory in another region on failure, hence
> it should discard the error.
>
> Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-10 14:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07 19:05 [PATCH] ia64: Reset grub_errno on failure to allocate Vladimir Serbinenko
2025-04-10 14:55 ` Daniel Kiper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.