[android-common:android13-5.15-2024-05 0/1] drivers/net/ethernet/litex/litex_liteeth.c:247:2-9: line 247 is redundant because platform_get_irq() already prints an error

[android-common:android13-5.15-2024-05 0/1] drivers/net/ethernet/litex/litex_liteeth.c:247:2-9: line 247 is redundant because platform_get_irq() already prints an error

[kernel test robot]

tree:   https://android.googlesource.com/kernel/common android13-5.15-2024-05
head:   96ddb774d408960590543f104a10aba091d123d6
commit: ee7da21ac4c3be1f618b6358e0a38739a5d1773e [0/1] net: Add driver for LiteX's LiteETH network interface
config: i386-randconfig-052-20250403 (https://download.01.org/0day-ci/archive/20250407/202504071934.7aQnH1EO-lkp@intel.com/config)
compiler: clang version 20.1.1 (https://github.com/llvm/llvm-project 424c2d9b7e4de40d0804dd374721e6411c27d1d1)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504071934.7aQnH1EO-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/litex/litex_liteeth.c:247:2-9: line 247 is redundant because platform_get_irq() already prints an error

vim +247 drivers/net/ethernet/litex/litex_liteeth.c

   225	
   226	static int liteeth_probe(struct platform_device *pdev)
   227	{
   228		struct net_device *netdev;
   229		void __iomem *buf_base;
   230		struct resource *res;
   231		struct liteeth *priv;
   232		int irq, err;
   233	
   234		netdev = devm_alloc_etherdev(&pdev->dev, sizeof(*priv));
   235		if (!netdev)
   236			return -ENOMEM;
   237	
   238		SET_NETDEV_DEV(netdev, &pdev->dev);
   239		platform_set_drvdata(pdev, netdev);
   240	
   241		priv = netdev_priv(netdev);
   242		priv->netdev = netdev;
   243		priv->dev = &pdev->dev;
   244	
   245		irq = platform_get_irq(pdev, 0);
   246		if (irq < 0) {
 > 247			dev_err(&pdev->dev, "Failed to get IRQ %d\n", irq);
   248			return irq;
   249		}
   250		netdev->irq = irq;
   251	
   252		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mac");
   253		priv->base = devm_ioremap_resource(&pdev->dev, res);
   254		if (IS_ERR(priv->base))
   255			return PTR_ERR(priv->base);
   256	
   257		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "buffer");
   258		buf_base = devm_ioremap_resource(&pdev->dev, res);
   259		if (IS_ERR(buf_base))
   260			return PTR_ERR(buf_base);
   261	
   262		liteeth_setup_slots(priv);
   263	
   264		/* Rx slots */
   265		priv->rx_base = buf_base;
   266		priv->rx_slot = 0;
   267	
   268		/* Tx slots come after Rx slots */
   269		priv->tx_base = buf_base + priv->num_rx_slots * priv->slot_size;
   270		priv->tx_slot = 0;
   271	
   272		err = of_get_mac_address(pdev->dev.of_node, netdev->dev_addr);
   273		if (err)
   274			eth_hw_addr_random(netdev);
   275	
   276		netdev->netdev_ops = &liteeth_netdev_ops;
   277	
   278		err = register_netdev(netdev);
   279		if (err) {
   280			dev_err(&pdev->dev, "Failed to register netdev %d\n", err);
   281			return err;
   282		}
   283	
   284		netdev_info(netdev, "irq %d slots: tx %d rx %d size %d\n",
   285			    netdev->irq, priv->num_tx_slots, priv->num_rx_slots, priv->slot_size);
   286	
   287		return 0;
   288	}
   289	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki