Re: [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot

[Luca Ceresoli via buildroot <buildroot@buildroot.org>]

Hi Neal,

On Thu, 27 Mar 2025 11:16:43 +0000
Neal Frager <neal.frager@amd.com> wrote:

> This patch renames the bare-metal toolchain vendor used by the
> xilinx-embeddedsw package from Xilinx to Buildroot to be consistent with all
> other toolchains built by Buildroot.
> 
> To build the Microblaze applications available with the xilinx-embeddedsw
> package, the following config is now needed:
> 
> BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
> 
> This change keeps backwards compatibility for users already using the
> following architecture tuple:
> 
> BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
> 
> Either vendor name is now valid, but the documentation will describe using
> the Buildroot vendor name.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

I don't have a strong opinion about this series. Definitely the
"buildroot" vendor name is more appropriate than "xilinx", and the
patches look clean enough, but I'll let the maintainers decide whether
it's worth the extra effort.

If this is accepted, however, I think we should remove the "xilinx"
vendor support after 1y~1.5y and not carry the maintenance burden
indefinitely. Do you think this can be handled by Config.in.legacy, so
in the transition phase users of the old tuple are notified?

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot