* [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot
@ 2025-03-27 11:16 Neal Frager via buildroot
2025-03-27 11:16 ` [Buildroot] [PATCH v4 2/3] toolchain/toolchain-bare-metal-buildroot: rename example " Neal Frager via buildroot
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Neal Frager via buildroot @ 2025-03-27 11:16 UTC (permalink / raw)
To: buildroot
Cc: ibai.erkiaga-elorza, luca.ceresoli, brandon.maier, ju.o,
thomas.petazzoni, Neal Frager, romain.naour, michal.simek
This patch renames the bare-metal toolchain vendor used by the
xilinx-embeddedsw package from Xilinx to Buildroot to be consistent with all
other toolchains built by Buildroot.
To build the Microblaze applications available with the xilinx-embeddedsw
package, the following config is now needed:
BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
This change keeps backwards compatibility for users already using the
following architecture tuple:
BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
Either vendor name is now valid, but the documentation will describe using
the Buildroot vendor name.
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V2:
- xilinx-embeddedsw is now backwards compatible with either vendor name
V2->V3:
- split patch into series
V3->V4:
- rebase patch
---
boot/xilinx-embeddedsw/Config.in | 3 ++-
boot/xilinx-embeddedsw/xilinx-embeddedsw.mk | 26 ++++++++++++++-------
2 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/boot/xilinx-embeddedsw/Config.in b/boot/xilinx-embeddedsw/Config.in
index a27253d594..31b12baaf2 100644
--- a/boot/xilinx-embeddedsw/Config.in
+++ b/boot/xilinx-embeddedsw/Config.in
@@ -1,4 +1,5 @@
-comment "xilinx-embeddedsw needs a bare metal toolchain for tuple microblazeel-xilinx-elf"
+comment "xilinx-embeddedsw needs a bare metal toolchain for tuple microblazeel-buildroot-elf"
+ depends on BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH != "microblazeel-buildroot-elf"
depends on BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH != "microblazeel-xilinx-elf"
menuconfig BR2_TARGET_XILINX_EMBEDDEDSW
diff --git a/boot/xilinx-embeddedsw/xilinx-embeddedsw.mk b/boot/xilinx-embeddedsw/xilinx-embeddedsw.mk
index 7d4fcf8b8f..eff015bc35 100644
--- a/boot/xilinx-embeddedsw/xilinx-embeddedsw.mk
+++ b/boot/xilinx-embeddedsw/xilinx-embeddedsw.mk
@@ -12,6 +12,14 @@ XILINX_EMBEDDEDSW_INSTALL_TARGET = NO
XILINX_EMBEDDEDSW_INSTALL_IMAGES = YES
XILINX_EMBEDDEDSW_DEPENDENCIES = toolchain-bare-metal-buildroot
+ifneq ("$(wildcard $(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc)","")
+XILINX_EMBEDDEDSW_MICROBLAZE_CC = $(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc
+XILINX_EMBEDDEDSW_MICROBLAZE_AR = $(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc-ar
+else
+XILINX_EMBEDDEDSW_MICROBLAZE_CC = $(HOST_DIR)/bin/microblazeel-buildroot-elf-gcc
+XILINX_EMBEDDEDSW_MICROBLAZE_AR = $(HOST_DIR)/bin/microblazeel-buildroot-elf-gcc-ar
+endif
+
# ZYNQMP_PMUFW application allows users to add cflags
XILINX_EMBEDDEDSW_ZYNQMP_PMUFW_USER_CFLAGS = \
$(call qstrip,$(BR2_TARGET_XILINX_EMBEDDEDSW_ZYNQMP_PMUFW_USER_CFLAGS))
@@ -23,9 +31,9 @@ XILINX_EMBEDDEDSW_CFLAGS = "-Os -flto -ffat-lto-objects"
ifeq ($(BR2_TARGET_XILINX_EMBEDDEDSW_VERSAL_PLM),y)
define XILINX_EMBEDDEDSW_BUILD_VERSAL_PLM
$(MAKE) -C $(@D)/lib/sw_apps/versal_plm/src/versal \
- COMPILER=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc \
- ARCHIVER=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc-ar \
- CC=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc \
+ COMPILER=$(XILINX_EMBEDDEDSW_MICROBLAZE_CC) \
+ ARCHIVER=$(XILINX_EMBEDDEDSW_MICROBLAZE_AR) \
+ CC=$(XILINX_EMBEDDEDSW_MICROBLAZE_CC) \
CFLAGS=$(XILINX_EMBEDDEDSW_CFLAGS)
endef
@@ -38,9 +46,9 @@ endif # BR2_TARGET_XILINX_EMBEDDEDSW_VERSAL_PLM
ifeq ($(BR2_TARGET_XILINX_EMBEDDEDSW_VERSAL_PSMFW),y)
define XILINX_EMBEDDEDSW_BUILD_VERSAL_PSMFW
$(MAKE) -C $(@D)/lib/sw_apps/versal_psmfw/src/versal \
- COMPILER=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc \
- ARCHIVER=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc-ar \
- CC=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc \
+ COMPILER=$(XILINX_EMBEDDEDSW_MICROBLAZE_CC) \
+ ARCHIVER=$(XILINX_EMBEDDEDSW_MICROBLAZE_AR) \
+ CC=$(XILINX_EMBEDDEDSW_MICROBLAZE_CC) \
CFLAGS=$(XILINX_EMBEDDEDSW_CFLAGS)
endef
@@ -53,9 +61,9 @@ endif # BR2_TARGET_XILINX_EMBEDDEDSW_VERSAL_PSMFW
ifeq ($(BR2_TARGET_XILINX_EMBEDDEDSW_ZYNQMP_PMUFW),y)
define XILINX_EMBEDDEDSW_BUILD_ZYNQMP_PMUFW
$(MAKE) -C $(@D)/lib/sw_apps/zynqmp_pmufw/src \
- COMPILER=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc \
- ARCHIVER=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc-ar \
- CC=$(HOST_DIR)/bin/microblazeel-xilinx-elf-gcc \
+ COMPILER=$(XILINX_EMBEDDEDSW_MICROBLAZE_CC) \
+ ARCHIVER=$(XILINX_EMBEDDEDSW_MICROBLAZE_AR) \
+ CC=$(XILINX_EMBEDDEDSW_MICROBLAZE_CC) \
CFLAGS=$(XILINX_EMBEDDEDSW_ZYNQMP_PMUFW_CFLAGS)
endef
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH v4 2/3] toolchain/toolchain-bare-metal-buildroot: rename example vendor to buildroot
2025-03-27 11:16 [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot Neal Frager via buildroot
@ 2025-03-27 11:16 ` Neal Frager via buildroot
2025-03-27 11:16 ` [Buildroot] [PATCH v4 3/3] configs/versal|zynqmp: migrate to microblazeel-buildroot-elf tuple Neal Frager via buildroot
2025-04-08 6:35 ` [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot Luca Ceresoli via buildroot
2 siblings, 0 replies; 7+ messages in thread
From: Neal Frager via buildroot @ 2025-03-27 11:16 UTC (permalink / raw)
To: buildroot
Cc: ibai.erkiaga-elorza, luca.ceresoli, brandon.maier, ju.o,
thomas.petazzoni, Neal Frager, romain.naour, michal.simek
Now that xilinx-embeddedsw is compatible with the toolchain vendor buildroot,
this patch modifies the toolchain-bare-metal-buildroot help example to use
the microblazeel-buildroot-elf tuple.
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V3:
- new to series with V3
V3->V4:
- no changes
---
toolchain/toolchain-bare-metal-buildroot/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toolchain/toolchain-bare-metal-buildroot/Config.in b/toolchain/toolchain-bare-metal-buildroot/Config.in
index c86c5d725c..19c97410c6 100644
--- a/toolchain/toolchain-bare-metal-buildroot/Config.in
+++ b/toolchain/toolchain-bare-metal-buildroot/Config.in
@@ -10,7 +10,7 @@ config BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH
For example, to build both a Microblaze and a RISC-V bare
metal toolchain, use the following definition:
- "microblazeel-xilinx-elf riscv32-buldroot-elf"
+ "microblazeel-buildroot-elf riscv32-buildroot-elf"
source "package/newlib-bare-metal/Config.in"
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v4 3/3] configs/versal|zynqmp: migrate to microblazeel-buildroot-elf tuple
2025-03-27 11:16 [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot Neal Frager via buildroot
2025-03-27 11:16 ` [Buildroot] [PATCH v4 2/3] toolchain/toolchain-bare-metal-buildroot: rename example " Neal Frager via buildroot
@ 2025-03-27 11:16 ` Neal Frager via buildroot
2025-04-08 6:35 ` [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot Luca Ceresoli via buildroot
2 siblings, 0 replies; 7+ messages in thread
From: Neal Frager via buildroot @ 2025-03-27 11:16 UTC (permalink / raw)
To: buildroot
Cc: ibai.erkiaga-elorza, luca.ceresoli, brandon.maier, ju.o,
thomas.petazzoni, Neal Frager, romain.naour, michal.simek
This patch migrates all the versal and zynqmp defconfigs to use the
microblazeel-buildroot-elf arch tuple for the toolchain-bare-metal-buildroot
toolchain.
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V3:
- new to series with V3
V3->V4:
- no changes
---
configs/versal_vck190_defconfig | 2 +-
configs/versal_vek280_defconfig | 2 +-
configs/versal_vpk180_defconfig | 2 +-
configs/zynqmp_kria_kd240_defconfig | 2 +-
configs/zynqmp_kria_kr260_defconfig | 2 +-
configs/zynqmp_kria_kv260_defconfig | 2 +-
configs/zynqmp_zcu102_defconfig | 2 +-
configs/zynqmp_zcu104_defconfig | 2 +-
configs/zynqmp_zcu106_defconfig | 2 +-
9 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/configs/versal_vck190_defconfig b/configs/versal_vck190_defconfig
index 2f40c210a8..f1b4e15bb5 100644
--- a/configs/versal_vck190_defconfig
+++ b/configs/versal_vck190_defconfig
@@ -2,7 +2,7 @@ BR2_aarch64=y
BR2_cortex_a72=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
BR2_TOOLCHAIN_BARE_METAL_BUILDROOT=y
-BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
+BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
BR2_GLOBAL_PATCH_DIR="board/xilinx/patches"
BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
BR2_ROOTFS_POST_BUILD_SCRIPT="board/versal/post-build.sh"
diff --git a/configs/versal_vek280_defconfig b/configs/versal_vek280_defconfig
index af8bed884f..0b45bad945 100644
--- a/configs/versal_vek280_defconfig
+++ b/configs/versal_vek280_defconfig
@@ -2,7 +2,7 @@ BR2_aarch64=y
BR2_cortex_a72=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
BR2_TOOLCHAIN_BARE_METAL_BUILDROOT=y
-BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
+BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
BR2_GLOBAL_PATCH_DIR="board/versal/vek280/patches board/xilinx/patches"
BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
BR2_ROOTFS_POST_BUILD_SCRIPT="board/versal/post-build.sh"
diff --git a/configs/versal_vpk180_defconfig b/configs/versal_vpk180_defconfig
index afa606ec8c..acad9516ce 100644
--- a/configs/versal_vpk180_defconfig
+++ b/configs/versal_vpk180_defconfig
@@ -2,7 +2,7 @@ BR2_aarch64=y
BR2_cortex_a72=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
BR2_TOOLCHAIN_BARE_METAL_BUILDROOT=y
-BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
+BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
BR2_GLOBAL_PATCH_DIR="board/xilinx/patches"
BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
BR2_ROOTFS_POST_BUILD_SCRIPT="board/versal/post-build.sh"
diff --git a/configs/zynqmp_kria_kd240_defconfig b/configs/zynqmp_kria_kd240_defconfig
index 261b73d6cf..69571a53bd 100644
--- a/configs/zynqmp_kria_kd240_defconfig
+++ b/configs/zynqmp_kria_kd240_defconfig
@@ -1,7 +1,7 @@
BR2_aarch64=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
BR2_TOOLCHAIN_BARE_METAL_BUILDROOT=y
-BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
+BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
BR2_GLOBAL_PATCH_DIR="board/zynqmp/patches board/zynqmp/kria/patches board/xilinx/patches"
BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
BR2_ROOTFS_POST_BUILD_SCRIPT="board/zynqmp/post-build.sh"
diff --git a/configs/zynqmp_kria_kr260_defconfig b/configs/zynqmp_kria_kr260_defconfig
index 2cf2b98aa5..b7b9691fc7 100644
--- a/configs/zynqmp_kria_kr260_defconfig
+++ b/configs/zynqmp_kria_kr260_defconfig
@@ -1,7 +1,7 @@
BR2_aarch64=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
BR2_TOOLCHAIN_BARE_METAL_BUILDROOT=y
-BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
+BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
BR2_GLOBAL_PATCH_DIR="board/zynqmp/patches board/zynqmp/kria/patches board/xilinx/patches"
BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
BR2_ROOTFS_POST_BUILD_SCRIPT="board/zynqmp/post-build.sh"
diff --git a/configs/zynqmp_kria_kv260_defconfig b/configs/zynqmp_kria_kv260_defconfig
index ef6a23f2a2..78d4a882c5 100644
--- a/configs/zynqmp_kria_kv260_defconfig
+++ b/configs/zynqmp_kria_kv260_defconfig
@@ -1,7 +1,7 @@
BR2_aarch64=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
BR2_TOOLCHAIN_BARE_METAL_BUILDROOT=y
-BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
+BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
BR2_GLOBAL_PATCH_DIR="board/zynqmp/patches board/zynqmp/kria/patches board/xilinx/patches"
BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
BR2_ROOTFS_POST_BUILD_SCRIPT="board/zynqmp/post-build.sh"
diff --git a/configs/zynqmp_zcu102_defconfig b/configs/zynqmp_zcu102_defconfig
index 762a54d968..5010aee2dc 100644
--- a/configs/zynqmp_zcu102_defconfig
+++ b/configs/zynqmp_zcu102_defconfig
@@ -1,7 +1,7 @@
BR2_aarch64=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
BR2_TOOLCHAIN_BARE_METAL_BUILDROOT=y
-BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
+BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
BR2_GLOBAL_PATCH_DIR="board/zynqmp/patches board/xilinx/patches"
BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
BR2_ROOTFS_POST_BUILD_SCRIPT="board/zynqmp/post-build.sh"
diff --git a/configs/zynqmp_zcu104_defconfig b/configs/zynqmp_zcu104_defconfig
index 92e0d41736..7352148603 100644
--- a/configs/zynqmp_zcu104_defconfig
+++ b/configs/zynqmp_zcu104_defconfig
@@ -1,7 +1,7 @@
BR2_aarch64=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
BR2_TOOLCHAIN_BARE_METAL_BUILDROOT=y
-BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
+BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
BR2_GLOBAL_PATCH_DIR="board/zynqmp/patches board/xilinx/patches"
BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
BR2_ROOTFS_POST_BUILD_SCRIPT="board/zynqmp/post-build.sh"
diff --git a/configs/zynqmp_zcu106_defconfig b/configs/zynqmp_zcu106_defconfig
index 51287fdffb..b8ec4c983e 100644
--- a/configs/zynqmp_zcu106_defconfig
+++ b/configs/zynqmp_zcu106_defconfig
@@ -1,7 +1,7 @@
BR2_aarch64=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
BR2_TOOLCHAIN_BARE_METAL_BUILDROOT=y
-BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
+BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
BR2_GLOBAL_PATCH_DIR="board/zynqmp/patches board/xilinx/patches"
BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
BR2_ROOTFS_POST_BUILD_SCRIPT="board/zynqmp/post-build.sh"
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot
2025-03-27 11:16 [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot Neal Frager via buildroot
2025-03-27 11:16 ` [Buildroot] [PATCH v4 2/3] toolchain/toolchain-bare-metal-buildroot: rename example " Neal Frager via buildroot
2025-03-27 11:16 ` [Buildroot] [PATCH v4 3/3] configs/versal|zynqmp: migrate to microblazeel-buildroot-elf tuple Neal Frager via buildroot
@ 2025-04-08 6:35 ` Luca Ceresoli via buildroot
2025-04-08 6:40 ` Frager, Neal via buildroot
2 siblings, 1 reply; 7+ messages in thread
From: Luca Ceresoli via buildroot @ 2025-04-08 6:35 UTC (permalink / raw)
To: Neal Frager
Cc: ibai.erkiaga-elorza, arnout, brandon.maier, ju.o,
thomas.petazzoni, buildroot, romain.naour, michal.simek
Hi Neal,
On Thu, 27 Mar 2025 11:16:43 +0000
Neal Frager <neal.frager@amd.com> wrote:
> This patch renames the bare-metal toolchain vendor used by the
> xilinx-embeddedsw package from Xilinx to Buildroot to be consistent with all
> other toolchains built by Buildroot.
>
> To build the Microblaze applications available with the xilinx-embeddedsw
> package, the following config is now needed:
>
> BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
>
> This change keeps backwards compatibility for users already using the
> following architecture tuple:
>
> BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
>
> Either vendor name is now valid, but the documentation will describe using
> the Buildroot vendor name.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
I don't have a strong opinion about this series. Definitely the
"buildroot" vendor name is more appropriate than "xilinx", and the
patches look clean enough, but I'll let the maintainers decide whether
it's worth the extra effort.
If this is accepted, however, I think we should remove the "xilinx"
vendor support after 1y~1.5y and not carry the maintenance burden
indefinitely. Do you think this can be handled by Config.in.legacy, so
in the transition phase users of the old tuple are notified?
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot
2025-04-08 6:35 ` [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot Luca Ceresoli via buildroot
@ 2025-04-08 6:40 ` Frager, Neal via buildroot
2025-04-08 10:09 ` Luca Ceresoli via buildroot
0 siblings, 1 reply; 7+ messages in thread
From: Frager, Neal via buildroot @ 2025-04-08 6:40 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Erkiaga Elorza, Ibai, arnout@mind.be, brandon.maier@collins.com,
ju.o@free.fr, thomas.petazzoni@bootlin.com,
buildroot@buildroot.org, romain.naour@smile.fr, Simek, Michal
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Luca,
> This patch renames the bare-metal toolchain vendor used by the
> xilinx-embeddedsw package from Xilinx to Buildroot to be consistent with all
> other toolchains built by Buildroot.
>
> To build the Microblaze applications available with the xilinx-embeddedsw
> package, the following config is now needed:
>
> BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
>
> This change keeps backwards compatibility for users already using the
> following architecture tuple:
>
> BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
>
> Either vendor name is now valid, but the documentation will describe using
> the Buildroot vendor name.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> I don't have a strong opinion about this series. Definitely the
> "buildroot" vendor name is more appropriate than "xilinx", and the
> patches look clean enough, but I'll let the maintainers decide whether
> it's worth the extra effort.
> If this is accepted, however, I think we should remove the "xilinx"
> vendor support after 1y~1.5y and not carry the maintenance burden
> indefinitely. Do you think this can be handled by Config.in.legacy, so
> in the transition phase users of the old tuple are notified?
Yes, I agree with this. Probably the sooner we transition over the better,
in order to limit the number of users of the xilinx vendor name.
Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot
2025-04-08 6:40 ` Frager, Neal via buildroot
@ 2025-04-08 10:09 ` Luca Ceresoli via buildroot
2025-04-08 12:19 ` Frager, Neal via buildroot
0 siblings, 1 reply; 7+ messages in thread
From: Luca Ceresoli via buildroot @ 2025-04-08 10:09 UTC (permalink / raw)
To: Frager, Neal
Cc: Erkiaga Elorza, Ibai, arnout@mind.be, brandon.maier@collins.com,
ju.o@free.fr, thomas.petazzoni@bootlin.com,
buildroot@buildroot.org, romain.naour@smile.fr, Simek, Michal
On Tue, 8 Apr 2025 06:40:55 +0000
"Frager, Neal" <neal.frager@amd.com> wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi Luca,
>
> > This patch renames the bare-metal toolchain vendor used by the
> > xilinx-embeddedsw package from Xilinx to Buildroot to be consistent with all
> > other toolchains built by Buildroot.
> >
> > To build the Microblaze applications available with the xilinx-embeddedsw
> > package, the following config is now needed:
> >
> > BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
> >
> > This change keeps backwards compatibility for users already using the
> > following architecture tuple:
> >
> > BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
> >
> > Either vendor name is now valid, but the documentation will describe using
> > the Buildroot vendor name.
> >
> > Signed-off-by: Neal Frager <neal.frager@amd.com>
>
> > I don't have a strong opinion about this series. Definitely the
> > "buildroot" vendor name is more appropriate than "xilinx", and the
> > patches look clean enough, but I'll let the maintainers decide whether
> > it's worth the extra effort.
>
> > If this is accepted, however, I think we should remove the "xilinx"
> > vendor support after 1y~1.5y and not carry the maintenance burden
> > indefinitely. Do you think this can be handled by Config.in.legacy, so
> > in the transition phase users of the old tuple are notified?
>
> Yes, I agree with this. Probably the sooner we transition over the better,
> in order to limit the number of users of the xilinx vendor name.
I don't think the number of users is very relevant, and we cannot
control or even know that anyway. If a kconfig value was valid in a
Buildroot release, then we need to handle the transition before it is
made invalid.
Config.in.legacy is the primary tool for this, but I'm not sure it will
work for this specific change which is not removing a kconfig symbol
but rather one of the possible entries within its value.
Maybe you could emit a warning in case the old vendor string is used,
suggesting to switch to the new vendor string, and after 1y+ make it an
error.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot
2025-04-08 10:09 ` Luca Ceresoli via buildroot
@ 2025-04-08 12:19 ` Frager, Neal via buildroot
0 siblings, 0 replies; 7+ messages in thread
From: Frager, Neal via buildroot @ 2025-04-08 12:19 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Erkiaga Elorza, Ibai, arnout@mind.be, brandon.maier@collins.com,
ju.o@free.fr, thomas.petazzoni@bootlin.com,
buildroot@buildroot.org, romain.naour@smile.fr, Simek, Michal
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Luca,
>
> Hi Luca,
>
> > This patch renames the bare-metal toolchain vendor used by the
> > xilinx-embeddedsw package from Xilinx to Buildroot to be consistent with all
> > other toolchains built by Buildroot.
> >
> > To build the Microblaze applications available with the xilinx-embeddedsw
> > package, the following config is now needed:
> >
> > BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-buildroot-elf"
> >
> > This change keeps backwards compatibility for users already using the
> > following architecture tuple:
> >
> > BR2_TOOLCHAIN_BARE_METAL_BUILDROOT_ARCH="microblazeel-xilinx-elf"
> >
> > Either vendor name is now valid, but the documentation will describe using
> > the Buildroot vendor name.
> >
> > Signed-off-by: Neal Frager <neal.frager@amd.com>
>
> > I don't have a strong opinion about this series. Definitely the
> > "buildroot" vendor name is more appropriate than "xilinx", and the
> > patches look clean enough, but I'll let the maintainers decide whether
> > it's worth the extra effort.
>
> > If this is accepted, however, I think we should remove the "xilinx"
> > vendor support after 1y~1.5y and not carry the maintenance burden
> > indefinitely. Do you think this can be handled by Config.in.legacy, so
> > in the transition phase users of the old tuple are notified?
>
> Yes, I agree with this. Probably the sooner we transition over the better,
> in order to limit the number of users of the xilinx vendor name.
> I don't think the number of users is very relevant, and we cannot
> control or even know that anyway. If a kconfig value was valid in a
> Buildroot release, then we need to handle the transition before it is
> made invalid.
> Config.in.legacy is the primary tool for this, but I'm not sure it will
> work for this specific change which is not removing a kconfig symbol
> but rather one of the possible entries within its value.
Good point. Yes, I agree.
> Maybe you could emit a warning in case the old vendor string is used,
> suggesting to switch to the new vendor string, and after 1y+ make it an
> error.
Yes, I could already add a build time warning message with v5 that emits
whenever someone uses the xilinx vendor name. This is a good idea.
Would it be standard practice to add a deprecation date in this warning
message?
Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-04-08 12:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-27 11:16 [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot Neal Frager via buildroot
2025-03-27 11:16 ` [Buildroot] [PATCH v4 2/3] toolchain/toolchain-bare-metal-buildroot: rename example " Neal Frager via buildroot
2025-03-27 11:16 ` [Buildroot] [PATCH v4 3/3] configs/versal|zynqmp: migrate to microblazeel-buildroot-elf tuple Neal Frager via buildroot
2025-04-08 6:35 ` [Buildroot] [PATCH v4 1/3] boot/xilinx-embeddedsw: rename toolchain vendor to buildroot Luca Ceresoli via buildroot
2025-04-08 6:40 ` Frager, Neal via buildroot
2025-04-08 10:09 ` Luca Ceresoli via buildroot
2025-04-08 12:19 ` Frager, Neal via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.