* [RESEND PATCH] scsi: hpsa: Use str_enabled_disabled() helper function
@ 2025-04-11 8:47 Thorsten Blum
0 siblings, 0 replies; only message in thread
From: Thorsten Blum @ 2025-04-11 8:47 UTC (permalink / raw)
To: Don Brace, James E.J. Bottomley, Martin K. Petersen
Cc: Thorsten Blum, storagedev, linux-scsi, linux-kernel
Remove hard-coded strings by using the str_enabled_disabled() helper
function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/scsi/hpsa.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index c73a71ac3c29..c190412ad9fc 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -36,6 +36,7 @@
#include <linux/dma-mapping.h>
#include <linux/completion.h>
#include <linux/moduleparam.h>
+#include <linux/string_choices.h>
#include <scsi/scsi.h>
#include <scsi/scsi_cmnd.h>
#include <scsi/scsi_device.h>
@@ -465,7 +466,7 @@ static ssize_t host_store_hp_ssd_smart_path_status(struct device *dev,
h->acciopath_status = !!status;
dev_warn(&h->pdev->dev,
"hpsa: HP SSD Smart Path %s via sysfs update.\n",
- h->acciopath_status ? "enabled" : "disabled");
+ str_enabled_disabled(h->acciopath_status));
return count;
}
@@ -552,7 +553,7 @@ static ssize_t host_show_hp_ssd_smart_path_status(struct device *dev,
h = shost_to_hba(shost);
return snprintf(buf, 30, "HP SSD Smart Path %s\n",
- (h->acciopath_status == 1) ? "enabled" : "disabled");
+ str_enabled_disabled(h->acciopath_status == 1));
}
/* List of controllers which cannot be hard reset on kexec with reset_devices */
--
2.49.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-04-11 8:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-11 8:47 [RESEND PATCH] scsi: hpsa: Use str_enabled_disabled() helper function Thorsten Blum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.