From: Enrico Zanda <e.zanda1@gmail.com>
To: linux-i2c@vger.kernel.org
Cc: andi.shyti@kernel.org, Enrico Zanda <e.zanda1@gmail.com>
Subject: [PATCH 05/10] i2c: viapro: Replace dev_err() with dev_err_probe() in probe function
Date: Tue, 15 Apr 2025 20:34:42 +0200 [thread overview]
Message-ID: <20250415183447.396277-6-e.zanda1@gmail.com> (raw)
In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com>
This simplifies the code while improving log.
Signed-off-by: Enrico Zanda <e.zanda1@gmail.com>
---
drivers/i2c/busses/i2c-viapro.c | 33 +++++++++++++++------------------
1 file changed, 15 insertions(+), 18 deletions(-)
diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c
index 2cc7bba3b8bf..c58843609107 100644
--- a/drivers/i2c/busses/i2c-viapro.c
+++ b/drivers/i2c/busses/i2c-viapro.c
@@ -330,30 +330,27 @@ static int vt596_probe(struct pci_dev *pdev,
SMBHSTCFG = 0x84;
} else {
/* no matches at all */
- dev_err(&pdev->dev, "Cannot configure "
- "SMBus I/O Base address\n");
- return -ENODEV;
+ return dev_err_probe(&pdev->dev, -ENODEV,
+ "Cannot configure "
+ "SMBus I/O Base address\n");
}
}
vt596_smba &= 0xfff0;
- if (vt596_smba == 0) {
- dev_err(&pdev->dev, "SMBus base address "
- "uninitialized - upgrade BIOS or use "
- "force_addr=0xaddr\n");
- return -ENODEV;
- }
+ if (vt596_smba == 0)
+ return dev_err_probe(&pdev->dev, -ENODEV, "SMBus base address "
+ "uninitialized - upgrade BIOS or use "
+ "force_addr=0xaddr\n");
found:
error = acpi_check_region(vt596_smba, 8, vt596_driver.name);
if (error)
return -ENODEV;
- if (!request_region(vt596_smba, 8, vt596_driver.name)) {
- dev_err(&pdev->dev, "SMBus region 0x%x already in use!\n",
- vt596_smba);
- return -ENODEV;
- }
+ if (!request_region(vt596_smba, 8, vt596_driver.name))
+ return dev_err_probe(&pdev->dev, -ENODEV,
+ "SMBus region 0x%x already in use!\n",
+ vt596_smba);
pci_read_config_byte(pdev, SMBHSTCFG, &temp);
/* If force_addr is set, we program the new address here. Just to make
@@ -375,10 +372,10 @@ static int vt596_probe(struct pci_dev *pdev,
pci_write_config_byte(pdev, SMBHSTCFG, temp | 0x01);
dev_info(&pdev->dev, "Enabling SMBus device\n");
} else {
- dev_err(&pdev->dev, "SMBUS: Error: Host SMBus "
- "controller not enabled! - upgrade BIOS or "
- "use force=1\n");
- error = -ENODEV;
+ error = dev_err_probe(&pdev->dev, -ENODEV,
+ "SMBUS: Error: Host SMBus "
+ "controller not enabled! - "
+ "upgrade BIOS or use force=1\n");
goto release_region;
}
}
--
2.43.0
next prev parent reply other threads:[~2025-04-15 18:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 18:34 [PATCH 00/10] i2c: Replace dev_err() with dev_err_probe() Enrico Zanda
2025-04-15 18:34 ` [PATCH 01/10] i2c: uniphier(-f): Replace dev_err() with dev_err_probe() in probe function Enrico Zanda
2025-04-15 18:34 ` [PATCH 02/10] i2c: uniphier: " Enrico Zanda
2025-04-15 18:34 ` [PATCH 03/10] i2c: via: " Enrico Zanda
2025-04-16 20:44 ` Andi Shyti
2025-04-15 18:34 ` [PATCH 04/10] i2c: viai2c-wmt: " Enrico Zanda
2025-04-16 20:42 ` Andi Shyti
2025-05-13 21:00 ` Enrico Zanda
2025-04-15 18:34 ` Enrico Zanda [this message]
2025-04-16 21:12 ` [PATCH 05/10] i2c: viapro: " Andi Shyti
2025-04-15 18:34 ` [PATCH 06/10] i2c: viperboard: " Enrico Zanda
2025-04-15 18:34 ` [PATCH 07/10] i2c: virtio: " Enrico Zanda
2025-04-15 18:34 ` [PATCH 08/10] i2c: xgene-slimpro: " Enrico Zanda
2025-04-16 21:19 ` Andi Shyti
2025-05-11 19:55 ` Enrico Zanda
2025-04-15 18:34 ` [PATCH 09/10] i2c: i2c-xiic: " Enrico Zanda
2025-04-15 18:34 ` [PATCH 10/10] i2c: scx200_acb: " Enrico Zanda
2025-04-16 21:49 ` [PATCH 00/10] i2c: Replace dev_err() with dev_err_probe() Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415183447.396277-6-e.zanda1@gmail.com \
--to=e.zanda1@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.