From: Enrico Zanda <e.zanda1@gmail.com>
To: linux-i2c@vger.kernel.org
Cc: andi.shyti@kernel.org, Enrico Zanda <e.zanda1@gmail.com>
Subject: [PATCH 07/10] i2c: virtio: Replace dev_err() with dev_err_probe() in probe function
Date: Tue, 15 Apr 2025 20:34:44 +0200 [thread overview]
Message-ID: <20250415183447.396277-8-e.zanda1@gmail.com> (raw)
In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com>
This simplifies the code while improving log.
Signed-off-by: Enrico Zanda <e.zanda1@gmail.com>
---
drivers/i2c/busses/i2c-virtio.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-virtio.c b/drivers/i2c/busses/i2c-virtio.c
index 2a351f961b89..9b05ff53d3d7 100644
--- a/drivers/i2c/busses/i2c-virtio.c
+++ b/drivers/i2c/busses/i2c-virtio.c
@@ -192,10 +192,9 @@ static int virtio_i2c_probe(struct virtio_device *vdev)
struct virtio_i2c *vi;
int ret;
- if (!virtio_has_feature(vdev, VIRTIO_I2C_F_ZERO_LENGTH_REQUEST)) {
- dev_err(&vdev->dev, "Zero-length request feature is mandatory\n");
- return -EINVAL;
- }
+ if (!virtio_has_feature(vdev, VIRTIO_I2C_F_ZERO_LENGTH_REQUEST))
+ return dev_err_probe(&vdev->dev, -EINVAL,
+ "Zero-length request feature is mandatory\n");
vi = devm_kzalloc(&vdev->dev, sizeof(*vi), GFP_KERNEL);
if (!vi)
--
2.43.0
next prev parent reply other threads:[~2025-04-15 18:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 18:34 [PATCH 00/10] i2c: Replace dev_err() with dev_err_probe() Enrico Zanda
2025-04-15 18:34 ` [PATCH 01/10] i2c: uniphier(-f): Replace dev_err() with dev_err_probe() in probe function Enrico Zanda
2025-04-15 18:34 ` [PATCH 02/10] i2c: uniphier: " Enrico Zanda
2025-04-15 18:34 ` [PATCH 03/10] i2c: via: " Enrico Zanda
2025-04-16 20:44 ` Andi Shyti
2025-04-15 18:34 ` [PATCH 04/10] i2c: viai2c-wmt: " Enrico Zanda
2025-04-16 20:42 ` Andi Shyti
2025-05-13 21:00 ` Enrico Zanda
2025-04-15 18:34 ` [PATCH 05/10] i2c: viapro: " Enrico Zanda
2025-04-16 21:12 ` Andi Shyti
2025-04-15 18:34 ` [PATCH 06/10] i2c: viperboard: " Enrico Zanda
2025-04-15 18:34 ` Enrico Zanda [this message]
2025-04-15 18:34 ` [PATCH 08/10] i2c: xgene-slimpro: " Enrico Zanda
2025-04-16 21:19 ` Andi Shyti
2025-05-11 19:55 ` Enrico Zanda
2025-04-15 18:34 ` [PATCH 09/10] i2c: i2c-xiic: " Enrico Zanda
2025-04-15 18:34 ` [PATCH 10/10] i2c: scx200_acb: " Enrico Zanda
2025-04-16 21:49 ` [PATCH 00/10] i2c: Replace dev_err() with dev_err_probe() Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415183447.396277-8-e.zanda1@gmail.com \
--to=e.zanda1@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.