From: Chen Linxuan <chenlinxuan@uniontech.com>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Andrew Morton <akpm@linux-foundation.org>,
Yishai Hadas <yishaih@nvidia.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Kevin Tian <kevin.tian@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, kvm@vger.kernel.org,
virtualization@lists.linux.dev, linux-integrity@vger.kernel.org,
linux-kbuild@vger.kernel.org, llvm@lists.linux.dev,
Winston Wen <wentao@uniontech.com>,
Chen Linxuan <chenlinxuan@uniontech.com>,
Changbin Du <changbin.du@intel.com>
Subject: [PATCH RFC v2 5/5] lib/Kconfig.debug: introduce CONFIG_NO_AUTO_INLINE
Date: Wed, 16 Apr 2025 17:44:51 +0800 [thread overview]
Message-ID: <20250416-noautoinline-v2-5-e69a2717530f@uniontech.com> (raw)
In-Reply-To: <20250416-noautoinline-v2-0-e69a2717530f@uniontech.com>
From: Winston Wen <wentao@uniontech.com>
Add a new kernel hacking option CONFIG_NO_AUTO_INLINE that prevents the
compiler from auto-inlining functions not explicitly marked with the
'inline' keyword.
This enhancement improves function tracer capabilities as it can only
trace functions that haven't been inlined by the compiler.
Previous discussions:
Link: https://lore.kernel.org/all/20181028130945.23581-3-changbin.du@gmail.com/
This patch is modified from commit 917fad29febd ("kernel hacking: add a
config option to disable compiler auto-inlining") which can be founded
in linux-next-history:
Link: https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next-history.git/commit/?id=917fad29febd
Unlike the original implementation, this patch:
1. Make it depends on CC_IS_GCC,
as Clang 18.1.3 break test_bitmap_const_eval() in lib/test_bitmap.c
2. Make it depends on X86 and LOONGARCH,
as I haven't test other architectures
3. Removes unnecessary cc-option checks per commit 7d73c3e9c514
("Makefile: remove stale cc-option checks").
4. Update help information.
Cc: Changbin Du <changbin.du@gmail.com>
Co-developed-by: Chen Linxuan <chenlinxuan@uniontech.com>
Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
Signed-off-by: Winston Wen <wentao@uniontech.com>
---
Makefile | 6 ++++++
lib/Kconfig.debug | 15 +++++++++++++++
2 files changed, 21 insertions(+)
diff --git a/Makefile b/Makefile
index c91afd55099ea6bc7ed89bc3ef9cf58a498596d4..52da2c27f94167d2d2892a67c065e5df15efbde0 100644
--- a/Makefile
+++ b/Makefile
@@ -1071,6 +1071,12 @@ endif
# Ensure compilers do not transform certain loops into calls to wcslen()
KBUILD_CFLAGS += -fno-builtin-wcslen
+ifdef CONFIG_NO_AUTO_INLINE
+KBUILD_CFLAGS += -fno-inline-functions \
+ -fno-inline-small-functions \
+ -fno-inline-functions-called-once
+endif
+
# change __FILE__ to the relative path to the source directory
ifdef building_out_of_srctree
KBUILD_CPPFLAGS += $(call cc-option,-ffile-prefix-map=$(srcroot)/=)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 9fe4d8dfe5782981cc0b2b6614106aac570bd229..2ebb4802886ab4a48841dbdd8973b7d9883548b9 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -436,8 +436,23 @@ config GDB_SCRIPTS
instance. See Documentation/process/debugging/gdb-kernel-debugging.rst
for further details.
+
endif # DEBUG_INFO
+config NO_AUTO_INLINE
+ bool "Disable compiler auto-inline optimizations (EXPERIMENTAL)"
+ default n
+ depends on CC_IS_GCC && (X86 || LOONGARCH)
+ help
+ This will prevent the compiler from optimizing the kernel by
+ auto-inlining functions not marked with the inline keyword.
+ With this option, only functions explicitly marked with
+ "inline" will be inlined. This will allow the function tracer
+ to trace more functions because it only traces functions that
+ the compiler has not inlined.
+
+ If unsure, select N.
+
config FRAME_WARN
int "Warn for stack frames larger than"
range 0 8192
--
2.48.1
WARNING: multiple messages have this Message-ID (diff)
From: Chen Linxuan via B4 Relay <devnull+chenlinxuan.uniontech.com@kernel.org>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Andrew Morton <akpm@linux-foundation.org>,
Yishai Hadas <yishaih@nvidia.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Kevin Tian <kevin.tian@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, kvm@vger.kernel.org,
virtualization@lists.linux.dev, linux-integrity@vger.kernel.org,
linux-kbuild@vger.kernel.org, llvm@lists.linux.dev,
Winston Wen <wentao@uniontech.com>,
Chen Linxuan <chenlinxuan@uniontech.com>,
Changbin Du <changbin.du@intel.com>
Subject: [PATCH RFC v2 5/5] lib/Kconfig.debug: introduce CONFIG_NO_AUTO_INLINE
Date: Wed, 16 Apr 2025 17:44:51 +0800 [thread overview]
Message-ID: <20250416-noautoinline-v2-5-e69a2717530f@uniontech.com> (raw)
In-Reply-To: <20250416-noautoinline-v2-0-e69a2717530f@uniontech.com>
From: Winston Wen <wentao@uniontech.com>
Add a new kernel hacking option CONFIG_NO_AUTO_INLINE that prevents the
compiler from auto-inlining functions not explicitly marked with the
'inline' keyword.
This enhancement improves function tracer capabilities as it can only
trace functions that haven't been inlined by the compiler.
Previous discussions:
Link: https://lore.kernel.org/all/20181028130945.23581-3-changbin.du@gmail.com/
This patch is modified from commit 917fad29febd ("kernel hacking: add a
config option to disable compiler auto-inlining") which can be founded
in linux-next-history:
Link: https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next-history.git/commit/?id=917fad29febd
Unlike the original implementation, this patch:
1. Make it depends on CC_IS_GCC,
as Clang 18.1.3 break test_bitmap_const_eval() in lib/test_bitmap.c
2. Make it depends on X86 and LOONGARCH,
as I haven't test other architectures
3. Removes unnecessary cc-option checks per commit 7d73c3e9c514
("Makefile: remove stale cc-option checks").
4. Update help information.
Cc: Changbin Du <changbin.du@gmail.com>
Co-developed-by: Chen Linxuan <chenlinxuan@uniontech.com>
Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
Signed-off-by: Winston Wen <wentao@uniontech.com>
---
Makefile | 6 ++++++
lib/Kconfig.debug | 15 +++++++++++++++
2 files changed, 21 insertions(+)
diff --git a/Makefile b/Makefile
index c91afd55099ea6bc7ed89bc3ef9cf58a498596d4..52da2c27f94167d2d2892a67c065e5df15efbde0 100644
--- a/Makefile
+++ b/Makefile
@@ -1071,6 +1071,12 @@ endif
# Ensure compilers do not transform certain loops into calls to wcslen()
KBUILD_CFLAGS += -fno-builtin-wcslen
+ifdef CONFIG_NO_AUTO_INLINE
+KBUILD_CFLAGS += -fno-inline-functions \
+ -fno-inline-small-functions \
+ -fno-inline-functions-called-once
+endif
+
# change __FILE__ to the relative path to the source directory
ifdef building_out_of_srctree
KBUILD_CPPFLAGS += $(call cc-option,-ffile-prefix-map=$(srcroot)/=)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 9fe4d8dfe5782981cc0b2b6614106aac570bd229..2ebb4802886ab4a48841dbdd8973b7d9883548b9 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -436,8 +436,23 @@ config GDB_SCRIPTS
instance. See Documentation/process/debugging/gdb-kernel-debugging.rst
for further details.
+
endif # DEBUG_INFO
+config NO_AUTO_INLINE
+ bool "Disable compiler auto-inline optimizations (EXPERIMENTAL)"
+ default n
+ depends on CC_IS_GCC && (X86 || LOONGARCH)
+ help
+ This will prevent the compiler from optimizing the kernel by
+ auto-inlining functions not marked with the inline keyword.
+ With this option, only functions explicitly marked with
+ "inline" will be inlined. This will allow the function tracer
+ to trace more functions because it only traces functions that
+ the compiler has not inlined.
+
+ If unsure, select N.
+
config FRAME_WARN
int "Warn for stack frames larger than"
range 0 8192
--
2.48.1
next prev parent reply other threads:[~2025-04-16 9:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 9:44 [PATCH RFC v2 0/5] kernel-hacking: introduce CONFIG_NO_AUTO_INLINE Chen Linxuan
2025-04-16 9:44 ` Chen Linxuan via B4 Relay
2025-04-16 9:44 ` [PATCH RFC v2 1/5] nvme: add __always_inline for nvme_pci_npages_prp Chen Linxuan
2025-04-16 9:44 ` Chen Linxuan via B4 Relay
2025-04-16 9:44 ` [PATCH RFC v2 2/5] mm: add __always_inline for page_contains_unaccepted Chen Linxuan
2025-04-16 9:44 ` Chen Linxuan via B4 Relay
2025-04-16 9:44 ` [PATCH RFC v2 3/5] vfio/virtio: add __always_inline for virtiovf_get_device_config_size Chen Linxuan
2025-04-16 9:44 ` Chen Linxuan via B4 Relay
2025-04-16 9:44 ` [PATCH RFC v2 4/5] tpm: add __always_inline for tpm_is_hwrng_enabled Chen Linxuan
2025-04-16 9:44 ` Chen Linxuan via B4 Relay
2025-04-16 19:34 ` Jarkko Sakkinen
2025-04-16 9:44 ` Chen Linxuan [this message]
2025-04-16 9:44 ` [PATCH RFC v2 5/5] lib/Kconfig.debug: introduce CONFIG_NO_AUTO_INLINE Chen Linxuan via B4 Relay
2025-04-16 16:04 ` Bart Van Assche
2025-04-18 10:24 ` Chen Linxuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416-noautoinline-v2-5-e69a2717530f@uniontech.com \
--to=chenlinxuan@uniontech.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=axboe@kernel.dk \
--cc=changbin.du@intel.com \
--cc=hch@lst.de \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=justinstitt@google.com \
--cc=kbusch@kernel.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvme@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.schier@linux.dev \
--cc=peterhuewe@gmx.de \
--cc=sagi@grimberg.me \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=virtualization@lists.linux.dev \
--cc=wentao@uniontech.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.