Re: [LTP] [PATCH 1/1] cgroup_lib.sh: Improve error messages

[Petr Vorel <pvorel@suse.cz>]

Hi Li,

> > +++ b/testcases/kernel/controllers/cgroup_lib.sh
> > @@ -119,12 +119,12 @@ cgroup_require()
> >         ret=$?

> >         if [ $ret -eq 32 ]; then
> > -               tst_brk TCONF "'tst_cgctl require' exited. Controller is
> > probably not available?"
> > +               tst_brk TCONF "'tst_cgctl require $ctrl' exited. $ctrl
> > controller not available?"


> s/exited/existed

I understood that "exited" which was used previously was meant to be "exited
with non-zero" (I can improve it this way to be more precise). Do you really
think it's in TCONF related to controller existed?  I actually mean the opposite
- one wants controller which does not exist due not configured in the kernel.

Kind regards,
Petr


> >                 return $ret
> >         fi

> >         if [ $ret -ne 0 ]; then
> > -               tst_brk TBROK "'tst_cgctl require' exited"
> > +               tst_brk TBROK "'tst_cgctl require $ctrl' failed. LTP
> > missing $ctrl controller support?"
> >                 return $ret
> >         fi

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp