From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
"Tomasz Duszynski" <tduszyns@gmail.com>,
"Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
"Andreas Klinger" <ak@it-klinger.de>,
"Petre Rodan" <petre.rodan@subdimension.ro>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 8/8] iio: pressure: mprls0025pa: use aligned_s64 for timestamp
Date: Thu, 17 Apr 2025 18:48:59 +0100 [thread overview]
Message-ID: <20250417184859.000022a3@huawei.com> (raw)
In-Reply-To: <20250417-iio-more-timestamp-alignment-v1-8-eafac1e22318@baylibre.com>
On Thu, 17 Apr 2025 11:52:40 -0500
David Lechner <dlechner@baylibre.com> wrote:
> Follow the pattern of other drivers and use aligned_s64 for the
> timestamp. This will ensure the struct itself it also 8-byte aligned.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> drivers/iio/pressure/mprls0025pa.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/pressure/mprls0025pa.h b/drivers/iio/pressure/mprls0025pa.h
> index 9d5c30afa9d69a6a606662aa7906a76347329cef..9fe9eb35e79d992b2a576e5d0af71113c6c47400 100644
> --- a/drivers/iio/pressure/mprls0025pa.h
> +++ b/drivers/iio/pressure/mprls0025pa.h
> @@ -41,7 +41,7 @@ struct mpr_ops;
> */
> struct mpr_chan {
> s32 pres;
> - s64 ts;
> + aligned_s64 ts;
> };
Whilst you are here, no point in there being a named type for this.
Would you mind just pushing it into the struct mpr_data definition.
Might be a bug (I can't be bothered to work out the structure padding
to see if we end up with a gap after this) so fixes tag appropriate for
this one I think.
>
> enum mpr_func_id {
>
next prev parent reply other threads:[~2025-04-17 18:16 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 16:52 [PATCH 0/8] iio: more timestamp alignment David Lechner
2025-04-17 16:52 ` [PATCH 1/8] iio: adc: dln2-adc: use aligned_s64 for timestamp David Lechner
2025-04-17 17:28 ` Jonathan Cameron
2025-04-18 8:58 ` Nuno Sá
2025-04-18 14:44 ` Jonathan Cameron
2025-04-17 16:52 ` [PATCH 2/8] iio: adc: mt6360-adc: " David Lechner
2025-04-18 8:57 ` Nuno Sá
2025-04-18 14:45 ` Jonathan Cameron
2025-04-17 16:52 ` [PATCH 3/8] iio: addac: ad74413r: " David Lechner
2025-04-18 8:57 ` Nuno Sá
2025-04-18 14:46 ` Jonathan Cameron
2025-04-17 16:52 ` [PATCH 4/8] iio: chemical: pms7003: " David Lechner
2025-04-17 17:35 ` Jonathan Cameron
2025-04-18 8:51 ` Nuno Sá
2025-04-18 14:51 ` Jonathan Cameron
2025-04-18 8:58 ` Nuno Sá
2025-04-17 16:52 ` [PATCH 5/8] iio: chemical: sps30: " David Lechner
2025-04-17 17:36 ` Jonathan Cameron
2025-04-18 14:53 ` Jonathan Cameron
2025-04-18 8:58 ` Nuno Sá
2025-04-17 16:52 ` [PATCH 6/8] iio: imu: adis16550: align buffers " David Lechner
2025-04-17 16:59 ` Andy Shevchenko
2025-04-17 17:07 ` David Lechner
2025-04-17 17:44 ` Jonathan Cameron
2025-04-17 20:48 ` David Lechner
2025-04-18 9:17 ` Nuno Sá
2025-04-18 14:55 ` Jonathan Cameron
2025-04-17 16:52 ` [PATCH 7/8] iio: imu: inv_mpu6050: align buffer " David Lechner
2025-04-17 17:00 ` Andy Shevchenko
2025-04-17 17:46 ` Jonathan Cameron
2025-04-18 11:26 ` Jean-Baptiste Maneyrol
2025-04-18 15:02 ` Jonathan Cameron
2025-04-18 15:09 ` Jonathan Cameron
2025-04-17 16:52 ` [PATCH 8/8] iio: pressure: mprls0025pa: use aligned_s64 " David Lechner
2025-04-17 17:48 ` Jonathan Cameron [this message]
2025-04-18 9:00 ` Nuno Sá
2025-04-17 17:01 ` [PATCH 0/8] iio: more timestamp alignment Andy Shevchenko
2025-04-17 17:16 ` David Lechner
2025-04-17 17:24 ` Andy Shevchenko
2025-04-17 17:47 ` Jonathan Cameron
2025-04-17 18:05 ` Andy Shevchenko
2025-04-18 14:57 ` Jonathan Cameron
2025-04-17 17:30 ` Jonathan Cameron
2025-04-18 15:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417184859.000022a3@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=cosmin.tanislav@analog.com \
--cc=dlechner@baylibre.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.