All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] arm-bsp/external-system: correct whitespace warning
@ 2025-04-18 13:10 Jon Mason
  2025-04-18 13:10 ` [PATCH 2/3] arm/tclibc: add spaces after TCLIBC Jon Mason
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jon Mason @ 2025-04-18 13:10 UTC (permalink / raw)
  To: meta-arm

Seeing the following warning:
WARNING: /builds/jonmason00/meta-arm/work/build/../../meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb: /builds/jonmason00/meta-arm/work/build/../../meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb:6 has a lack of whitespace around the assignment: 'INHIBIT_DEFAULT_DEPS="1"'

Adding spaces addresses the issue.

Signed-off-by: Jon Mason <jon.mason@arm.com>
---
 .../recipes-bsp/external-system/external-system_0.1.0.bb        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb b/meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb
index 8bd116163851..1f2d02dfcf8d 100644
--- a/meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb
+++ b/meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb
@@ -3,7 +3,7 @@ DESCRIPTION = "Firmware to be loaded and run in External System Harness in\
                support to the main application CPU."
 HOMEPAGE = "https://git.linaro.org/landing-teams/working/arm/external-system.git"
 DEPENDS = "gcc-arm-none-eabi-native"
-INHIBIT_DEFAULT_DEPS="1"
+INHIBIT_DEFAULT_DEPS = "1"
 LICENSE = "BSD-3-Clause & Apache-2.0"
 LIC_FILES_CHKSUM = "file://license.md;md5=e44b2531cd6ffe9dece394dbe988d9a0 \
                     file://cmsis/LICENSE.txt;md5=e3fc50a88d0a364313df4b21ef20c29e"
-- 
2.39.5 (Apple Git-154)



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] arm/tclibc: add spaces after TCLIBC
  2025-04-18 13:10 [PATCH 1/3] arm-bsp/external-system: correct whitespace warning Jon Mason
@ 2025-04-18 13:10 ` Jon Mason
  2025-04-18 13:10 ` [PATCH 3/3] CI: add spaces to TS_ENV Jon Mason
  2025-04-19  3:15 ` [PATCH 1/3] arm-bsp/external-system: correct whitespace warning Jon Mason
  2 siblings, 0 replies; 4+ messages in thread
From: Jon Mason @ 2025-04-18 13:10 UTC (permalink / raw)
  To: meta-arm

Seeing the warning:
  lack of whitespace around the assignment: 'TCLIBC="musl"'

Add spaces to address the issue

Signed-off-by: Jon Mason <jon.mason@arm.com>
---
 kas/corstone1000-firmware-only.yml      | 2 +-
 meta-arm/conf/multiconfig/firmware.conf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kas/corstone1000-firmware-only.yml b/kas/corstone1000-firmware-only.yml
index 6192a4087234..bc47940b316b 100644
--- a/kas/corstone1000-firmware-only.yml
+++ b/kas/corstone1000-firmware-only.yml
@@ -10,7 +10,7 @@ local_conf_header:
     OVERRIDES .= ":firmware"
 
     # Need to ensure we build with a small libc
-    TCLIBC="musl"
+    TCLIBC = "musl"
 
   mass-storage: |
     # Ensure the Mass Storage device is absent
diff --git a/meta-arm/conf/multiconfig/firmware.conf b/meta-arm/conf/multiconfig/firmware.conf
index 95de4d246792..018c0deb81e5 100644
--- a/meta-arm/conf/multiconfig/firmware.conf
+++ b/meta-arm/conf/multiconfig/firmware.conf
@@ -4,7 +4,7 @@
 DISTROOVERRIDES = "firmware"
 
 TMPDIR:append = "_${MACHINE}"
-TCLIBC="musl"
+TCLIBC = "musl"
 
 # Ignore the testimage flags to include ssh-server-dropbear
 IMAGE_CLASSES:remove = "testimage"
-- 
2.39.5 (Apple Git-154)



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] CI: add spaces to TS_ENV
  2025-04-18 13:10 [PATCH 1/3] arm-bsp/external-system: correct whitespace warning Jon Mason
  2025-04-18 13:10 ` [PATCH 2/3] arm/tclibc: add spaces after TCLIBC Jon Mason
@ 2025-04-18 13:10 ` Jon Mason
  2025-04-19  3:15 ` [PATCH 1/3] arm-bsp/external-system: correct whitespace warning Jon Mason
  2 siblings, 0 replies; 4+ messages in thread
From: Jon Mason @ 2025-04-18 13:10 UTC (permalink / raw)
  To: meta-arm

Seeing the warning:
  lack of whitespace around the assignment: 'TS_ENV="sp"'

Add the spaces to address the issue

Signed-off-by: Jon Mason <jon.mason@arm.com>
---
 ci/fvp-base-ts.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ci/fvp-base-ts.yml b/ci/fvp-base-ts.yml
index ae74334edfe3..9f13bac7f045 100644
--- a/ci/fvp-base-ts.yml
+++ b/ci/fvp-base-ts.yml
@@ -21,7 +21,7 @@ local_conf_header:
     IMAGE_INSTALL:append = " packagegroup-ts-tests-psa"
     CORE_IMAGE_EXTRA_INSTALL += "optee-test"
     # Set the TS environment
-    TS_ENV="sp"
+    TS_ENV = "sp"
     # Enable and configure semihosting
     FVP_CONFIG[cluster0.cpu0.semihosting-cwd] = "${DEPLOY_DIR_IMAGE}"
     FVP_CONFIG[cluster0.cpu1.semihosting-cwd] = "${DEPLOY_DIR_IMAGE}"
-- 
2.39.5 (Apple Git-154)



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] arm-bsp/external-system: correct whitespace warning
  2025-04-18 13:10 [PATCH 1/3] arm-bsp/external-system: correct whitespace warning Jon Mason
  2025-04-18 13:10 ` [PATCH 2/3] arm/tclibc: add spaces after TCLIBC Jon Mason
  2025-04-18 13:10 ` [PATCH 3/3] CI: add spaces to TS_ENV Jon Mason
@ 2025-04-19  3:15 ` Jon Mason
  2 siblings, 0 replies; 4+ messages in thread
From: Jon Mason @ 2025-04-19  3:15 UTC (permalink / raw)
  To: meta-arm, Jon Mason


On Fri, 18 Apr 2025 09:10:00 -0400, Jon Mason wrote:
> Seeing the following warning:
> WARNING: /builds/jonmason00/meta-arm/work/build/../../meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb: /builds/jonmason00/meta-arm/work/build/../../meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb:6 has a lack of whitespace around the assignment: 'INHIBIT_DEFAULT_DEPS="1"'
> 
> Adding spaces addresses the issue.
> 
> 

Applied, thanks!

[1/3] arm-bsp/external-system: correct whitespace warning
      commit: ece994e08bac150e22011762ac1036d6efabe937
[2/3] arm/tclibc: add spaces after TCLIBC
      commit: 3124feab662b4a015402e92f0ed3315426e8666b
[3/3] CI: add spaces to TS_ENV
      commit: 62cb568a652fb13a4f46bbcdd0b2fb1e62475e45

Best regards,
-- 
Jon Mason <jon.mason@arm.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-04-19  3:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-18 13:10 [PATCH 1/3] arm-bsp/external-system: correct whitespace warning Jon Mason
2025-04-18 13:10 ` [PATCH 2/3] arm/tclibc: add spaces after TCLIBC Jon Mason
2025-04-18 13:10 ` [PATCH 3/3] CI: add spaces to TS_ENV Jon Mason
2025-04-19  3:15 ` [PATCH 1/3] arm-bsp/external-system: correct whitespace warning Jon Mason

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.