From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, tariqt@nvidia.com, andrew+netdev@lunn.ch,
horms@kernel.org, donald.hunter@gmail.com,
kalesh-anakkur.purayil@broadcom.com
Subject: Re: [PATCH net-next v3 2/3] devlink: add function unique identifier to devlink dev info
Date: Fri, 18 Apr 2025 17:20:15 -0700 [thread overview]
Message-ID: <20250418172015.7176c3c0@kernel.org> (raw)
In-Reply-To: <o47ap7uhadqrsxpo5uxwv5r2x5uk5zvqrlz36lczake4yvlsat@xx2wmz6rlohi>
On Fri, 18 Apr 2025 12:15:01 +0200 Jiri Pirko wrote:
> Ports does not look suitable to me. In case of a function with multiple
> physical ports, would the same id be listed for multiple ports? What
> about representors?
You're stuck in nVidia thinking. PF port != Ethernet port.
I said PF port.
> This is a function propertly, therefore it makes sense to me to put it
> on devlink instance as devlink instance represents the function.
>
> Another patchset that is most probably follow-up on this by one of my
> colleagues will introduce fuid propertly on "devlink port function".
> By that and the info exposed by this patch, you would be able to identify
> which representor relates to which function cross-hosts. I think that
> your question is actually aiming at this, isn't it?
Maybe it's time to pay off some technical debt instead of solving all
problems with yet another layer of new attributes :(
next prev parent reply other threads:[~2025-04-19 0:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 21:41 [PATCH net-next v3 0/3] net/mlx5: Expose additional devlink dev info Jiri Pirko
2025-04-16 21:41 ` [PATCH net-next v3 1/3] net/mlx5: Expose serial numbers in devlink info Jiri Pirko
2025-04-16 21:41 ` [PATCH net-next v3 2/3] devlink: add function unique identifier to devlink dev info Jiri Pirko
2025-04-18 1:38 ` Jakub Kicinski
2025-04-18 10:15 ` Jiri Pirko
2025-04-19 0:20 ` Jakub Kicinski [this message]
2025-04-22 9:18 ` Jiri Pirko
2025-04-22 15:02 ` Jakub Kicinski
2025-04-23 11:23 ` Jiri Pirko
2025-04-23 22:17 ` Jakub Kicinski
2025-04-24 9:42 ` Jiri Pirko
2025-04-24 22:06 ` Jakub Kicinski
2025-04-25 7:27 ` Jiri Pirko
2025-04-25 20:45 ` Jakub Kicinski
2025-04-28 16:28 ` Jiri Pirko
2025-04-28 18:12 ` Jakub Kicinski
2025-04-29 7:16 ` Jiri Pirko
2025-04-16 21:41 ` [PATCH net-next v3 3/3] net/mlx5: Expose function UID in devlink info Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250418172015.7176c3c0@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.