From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, tariqt@nvidia.com, andrew+netdev@lunn.ch,
horms@kernel.org, donald.hunter@gmail.com,
kalesh-anakkur.purayil@broadcom.com
Subject: Re: [PATCH net-next v3 2/3] devlink: add function unique identifier to devlink dev info
Date: Mon, 28 Apr 2025 11:12:52 -0700 [thread overview]
Message-ID: <20250428111252.62d4309c@kernel.org> (raw)
In-Reply-To: <fx7b7ztzrkvf7dnktqnnzudlrb3jxydqzv2fijeibk7c6cq3xb@hxreseqvu2d2>
On Mon, 28 Apr 2025 18:28:24 +0200 Jiri Pirko wrote:
> >You just need to find a better place to expose the client side.
>
> Okay. Why exactly you find it wrong to put it under devlink dev info?
> I mean, to me it is perfect fit. It is basically another serial number,
> uniqueue identification of devlink device.
>
> If other place is better fit, I don't see it.
devlink instance should represent the device, not a PF / port;
and then having the attribute on the instance does not fit
an eswitch controller with 2 PFs connected.
> Do you have some ideas?
Either subsystem specific (like a netdev attr) or not subsystem
specific (bus dev attr, so PCI). Forcing every endpoint to expose
a devlink instance just for one attribute is too much of a hack.
next prev parent reply other threads:[~2025-04-28 18:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 21:41 [PATCH net-next v3 0/3] net/mlx5: Expose additional devlink dev info Jiri Pirko
2025-04-16 21:41 ` [PATCH net-next v3 1/3] net/mlx5: Expose serial numbers in devlink info Jiri Pirko
2025-04-16 21:41 ` [PATCH net-next v3 2/3] devlink: add function unique identifier to devlink dev info Jiri Pirko
2025-04-18 1:38 ` Jakub Kicinski
2025-04-18 10:15 ` Jiri Pirko
2025-04-19 0:20 ` Jakub Kicinski
2025-04-22 9:18 ` Jiri Pirko
2025-04-22 15:02 ` Jakub Kicinski
2025-04-23 11:23 ` Jiri Pirko
2025-04-23 22:17 ` Jakub Kicinski
2025-04-24 9:42 ` Jiri Pirko
2025-04-24 22:06 ` Jakub Kicinski
2025-04-25 7:27 ` Jiri Pirko
2025-04-25 20:45 ` Jakub Kicinski
2025-04-28 16:28 ` Jiri Pirko
2025-04-28 18:12 ` Jakub Kicinski [this message]
2025-04-29 7:16 ` Jiri Pirko
2025-04-16 21:41 ` [PATCH net-next v3 3/3] net/mlx5: Expose function UID in devlink info Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428111252.62d4309c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.