All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ruben Wauters <rubenru09@aol.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Teddy Wang <teddy.wang@siliconmotion.com>,
	Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>,
	linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] staging: sm750fb: rename sii164_set_power's param
Date: Fri, 18 Apr 2025 12:34:52 +0200	[thread overview]
Message-ID: <2025041825-ranting-dancing-0c86@gregkh> (raw)
In-Reply-To: <20250417190302.13811-6-rubenru09@aol.com>

On Thu, Apr 17, 2025 at 08:02:53PM +0100, Ruben Wauters wrote:
> Renames sii164_set_power's param from powerUp to power
> 
> This fixes checkpatch.pl's camel case check
> 
> Signed-off-by: Ruben Wauters <rubenru09@aol.com>
> ---
>  drivers/staging/sm750fb/ddk750_sii164.c | 6 +++---
>  drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> index 9f660a9be5d6..e2da110fab81 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.c
> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> @@ -262,14 +262,14 @@ char *sii164_get_chip_string(void)
>   *      This function sets the power configuration of the DVI Controller Chip.
>   *
>   *  Input:
> - *      powerUp - Flag to set the power down or up
> + *      power - Flag to set the power down or up

But now we don't know if it's "up" or "down", right?  Why not pick
"power_up"?

And shouldn't this be a boolean, and not an unsigned char?

thanks,

greg k-h

  reply	other threads:[~2025-04-18 10:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250417190302.13811-1-rubenru09.ref@aol.com>
2025-04-17 19:02 ` [PATCH 0/8] staging: sm750fb: cleanup ddk750_sii164 Ruben Wauters
2025-04-17 19:02   ` [PATCH 1/8] staging: sm250fb: remove USE_HW_I2C check Ruben Wauters
2025-04-18 10:33     ` Greg Kroah-Hartman
2025-04-18 11:42       ` Ruben Wauters
2025-04-17 19:02   ` [PATCH 2/8] staging: sm750fb: rename gDviCtrlChipName Ruben Wauters
2025-04-18 10:36     ` Greg Kroah-Hartman
2025-04-18 11:45       ` Ruben Wauters
2025-04-18 12:09         ` Greg Kroah-Hartman
2025-04-17 19:02   ` [PATCH 3/8] staging: sm750fb: rename vendorID to vendor_id Ruben Wauters
2025-04-18 10:37     ` Greg Kroah-Hartman
2025-04-17 19:02   ` [PATCH 4/8] staging: sm750fb: rename sii164_init_chip params Ruben Wauters
2025-04-17 19:02   ` [PATCH 5/8] staging: sm750fb: rename sii164_set_power's param Ruben Wauters
2025-04-18 10:34     ` Greg Kroah-Hartman [this message]
2025-04-17 19:02   ` [PATCH 6/8] staging: sm750fb: rename sii164SelectHotPlugDetectionMode Ruben Wauters
2025-04-17 19:02   ` [PATCH 7/8] staging: sm750fb: rename detectReg to detect_reg Ruben Wauters
2025-04-17 19:02   ` [PATCH 8/8] staging: sm750fb: rename hotPlugValue to hot_plug_value Ruben Wauters
2025-04-18 10:38     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025041825-ranting-dancing-0c86@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=rubenru09@aol.com \
    --cc=sudip.mukherjee@codethink.co.uk \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.