[Buildroot] [PATCH] package/libfuse3: requires THREAD_NPTL

[Buildroot] [PATCH] package/libfuse3: requires THREAD_NPTL

[Giulio Benetti]

With commit:
https://github.com/libfuse/libfuse/commit/43ec53d6a16363184a95e59627c3f54d5568d8d1
pthread_setname_np() has been used and it's part of NPTL, so let's add
a dependency on BR2_TOOLCHAIN_HAS_THREADS_NPTL.

Fixes:
https://autobuild.buildroot.org/results/71299a3db2660084ba362ff7c1b875bd0f71324a

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/libfuse3/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/libfuse3/Config.in b/package/libfuse3/Config.in
index 584d3bf132..73ffc3497c 100644
--- a/package/libfuse3/Config.in
+++ b/package/libfuse3/Config.in
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_LIBFUSE3
 	bool "libfuse3"
 	depends on !BR2_STATIC_LIBS
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # pthread_setname_np()
 	depends on BR2_USE_MMU # fork()
 	help
 	  The reference implementation of the Linux FUSE
@@ -9,6 +9,6 @@ config BR2_PACKAGE_LIBFUSE3
 
 	  https://github.com/libfuse/libfuse
 
-comment "libfuse3 needs a toolchain w/ threads, dynamic library"
+comment "libfuse3 needs a toolchain w/ NPTL, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libfuse3: requires THREAD_NPTL

[Thomas Petazzoni via buildroot]

On Wed, 16 Apr 2025 22:24:08 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> With commit:
> https://github.com/libfuse/libfuse/commit/43ec53d6a16363184a95e59627c3f54d5568d8d1
> pthread_setname_np() has been used and it's part of NPTL, so let's add
> a dependency on BR2_TOOLCHAIN_HAS_THREADS_NPTL.
> 
> Fixes:
> https://autobuild.buildroot.org/results/71299a3db2660084ba362ff7c1b875bd0f71324a
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Thanks for the patch. However, it looks like you forgot to propagate to
reverse dependencies of libfuse3.

Another option is to add some meson.build check for
pthread_setname_np() and only use it when available. Indeed, using this
function is really to give a nice thread name, it isn't strictly
necessary.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot