From: Mario Limonciello <superm1@kernel.org>
To: op-tee@lists.trustedfirmware.org
Subject: [PATCH 1/2] tee: Use pr_fmt for messages
Date: Mon, 21 Apr 2025 10:22:22 -0500 [thread overview]
Message-ID: <20250421152238.764659-2-superm1@kernel.org> (raw)
In-Reply-To: <20250421152238.764659-1-superm1@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1512 bytes --]
From: Mario Limonciello <mario.limonciello@amd.com>
amd-tee inconsistently uses the word amd-tee in error messages.
Add a `pr_fmt()` define and remove the hardcoded use of amd-tee.
Also, remove the unnecessary driver init successful message because
there will be a message if failed and a user can assume it was successful
otherwise.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/tee/amdtee/core.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
index e487231d25dc0..a44625d076401 100644
--- a/drivers/tee/amdtee/core.c
+++ b/drivers/tee/amdtee/core.c
@@ -3,6 +3,8 @@
* Copyright 2019 Advanced Micro Devices, Inc.
*/
+ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
#include <linux/errno.h>
#include <linux/io.h>
#include <linux/module.h>
@@ -458,7 +460,7 @@ static int __init amdtee_driver_init(void)
rc = psp_check_tee_status();
if (rc) {
- pr_err("amd-tee driver: tee not present\n");
+ pr_err("tee not present\n");
return rc;
}
@@ -494,7 +496,6 @@ static int __init amdtee_driver_init(void)
drv_data->amdtee = amdtee;
- pr_info("amd-tee driver initialization successful\n");
return 0;
err_device_unregister:
@@ -510,7 +511,7 @@ static int __init amdtee_driver_init(void)
kfree(drv_data);
drv_data = NULL;
- pr_err("amd-tee driver initialization failed\n");
+ pr_err("initialization failed\n");
return rc;
}
module_init(amdtee_driver_init);
--
2.43.0
next prev parent reply other threads:[~2025-04-21 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 15:22 [PATCH 0/2] small amdtee cleanups Mario Limonciello
2025-04-21 15:22 ` Mario Limonciello [this message]
2025-04-28 7:45 ` [PATCH 1/2] tee: Use pr_fmt for messages Sumit Garg
2025-04-21 15:22 ` [PATCH 2/2] tee: Sort header includes Mario Limonciello
2025-04-28 7:45 ` Sumit Garg
2025-04-28 14:27 ` [PATCH 0/2] small amdtee cleanups Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421152238.764659-2-superm1@kernel.org \
--to=superm1@kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.