All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sumit Garg <sumit.garg@kernel.org>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH 2/2] tee: Sort header includes
Date: Mon, 28 Apr 2025 13:15:45 +0530	[thread overview]
Message-ID: <aA8yKYm1zyNfy3ky@sumit-X1> (raw)
In-Reply-To: <20250421152238.764659-3-superm1@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]

On Mon, Apr 21, 2025 at 10:22:23AM -0500, Mario Limonciello via OP-TEE wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
> 
> Various headers have been added over time that are not added alphabetically
> and a private header is used before one of the linux/ headers.
> 
> Resort the list.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/tee/amdtee/core.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> 
> diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
> index a44625d076401..fb39d9a19c698 100644
> --- a/drivers/tee/amdtee/core.c
> +++ b/drivers/tee/amdtee/core.c
> @@ -6,18 +6,19 @@
>   #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>  
>  #include <linux/errno.h>
> +#include <linux/device.h>
> +#include <linux/firmware.h>
>  #include <linux/io.h>
> +#include <linux/mm.h>
>  #include <linux/module.h>
> +#include <linux/psp-tee.h>
>  #include <linux/slab.h>
>  #include <linux/string.h>
> -#include <linux/device.h>
>  #include <linux/tee_core.h>
>  #include <linux/types.h>
> -#include <linux/mm.h>
>  #include <linux/uaccess.h>
> -#include <linux/firmware.h>
> +
>  #include "amdtee_private.h"
> -#include <linux/psp-tee.h>
>  
>  static struct amdtee_driver_data *drv_data;
>  static DEFINE_MUTEX(session_list_mutex);
> -- 
> 2.43.0
> 

  reply	other threads:[~2025-04-28  7:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21 15:22 [PATCH 0/2] small amdtee cleanups Mario Limonciello
2025-04-21 15:22 ` [PATCH 1/2] tee: Use pr_fmt for messages Mario Limonciello
2025-04-28  7:45   ` Sumit Garg
2025-04-21 15:22 ` [PATCH 2/2] tee: Sort header includes Mario Limonciello
2025-04-28  7:45   ` Sumit Garg [this message]
2025-04-28 14:27 ` [PATCH 0/2] small amdtee cleanups Jens Wiklander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aA8yKYm1zyNfy3ky@sumit-X1 \
    --to=sumit.garg@kernel.org \
    --cc=op-tee@lists.trustedfirmware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.