All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 5.4+] MIPS: cevt-ds1287: Add missing ds1287.h include
@ 2025-04-22  9:16 WangYuli
  2025-04-22 19:17 ` Sasha Levin
  0 siblings, 1 reply; 2+ messages in thread
From: WangYuli @ 2025-04-22  9:16 UTC (permalink / raw)
  To: gregkh, sashal, stable
  Cc: macro, tsbogend, wangyuli, linux-mips, linux-kernel

[ Upstream commit f3be225f338a578851a7b607a409f476354a8deb ]

Address the issue of cevt-ds1287.c not including the ds1287.h header
file.

Fix follow errors with gcc-14 when -Werror:

arch/mips/kernel/cevt-ds1287.c:15:5: error: no previous prototype for ‘ds1287_timer_state’ [-Werror=missing-prototypes]
   15 | int ds1287_timer_state(void)
      |     ^~~~~~~~~~~~~~~~~~
arch/mips/kernel/cevt-ds1287.c:20:5: error: no previous prototype for ‘ds1287_set_base_clock’ [-Werror=missing-prototypes]
   20 | int ds1287_set_base_clock(unsigned int hz)
      |     ^~~~~~~~~~~~~~~~~~~~~
arch/mips/kernel/cevt-ds1287.c:103:12: error: no previous prototype for ‘ds1287_clockevent_init’ [-Werror=missing-prototypes]
  103 | int __init ds1287_clockevent_init(int irq)
      |            ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[7]: *** [scripts/Makefile.build:207: arch/mips/kernel/cevt-ds1287.o] Error 1
make[7]: *** Waiting for unfinished jobs....
make[6]: *** [scripts/Makefile.build:465: arch/mips/kernel] Error 2
make[6]: *** Waiting for unfinished jobs....

Signed-off-by: WangYuli <wangyuli@uniontech.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
 arch/mips/kernel/cevt-ds1287.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/kernel/cevt-ds1287.c b/arch/mips/kernel/cevt-ds1287.c
index 9a47fbcd4638..de64d6bb7ba3 100644
--- a/arch/mips/kernel/cevt-ds1287.c
+++ b/arch/mips/kernel/cevt-ds1287.c
@@ -10,6 +10,7 @@
 #include <linux/mc146818rtc.h>
 #include <linux/irq.h>
 
+#include <asm/ds1287.h>
 #include <asm/time.h>
 
 int ds1287_timer_state(void)
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 5.4+] MIPS: cevt-ds1287: Add missing ds1287.h include
  2025-04-22  9:16 [PATCH 5.4+] MIPS: cevt-ds1287: Add missing ds1287.h include WangYuli
@ 2025-04-22 19:17 ` Sasha Levin
  0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2025-04-22 19:17 UTC (permalink / raw)
  To: stable; +Cc: WangYuli, Sasha Levin

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: f3be225f338a578851a7b607a409f476354a8deb

Status in newer kernel trees:
6.14.y | Not found
6.12.y | Not found
6.6.y | Not found
6.1.y | Not found
5.15.y | Not found
5.10.y | Not found

Note: The patch differs from the upstream commit:
---
1:  f3be225f338a5 ! 1:  76449fe1f2e7d MIPS: cevt-ds1287: Add missing ds1287.h include
    @@ Metadata
      ## Commit message ##
         MIPS: cevt-ds1287: Add missing ds1287.h include
     
    +    [ Upstream commit f3be225f338a578851a7b607a409f476354a8deb ]
    +
         Address the issue of cevt-ds1287.c not including the ds1287.h header
         file.
     
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.4.y        |  Success    |  Success   |

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-22 19:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-22  9:16 [PATCH 5.4+] MIPS: cevt-ds1287: Add missing ds1287.h include WangYuli
2025-04-22 19:17 ` Sasha Levin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.