All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Longbin Li <looong.bin@gmail.com>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Chen Wang" <unicorn_wang@outlook.com>,
	"Inochi Amaoto" <inochiama@gmail.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
	sophgo@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: pwm: sophgo: add pwm controller for SG2044
Date: Tue, 22 Apr 2025 08:56:43 -0500	[thread overview]
Message-ID: <20250422135643.GA1132004-robh@kernel.org> (raw)
In-Reply-To: <20250418022948.22853-2-looong.bin@gmail.com>

On Fri, Apr 18, 2025 at 10:29:44AM +0800, Longbin Li wrote:
> Add compatible string for PWM controller on SG2044.

That is clear from reading the diff. What would be useful is details on 
how the h/w is different from SG2042 (and hence not compatible with it).

> 
> Signed-off-by: Longbin Li <looong.bin@gmail.com>
> ---
>  Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Acked-by: Rob Herring (Arm) <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Longbin Li <looong.bin@gmail.com>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Chen Wang" <unicorn_wang@outlook.com>,
	"Inochi Amaoto" <inochiama@gmail.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
	sophgo@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: pwm: sophgo: add pwm controller for SG2044
Date: Tue, 22 Apr 2025 08:56:43 -0500	[thread overview]
Message-ID: <20250422135643.GA1132004-robh@kernel.org> (raw)
In-Reply-To: <20250418022948.22853-2-looong.bin@gmail.com>

On Fri, Apr 18, 2025 at 10:29:44AM +0800, Longbin Li wrote:
> Add compatible string for PWM controller on SG2044.

That is clear from reading the diff. What would be useful is details on 
how the h/w is different from SG2042 (and hence not compatible with it).

> 
> Signed-off-by: Longbin Li <looong.bin@gmail.com>
> ---
>  Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Acked-by: Rob Herring (Arm) <robh@kernel.org>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2025-04-22 13:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18  2:29 [PATCH v2 0/3] riscv: pwm: sophgo: add pwm support for SG2044 Longbin Li
2025-04-18  2:29 ` Longbin Li
2025-04-18  2:29 ` [PATCH v2 1/3] dt-bindings: pwm: sophgo: add pwm controller " Longbin Li
2025-04-18  2:29   ` Longbin Li
2025-04-19  1:13   ` Chen Wang
2025-04-19  1:13     ` Chen Wang
2025-04-22 13:56   ` Rob Herring [this message]
2025-04-22 13:56     ` Rob Herring
2025-04-18  2:29 ` [PATCH v2 2/3] pwm: sophgo: reorganize the code structure Longbin Li
2025-04-18  2:29   ` Longbin Li
2025-04-19  1:20   ` Chen Wang
2025-04-19  1:20     ` Chen Wang
2025-04-18  2:29 ` [PATCH v2 3/3] pwm: sophgo: add driver for SG2044 Longbin Li
2025-04-18  2:29   ` Longbin Li
2025-04-18 15:11   ` [External] : " ALOK TIWARI
2025-04-18 15:11     ` ALOK TIWARI
2025-04-19  1:01     ` Longbin Li
2025-04-19  1:01       ` Longbin Li
2025-04-19  1:24   ` Chen Wang
2025-04-19  1:24     ` Chen Wang
2025-04-19  7:36     ` Longbin Li
2025-04-19  7:36       ` Longbin Li
2025-04-19  1:27 ` [PATCH v2 0/3] riscv: pwm: sophgo: add pwm support " Chen Wang
2025-04-19  1:27   ` Chen Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250422135643.GA1132004-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=inochiama@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=looong.bin@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=sophgo@lists.linux.dev \
    --cc=ukleinek@kernel.org \
    --cc=unicorn_wang@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.