[LTP] [PATCH] Makefile: Fix circular dependency in distclean target

[LTP] [PATCH] Makefile: Fix circular dependency in distclean target

[Ricardo B. Marlière via ltp]

From: Ricardo B. Marlière <rbm@suse.com>

When calling the `make distclean` target, we see this:

make: Circular include-clean <- distclean dependency dropped.

Fix it by adding distclean to INCLUDE_CLEAN_RDEP_SUBJECT first condition
filter.

Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 5066789349837ed74d70fd50a90d6472f0966601..eab40da8a6b979540c5fe8dd24d17e23fbcb0142 100644
--- a/Makefile
+++ b/Makefile
@@ -96,8 +96,8 @@ $(filter-out include-clean,$(CLEAN_TARGETS))::
 
 # Just like everything depends on include-all / -install, we need to get rid
 # of include last to ensure that things won't be monkey screwed up. Only do
-# this if we're invoking clean or a subclean directly though.
-ifneq ($(filter clean,$(MAKECMDGOALS)),)
+# this if we're invoking clean, distclean or a subclean directly though.
+ifneq ($(filter clean distclean,$(MAKECMDGOALS)),)
 INCLUDE_CLEAN_RDEP_SUBJECT	:= $(CLEAN_TARGETS)
 else
 ifneq ($(filter %clean,$(MAKECMDGOALS)),)

---
base-commit: 8000c950d6ba61a541a9278cdda6d68141c2fc0d
change-id: 20250409-fixes-distclean_circ_dep-35f8b4ad691d

Best regards,
-- 
Ricardo B. Marlière <rbm@suse.com>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] Makefile: Fix circular dependency in distclean target

[Petr Vorel]

Hi Ricardo,

merged, thank you!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp