From: Simon Horman <horms@kernel.org>
To: Jacek Kowalski <jacek@jacekk.info>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set
Date: Thu, 24 Apr 2025 17:24:44 +0100 [thread overview]
Message-ID: <20250424162444.GH3042781@horms.kernel.org> (raw)
In-Reply-To: <5555d3bd-44f6-45c1-9413-c29fe28e79eb@jacekk.info>
On Tue, Apr 22, 2025 at 09:43:01AM +0200, Jacek Kowalski wrote:
> Some Dell Tiger Lake systems have incorrect NVM checksum. These also
> have a bitmask that indicates correct checksum set to "invalid".
>
> Because it is impossible to determine whether the NVM write would finish
> correctly or hang (see https://bugzilla.kernel.org/show_bug.cgi?id=213667)
> it makes sense to skip the validation completely under these conditions.
>
> Signed-off-by: Jacek Kowalski <Jacek@jacekk.info>
> Fixes: 4051f68318ca9 ("e1000e: Do not take care about recovery NVM checksum")
I think that while the commit cited above relates to this problem,
this bug actually dates back to the patch I'm citing immediately below.
And I think we should cite that commit here. IOW, I'm suggesting:
Fixes: fb776f5d57ee ("e1000e: Add support for Tiger Lake")
> Cc: stable@vger.kernel.org
That not withstanding, based on the commit message,
and the use of e1000_pch_tgp in another Tiger Lake fix [1],
I think this patch looks good.
Reviewed-by: Simon Horman <horms@kernel.org>
[1] commit ffd24fa2fcc7 ("e1000e: Correct NVM checksum verification flow")
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jacek Kowalski <jacek@jacekk.info>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set
Date: Thu, 24 Apr 2025 17:24:44 +0100 [thread overview]
Message-ID: <20250424162444.GH3042781@horms.kernel.org> (raw)
In-Reply-To: <5555d3bd-44f6-45c1-9413-c29fe28e79eb@jacekk.info>
On Tue, Apr 22, 2025 at 09:43:01AM +0200, Jacek Kowalski wrote:
> Some Dell Tiger Lake systems have incorrect NVM checksum. These also
> have a bitmask that indicates correct checksum set to "invalid".
>
> Because it is impossible to determine whether the NVM write would finish
> correctly or hang (see https://bugzilla.kernel.org/show_bug.cgi?id=213667)
> it makes sense to skip the validation completely under these conditions.
>
> Signed-off-by: Jacek Kowalski <Jacek@jacekk.info>
> Fixes: 4051f68318ca9 ("e1000e: Do not take care about recovery NVM checksum")
I think that while the commit cited above relates to this problem,
this bug actually dates back to the patch I'm citing immediately below.
And I think we should cite that commit here. IOW, I'm suggesting:
Fixes: fb776f5d57ee ("e1000e: Add support for Tiger Lake")
> Cc: stable@vger.kernel.org
That not withstanding, based on the commit message,
and the use of e1000_pch_tgp in another Tiger Lake fix [1],
I think this patch looks good.
Reviewed-by: Simon Horman <horms@kernel.org>
[1] commit ffd24fa2fcc7 ("e1000e: Correct NVM checksum verification flow")
next prev parent reply other threads:[~2025-04-24 16:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 7:43 [Intel-wired-lan] [PATCH] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set Jacek Kowalski
2025-04-22 7:43 ` Jacek Kowalski
2025-04-22 8:39 ` [Intel-wired-lan] " Lifshits, Vitaly
2025-04-24 16:24 ` Simon Horman [this message]
2025-04-24 16:24 ` Simon Horman
2025-04-24 16:46 ` [Intel-wired-lan] " Jacek Kowalski
2025-04-24 16:46 ` Jacek Kowalski
2025-04-24 17:18 ` [Intel-wired-lan] " Simon Horman
2025-04-24 17:18 ` Simon Horman
2025-04-24 17:37 ` [Intel-wired-lan] " Jacek Kowalski
2025-04-24 17:37 ` Jacek Kowalski
2025-04-25 16:45 ` [Intel-wired-lan] " Simon Horman
2025-04-25 16:45 ` Simon Horman
2025-04-24 16:59 ` [Intel-wired-lan] " Lifshits, Vitaly
2025-04-24 17:29 ` Jacek Kowalski
2025-04-27 13:26 ` Lifshits, Vitaly
2025-04-28 16:43 ` Jacek Kowalski
2025-05-04 9:13 ` Lifshits, Vitaly
2025-05-12 17:25 ` Vlad URSU
2025-05-12 17:25 ` Vlad URSU
2025-05-15 4:39 ` [Intel-wired-lan] " Lifshits, Vitaly
2025-05-15 19:07 ` Vlad URSU
2025-06-01 10:19 ` Lifshits, Vitaly
2025-06-02 18:44 ` Vlad URSU
2025-06-03 9:22 ` Lifshits, Vitaly
2025-06-03 21:00 ` Jacek Kowalski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424162444.GH3042781@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacek@jacekk.info \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.