All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Da Xue <da@lessconfused.com>
Cc: Simon Horman <horms@kernel.org>, Da Xue <da@libre.computer>,
	Andrew Lunn <andrew@lunn.ch>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Russell King <linux@armlinux.org.uk>,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, Jerome Brunet <jbrunet@baylibre.com>,
	linux-amlogic@lists.infradead.org,
	Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH v3] net: mdio: mux-meson-gxl: set reversed bit when using internal phy
Date: Tue, 29 Apr 2025 12:02:10 -0700	[thread overview]
Message-ID: <20250429120210.0aa6fa81@kernel.org> (raw)
In-Reply-To: <CACdvmAhcBmoDNyuu0npZzyExfhyLKdyPw9HvHvV+OdADxEfJJQ@mail.gmail.com>

On Mon, 28 Apr 2025 20:44:14 -0400 Da Xue wrote:
> > On Fri, Apr 25, 2025 at 03:20:09PM -0400, Da Xue wrote:  
> > > This bit is necessary to receive packets from the internal PHY.
> > > Without this bit set, no activity occurs on the interface.
> > >
> > > Normally u-boot sets this bit, but if u-boot is compiled without
> > > net support, the interface will be up but without any activity.
> > >
> > > The vendor SDK sets this bit along with the PHY_ID bits.  
> >
> > I'd like to clarify that:
> > Without this patch the writel the patch is modifying will clear the PHY_ID bit.
> > But despite that the system works if at some point (uboot) set the PHY_ID bit?  
> 
> Correct. If this is set once, it will work until the IP is powered
> down or reset.
> If u-boot does not set it, Linux will not set it and the IP will not work.
> If u-boot does set it, the IP will not work after suspend-resume since
> the IP is reset.
> Thus, we need to set it on the Linux side when bringing up the interface.

Added to the commit message when applying, thank you both!

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Da Xue <da@lessconfused.com>
Cc: Simon Horman <horms@kernel.org>, Da Xue <da@libre.computer>,
	Andrew Lunn <andrew@lunn.ch>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Russell King <linux@armlinux.org.uk>,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, Jerome Brunet <jbrunet@baylibre.com>,
	linux-amlogic@lists.infradead.org,
	Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH v3] net: mdio: mux-meson-gxl: set reversed bit when using internal phy
Date: Tue, 29 Apr 2025 12:02:10 -0700	[thread overview]
Message-ID: <20250429120210.0aa6fa81@kernel.org> (raw)
In-Reply-To: <CACdvmAhcBmoDNyuu0npZzyExfhyLKdyPw9HvHvV+OdADxEfJJQ@mail.gmail.com>

On Mon, 28 Apr 2025 20:44:14 -0400 Da Xue wrote:
> > On Fri, Apr 25, 2025 at 03:20:09PM -0400, Da Xue wrote:  
> > > This bit is necessary to receive packets from the internal PHY.
> > > Without this bit set, no activity occurs on the interface.
> > >
> > > Normally u-boot sets this bit, but if u-boot is compiled without
> > > net support, the interface will be up but without any activity.
> > >
> > > The vendor SDK sets this bit along with the PHY_ID bits.  
> >
> > I'd like to clarify that:
> > Without this patch the writel the patch is modifying will clear the PHY_ID bit.
> > But despite that the system works if at some point (uboot) set the PHY_ID bit?  
> 
> Correct. If this is set once, it will work until the IP is powered
> down or reset.
> If u-boot does not set it, Linux will not set it and the IP will not work.
> If u-boot does set it, the IP will not work after suspend-resume since
> the IP is reset.
> Thus, we need to set it on the Linux side when bringing up the interface.

Added to the commit message when applying, thank you both!


  reply	other threads:[~2025-04-29 19:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25 19:20 [PATCH v3] net: mdio: mux-meson-gxl: set reversed bit when using internal phy Da Xue
2025-04-25 19:20 ` Da Xue
2025-04-25 19:22 ` kernel test robot
2025-04-28 18:12 ` Simon Horman
2025-04-28 18:12   ` Simon Horman
2025-04-29  0:44   ` Da Xue
2025-04-29  0:44     ` Da Xue
2025-04-29 19:02     ` Jakub Kicinski [this message]
2025-04-29 19:02       ` Jakub Kicinski
2025-04-29 19:10 ` patchwork-bot+netdevbpf
2025-04-29 19:10   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250429120210.0aa6fa81@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=da@lessconfused.com \
    --cc=da@libre.computer \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.