All of lore.kernel.org
 help / color / mirror / Atom feed
* [morse:mpam/snapshot+extras/v6.15-rc3 128/152] fs/resctrl/ctrlmondata.c:585:9: error: implicit declaration of function 'resctrl_arch_mon_ctx_free'; did you mean 'resctrl_arch_mon_ctx_alloc'?
@ 2025-04-29 15:12 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-04-29 15:12 UTC (permalink / raw)
  To: James Morse; +Cc: oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/snapshot+extras/v6.15-rc3
head:   89e83f0ddb42053b6e3e6d4a9ce2fd3dd521c3d6
commit: c4df656cb6afb482b2d7cb0bc404beb995ffe165 [128/152] x86/resctrl: Add stub to allow other architecture to disable monitor overflow
config: x86_64-buildonly-randconfig-002-20250429 (https://download.01.org/0day-ci/archive/20250429/202504292308.nO2DWRuw-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250429/202504292308.nO2DWRuw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504292308.nO2DWRuw-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/resctrl/ctrlmondata.c: In function 'mon_event_read':
>> fs/resctrl/ctrlmondata.c:585:9: error: implicit declaration of function 'resctrl_arch_mon_ctx_free'; did you mean 'resctrl_arch_mon_ctx_alloc'? [-Werror=implicit-function-declaration]
     585 |         resctrl_arch_mon_ctx_free(r, evtid, rr->arch_mon_ctx);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~
         |         resctrl_arch_mon_ctx_alloc
   cc1: some warnings being treated as errors
--
   fs/resctrl/monitor.c: In function '__check_limbo':
>> fs/resctrl/monitor.c:188:9: error: implicit declaration of function 'resctrl_arch_mon_ctx_free'; did you mean 'resctrl_arch_mon_ctx_alloc'? [-Werror=implicit-function-declaration]
     188 |         resctrl_arch_mon_ctx_free(r, QOS_L3_OCCUP_EVENT_ID, arch_mon_ctx);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~
         |         resctrl_arch_mon_ctx_alloc
   cc1: some warnings being treated as errors


vim +585 fs/resctrl/ctrlmondata.c

37d06f24730eb0 James Morse 2025-04-24  548  
37d06f24730eb0 James Morse 2025-04-24  549  void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,
37d06f24730eb0 James Morse 2025-04-24  550  		    struct rdt_mon_domain *d, struct rdtgroup *rdtgrp,
37d06f24730eb0 James Morse 2025-04-24  551  		    cpumask_t *cpumask, int evtid, int first)
37d06f24730eb0 James Morse 2025-04-24  552  {
37d06f24730eb0 James Morse 2025-04-24  553  	int cpu;
37d06f24730eb0 James Morse 2025-04-24  554  
37d06f24730eb0 James Morse 2025-04-24  555  	/* When picking a CPU from cpu_mask, ensure it can't race with cpuhp */
37d06f24730eb0 James Morse 2025-04-24  556  	lockdep_assert_cpus_held();
37d06f24730eb0 James Morse 2025-04-24  557  
37d06f24730eb0 James Morse 2025-04-24  558  	/*
37d06f24730eb0 James Morse 2025-04-24  559  	 * Setup the parameters to pass to mon_event_count() to read the data.
37d06f24730eb0 James Morse 2025-04-24  560  	 */
37d06f24730eb0 James Morse 2025-04-24  561  	rr->rgrp = rdtgrp;
37d06f24730eb0 James Morse 2025-04-24  562  	rr->evtid = evtid;
37d06f24730eb0 James Morse 2025-04-24  563  	rr->r = r;
37d06f24730eb0 James Morse 2025-04-24  564  	rr->d = d;
37d06f24730eb0 James Morse 2025-04-24  565  	rr->first = first;
37d06f24730eb0 James Morse 2025-04-24  566  	rr->arch_mon_ctx = resctrl_arch_mon_ctx_alloc(r, evtid);
37d06f24730eb0 James Morse 2025-04-24  567  	if (IS_ERR(rr->arch_mon_ctx)) {
37d06f24730eb0 James Morse 2025-04-24  568  		rr->err = -EINVAL;
37d06f24730eb0 James Morse 2025-04-24  569  		return;
37d06f24730eb0 James Morse 2025-04-24  570  	}
37d06f24730eb0 James Morse 2025-04-24  571  
37d06f24730eb0 James Morse 2025-04-24  572  	cpu = cpumask_any_housekeeping(cpumask, RESCTRL_PICK_ANY_CPU);
37d06f24730eb0 James Morse 2025-04-24  573  
37d06f24730eb0 James Morse 2025-04-24  574  	/*
37d06f24730eb0 James Morse 2025-04-24  575  	 * cpumask_any_housekeeping() prefers housekeeping CPUs, but
37d06f24730eb0 James Morse 2025-04-24  576  	 * are all the CPUs nohz_full? If yes, pick a CPU to IPI.
37d06f24730eb0 James Morse 2025-04-24  577  	 * MPAM's resctrl_arch_rmid_read() is unable to read the
37d06f24730eb0 James Morse 2025-04-24  578  	 * counters on some platforms if its called in IRQ context.
37d06f24730eb0 James Morse 2025-04-24  579  	 */
37d06f24730eb0 James Morse 2025-04-24  580  	if (tick_nohz_full_cpu(cpu))
37d06f24730eb0 James Morse 2025-04-24  581  		smp_call_function_any(cpumask, mon_event_count, rr, 1);
37d06f24730eb0 James Morse 2025-04-24  582  	else
37d06f24730eb0 James Morse 2025-04-24  583  		smp_call_on_cpu(cpu, smp_mon_event_count, rr, false);
37d06f24730eb0 James Morse 2025-04-24  584  
37d06f24730eb0 James Morse 2025-04-24 @585  	resctrl_arch_mon_ctx_free(r, evtid, rr->arch_mon_ctx);
37d06f24730eb0 James Morse 2025-04-24  586  }
37d06f24730eb0 James Morse 2025-04-24  587  

:::::: The code at line 585 was first introduced by commit
:::::: 37d06f24730eb0e770949e2d27f04b9639a994dc AUTO SPLIT

:::::: TO: James Morse <james.morse@arm.com>
:::::: CC: James Morse <james.morse@arm.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-04-29 15:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-29 15:12 [morse:mpam/snapshot+extras/v6.15-rc3 128/152] fs/resctrl/ctrlmondata.c:585:9: error: implicit declaration of function 'resctrl_arch_mon_ctx_free'; did you mean 'resctrl_arch_mon_ctx_alloc'? kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.