Re: [PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Anusha Srivatsa <asrivats@redhat.com>,
	Paul Kocialkowski <paulk@sys-base.io>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Hui Pu <Hui.Pu@gehealthcare.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	dri-devel@lists.freedesktop.org, asahi@lists.linux.dev,
	linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	linux-stm32@st-md-mailman.stormreply.com,
	Adam Ford <aford173@gmail.com>,
	Adrien Grassein <adrien.grassein@gmail.com>,
	Aleksandr Mishin <amishin@t-argos.ru>,
	Andy Yan <andy.yan@rock-chips.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Benson Leung <bleung@chromium.org>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Christoph Fritz <chf.fritz@googlemail.com>,
	Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
	Detlev Casanova <detlev.casanova@collabora.com>,
	Dharma Balasubiramani <dharma.b@microchip.com>,
	Guenter Roeck <groeck@chromium.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Jani Nikula <jani.nikula@intel.com>, Janne Grunau <j@jannau.net>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Jesse Van Gavere <jesseevg@gmail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Liu Ying <victor.liu@nxp.com>,
	Manikandan Muralidharan <manikandan.m@microchip.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Phong LE <ple@baylibre.com>,
	Sasha Finkelstein <fnkl.kernel@gmail.com>,
	Sugar Zhang <sugar.zhang@rock-chips.com>,
	Sui Jingfeng <sui.jingfeng@linux.dev>,
	Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>,
	Vitalii Mordan <mordan@ispras.ru>
Subject: Re: [PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API
Date: Wed, 30 Apr 2025 12:35:57 +0200	[thread overview]
Message-ID: <20250430123557.3d8b1de4@booty> (raw)
In-Reply-To: <CAD=FV=VmV5yb0HWWGTiKyyC8+WNPJpM7vE9PQGh5_=KPk6+HCg@mail.gmail.com>

Hello Doug,

On Mon, 28 Apr 2025 13:59:50 -0700
Doug Anderson <dianders@chromium.org> wrote:

[...]

> Reviewed-by: Douglas Anderson <dianders@chromium.org> # parade-ps8640
> Tested-by: Douglas Anderson <dianders@chromium.org> # parade-ps8640

Thank you for your review!

However I'll be sending v3 with some differences w.r.t. v2, in order to
fix the 3 bugs reported by Andy Yan plus a similar one I spotted. The
fix just is replacing PTR_ERR() with ERR_CAST() in the 4 cases where the
involved function is returning a pointer instead of an int.

Your review/test tags appear global to the whole patch, thus being the
patch different I think I cannot include your tags in v3.

Let me know if you think I should do differently.

Sorry about that.

Best regards,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com