Re: [PATCH 4/7] iommu: Remove iommu_ops pgsize_bitmap from simple drivers

From: Jason Gunthorpe <jgg@nvidia.com>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Alexandre Ghiti <alex@ghiti.fr>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	asahi@lists.linux.dev,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
	Heiko Stuebner <heiko@sntech.de>,
	iommu@lists.linux.dev, Janne Grunau <j@jannau.net>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Joerg Roedel <joro@8bytes.org>, Kevin Tian <kevin.tian@intel.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-riscv@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	Neal Gompa <neal@gompa.dev>, Orson Zhai <orsonzhai@gmail.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Rob Clark <robdclark@gmail.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Samuel Holland <samuel@sholland.org>,
	Sven Peter <sven@svenpeter.dev>,
	Thierry Reding <thierry.reding@gmail.com>,
	Tomasz Jeznach <tjeznach@rivosinc.com>,
	Krishna Reddy <vdumpa@nvidia.com>,
	virtualization@lists.linux.dev, Chen-Yu Tsai <wens@csie.org>,
	Will Deacon <will@kernel.org>, Yong Wu <yong.wu@mediatek.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	patches@lists.linux.dev
Subject: Re: [PATCH 4/7] iommu: Remove iommu_ops pgsize_bitmap from simple drivers
Date: Wed, 30 Apr 2025 10:21:35 -0300	[thread overview]
Message-ID: <20250430132135.GG2260709@nvidia.com> (raw)
In-Reply-To: <176e3870fd0284a05a19d424ad1a56e73120573c.camel@linux.ibm.com>

On Wed, Apr 30, 2025 at 03:15:14PM +0200, Niklas Schnelle wrote:
> > diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c
> > index 433b59f435302b..9c80d61deb2c0b 100644
> > --- a/drivers/iommu/s390-iommu.c
> > +++ b/drivers/iommu/s390-iommu.c
> > @@ -557,6 +557,7 @@ static struct iommu_domain *s390_domain_alloc_paging(struct device *dev)
> >  	}
> >  	zdev->end_dma = zdev->start_dma + aperture_size - 1;
> >  
> > +	s390_domain->domain.pgsize_bitmap = SZ_4K;
> >  	s390_domain->domain.geometry.force_aperture = true;
> >  	s390_domain->domain.geometry.aperture_start = 0;
> >  	s390_domain->domain.geometry.aperture_end = max_tbl_size(s390_domain);
> > @@ -1158,7 +1159,6 @@ static struct iommu_domain blocking_domain = {
> >  	.domain_alloc_paging = s390_domain_alloc_paging, \
> >  	.probe_device = s390_iommu_probe_device, \
> >  	.device_group = generic_device_group, \
> > -	.pgsize_bitmap = SZ_4K, \
> >  	.get_resv_regions = s390_iommu_get_resv_regions, \
> >  	.default_domain_ops = &(const struct iommu_domain_ops) { \
> >  		.attach_dev	= s390_iommu_attach_device, \
> 
> I'm guessing there's no particular thought behind not adding an empty
> line for s390-iommu.c like for the others? I slightly prefer not having
> an empty line here but would be fine with it too, so just curious.

I think it was just done at a different time, I had to rebase this
hunk..

Thanks,
Jason